pijul/pijul - Change OY3CGEHQCHMCPWQAXCW2SZCDIDTE2OB6CRFIDT7E2TCFFKXQ43XAC

Early stop in the diff algorithms for diff --short

Created by pmeunier on December 7, 2021

OY3CGEHQCHMCPWQAXCW2SZCDIDTE2OB6CRFIDT7E2TCFFKXQ43XAC

Dependencies

In channels

main

In discussions

#494 [DIFF, FEATURE REQUEST] --short is too expensive

Change contents

Insertion in pijul/src/commands/tag.rs at line 224 [5.74]
[4.1054]
[2.246]
```
        false,
```
Insertion in pijul/src/commands/reset.rs at line 116 [7.97650]
[6.7696]
[2.330]
```
                    false,
```
Insertion in pijul/src/commands/record.rs at line 309 [7.101759]
[8.1329]
[2.426]
```
                            false,
```
Insertion in pijul/src/commands/record.rs at line 323 [7.101759]
[8.1694]
[2.485]
```
                    false,
```
Insertion in pijul/src/commands/mod.rs at line 80 [7.133619]
[9.2019]
[2.777]
```
        false,
```
Insertion in pijul/src/commands/diff.rs at line 70 [7.173551]
[7.174593]
[2.1321]
```
                true,
```
Insertion in libpijul/src/working_copy/filesystem.rs at line 308 [7.208900]
[10.601]
[11.0]
```
            false,
```
Insertion in libpijul/src/record.rs at line 286 [7.488880]
[7.492781]
[11.46]
```
        stop_early: bool,
```
Insertion in libpijul/src/record.rs at line 328 [7.488880]
[12.151]
[11.161]
```
                            stop_early,
```
Insertion in libpijul/src/record.rs at line 519 [7.488880]
[12.549]
[11.196]
```
                    stop_early,
```
Insertion in libpijul/src/record.rs at line 897 [7.488880]
[7.499537]
[11.233]
```
        stop_early: bool,
```
Insertion in libpijul/src/record.rs at line 927 [7.488880]
[3.6946]
[3.6946]
```
                stop_early,
```
Insertion in libpijul/src/record.rs at line 961 [7.488880]
[3.7549]
[3.7549]
```
        stop_early: bool,
```
Insertion in libpijul/src/record.rs at line 1009 [7.488880]
[3.9185]
[3.9185]
```
                stop_early,
```
Insertion in libpijul/src/diff/mod.rs at line 134 [7.793247]
[7.794282]
[7.794282]
```
        stop_early: bool,
```
Replacement in libpijul/src/diff/mod.rs at line 168 [7.793247]
∅:D[13.115] → [7.796653:796713]
∅:D[14.930] → [7.796653:796713]
B:BD[7.796653] → [7.796653:796713]
```
        let dd = diff::diff(&lines_a, &lines_b, algorithm);
```
[14.930]
[7.796713]
```
        let dd = diff::diff(&lines_a, &lines_b, algorithm, stop_early);
```

Replacement in libpijul/src/diff/diff.rs at line 15 [7.801479]

B:BD[7.801776] → [7.801776:801952]

pub(super) fn diff(lines_a: &[Line], lines_b: &[Line], algorithm: Algorithm) -> D {
    let mut dd = diffs::Replace::new(D(Vec::with_capacity(lines_a.len() + lines_b.len())));

[7.801776]

[7.801952]

pub(super) fn diff(lines_a: &[Line], lines_b: &[Line], algorithm: Algorithm, stop_early: bool) -> D {
    let mut dd = diffs::Replace::new(D {
        r: Vec::with_capacity(lines_a.len() + lines_b.len()),
        stop_early,
    });

Replacement in libpijul/src/diff/diff.rs at line 30 [7.801479]
B:BD[7.802185] → [7.802185:802204]
```
        .unwrap(),
```
[7.802185]
[7.802204]
```
        .unwrap_or(()),
```
Replacement in libpijul/src/diff/diff.rs at line 40 [7.801479]
B:BD[7.802409] → [7.802409:802428]
```
        .unwrap(),
```
[7.802409]
[7.802428]
```
            .unwrap_or(()),
```
Replacement in libpijul/src/diff/diff.rs at line 45 [7.801479]
B:BD[7.802528] → [7.802528:802564]
```
pub struct D(pub Vec<Replacement>);
```
[7.802528]
[7.802564]
```
pub struct D {
    pub r: Vec<Replacement>,
    pub stop_early: bool,
}
```
Replacement in libpijul/src/diff/diff.rs at line 52 [7.801479]
B:BD[7.802607] → [7.802607:802628]
```
        self.0.len()
```
[7.802607]
[7.802628]
```
        self.r.len()
```
Replacement in libpijul/src/diff/diff.rs at line 59 [7.801479]
B:BD[7.802752] → [7.802752:802776]
```
        self.0.index(i)
```
[7.802752]
[7.802776]
```
        self.r.index(i)
```
Replacement in libpijul/src/diff/diff.rs at line 65 [7.801479]
B:BD[7.802884] → [7.802884:802912]
```
        self.0.index_mut(i)
```
[7.802884]
[7.802912]
```
        self.r.index_mut(i)
```
Replacement in libpijul/src/diff/diff.rs at line 82 [7.801479]
B:BD[7.803289] → [7.803289:803323]
```
        self.0.push(Replacement {
```
[7.803289]
[7.803323]
```
        self.r.push(Replacement {
```

Replacement in libpijul/src/diff/diff.rs at line 89 [7.801479]

B:BD[7.803444] → [7.803444:803459]

        Ok(())

[7.803444]

[7.803459]

        if self.stop_early {
            Err(())
        } else {
            Ok(())
        }

Replacement in libpijul/src/diff/diff.rs at line 97 [7.801479]
B:BD[7.803629] → [7.803629:803663]
```
        self.0.push(Replacement {
```
[7.803629]
[7.803663]
```
        self.r.push(Replacement {
```

Replacement in libpijul/src/diff/diff.rs at line 104 [7.801479]

B:BD[7.803784] → [7.803784:803799]

        Ok(())

[7.803784]

[7.803799]

        if self.stop_early {
            Err(())
        } else {
            Ok(())
        }

Replacement in libpijul/src/diff/diff.rs at line 121 [7.801479]
B:BD[7.804082] → [7.804082:804116]
```
        self.0.push(Replacement {
```
[7.804082]
[7.804116]
```
        self.r.push(Replacement {
```

Replacement in libpijul/src/diff/diff.rs at line 128 [7.801479]

B:BD[7.804234] → [7.804234:804249]

        Ok(())

[7.804234]

[7.804249]

        if self.stop_early {
            Err(())
        } else {
            Ok(())
        }

Replacement in libpijul/src/diff/diff.rs at line 150 [7.801479]

B:BD[7.804804] → [7.804804:804982]

        match self.0.binary_search_by(|repl| repl.old.cmp(&line)) {
            Ok(i) if self.0[i].old_len > 0 => Some(Deleted {
                replaced: self.0[i].new_len > 0,

[7.804804]

[7.804982]

        match self.r.binary_search_by(|repl| repl.old.cmp(&line)) {
            Ok(i) if self.r[i].old_len > 0 => Some(Deleted {
                replaced: self.r[i].new_len > 0,

Replacement in libpijul/src/diff/diff.rs at line 156 [7.801479]

B:BD[7.805087] → [7.805087:805229]

            Err(i) if line < self.0[i - 1].old + self.0[i - 1].old_len => Some(Deleted {
                replaced: self.0[i - 1].new_len > 0,

[7.805087]

[7.805229]

            Err(i) if line < self.r[i - 1].old + self.r[i - 1].old_len => Some(Deleted {
                replaced: self.r[i - 1].new_len > 0,

Early stop in the diff algorithms for diff --short

Dependencies

In channels

In discussions

Change contents

Insertion in pijul/src/commands/tag.rs at line 224 [5.74]

Insertion in pijul/src/commands/reset.rs at line 116 [7.97650]

Insertion in pijul/src/commands/record.rs at line 309 [7.101759]

Insertion in pijul/src/commands/record.rs at line 323 [7.101759]

Insertion in pijul/src/commands/mod.rs at line 80 [7.133619]

Insertion in pijul/src/commands/diff.rs at line 70 [7.173551]

Insertion in libpijul/src/working_copy/filesystem.rs at line 308 [7.208900]

Insertion in libpijul/src/record.rs at line 286 [7.488880]

Insertion in libpijul/src/record.rs at line 328 [7.488880]

Insertion in libpijul/src/record.rs at line 519 [7.488880]

Insertion in libpijul/src/record.rs at line 897 [7.488880]

Insertion in libpijul/src/record.rs at line 927 [7.488880]

Insertion in libpijul/src/record.rs at line 961 [7.488880]

Insertion in libpijul/src/record.rs at line 1009 [7.488880]

Insertion in libpijul/src/diff/mod.rs at line 134 [7.793247]

Replacement in libpijul/src/diff/mod.rs at line 168 [7.793247]

Replacement in libpijul/src/diff/diff.rs at line 15 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 30 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 40 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 45 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 52 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 59 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 65 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 82 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 89 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 97 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 104 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 121 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 128 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 150 [7.801479]

Replacement in libpijul/src/diff/diff.rs at line 156 [7.801479]