pijul/pijul - Change XO23J44S5GDTIWOHBWMDNQ2LPC5F52OIQQH5U7KYUI7PBUSTUVCAC

Make interactive unrecord safer

Created by spacefrogg on February 10, 2023

XO23J44S5GDTIWOHBWMDNQ2LPC5F52OIQQH5U7KYUI7PBUSTUVCAC

Dependencies

In discussions

#747 UnRecord dangerously inverts Pijul's UI convention, high risk of catastrophic data loss [+ RECOVERY HOWTO]

Change contents

Replacement in pijul/src/commands/unrecord.rs at line 3 [5.95630]
B:BD[3.1144] → [4.823:871]
```
use super::{make_changelist, parse_changelist};
```
[3.1144]
[6.26157]
```
use super::{make_changelist_act, parse_changelist};
```

Replacement in pijul/src/commands/unrecord.rs at line 79 [5.95630]

B:BD[7.3545] → [7.3545:3620]

            let o = make_changelist(&repo.changes, &hashes_, "unrecord")?;

[7.3545]

[2.0]

            let o = make_changelist_act(&repo.changes, &hashes_, "unrecord", true)?;

Insertion in pijul/src/commands/mod.rs at line 175 [5.133619]

[6.35617]

[4.2970]


fn make_changelist<S: libpijul::changestore::ChangeStore>(
  changes: &S,
  pullable: &[CS],
  verb: &str,
) -> Result<Vec<u8>, anyhow::Error> {
    make_changelist_act(changes, pullable, verb, false)
}

Replacement in pijul/src/commands/mod.rs at line 186 [5.133619]

B:BD[4.3060] → [4.3060:3119]

fn make_changelist<S: libpijul::changestore::ChangeStore>(

[4.3060]

[4.3119]

fn make_changelist_act<S: libpijul::changestore::ChangeStore>(

Insertion in pijul/src/commands/mod.rs at line 190 [5.133619]
[4.3185]
[4.3185]
```
    inactive: bool,
```
Insertion in pijul/src/commands/mod.rs at line 195 [5.133619]
[4.3274]
[4.3274]
```
    let pfx = if inactive { "#" } else { "" };
```
Replacement in pijul/src/commands/mod.rs at line 211 [5.133619]
B:BD[4.3660] → [4.3660:3698]
```
            writeln!(v, "").unwrap();
```
[4.3660]
[4.3698]
```
            writeln!(v, "#").unwrap();
```

Replacement in pijul/src/commands/mod.rs at line 216 [5.133619]

B:BD[6.35702] → [6.35702:35763]

                writeln!(v, "{}\n", p.to_base32()).unwrap();

[6.35702]

[6.35763]

                writeln!(v, "{}{}\n", pfx, p.to_base32()).unwrap();

Replacement in pijul/src/commands/mod.rs at line 219 [5.133619]

B:BD[6.35859] → [6.35859:35918]

                    write!(v, "  Dependencies:").unwrap();

[6.35859]

[6.35918]

                    write!(v, "#  Dependencies:").unwrap();

Replacement in pijul/src/commands/mod.rs at line 223 [5.133619]

B:BD[6.36042] → [6.36042:36084]

                    writeln!(v).unwrap();

[6.36042]

[6.36084]

                    writeln!(v, "#").unwrap();

Replacement in pijul/src/commands/mod.rs at line 228 [5.133619]

B:BD[6.36186] → [2.320:381]

                writeln!(v, "{}\n", p.to_base32()).unwrap();

[6.36186]

[6.36248]

                writeln!(v, "{}{}\n", pfx, p.to_base32()).unwrap();

Replacement in pijul/src/commands/mod.rs at line 232 [5.133619]
∅:D[6.36304] → [4.4107:4150]
B:BD[4.4107] → [4.4107:4150]
```
        write!(v, "  Author: [").unwrap();
```
[6.36304]
[4.4150]
```
        write!(v, "#  Author: [").unwrap();
```

Replacement in pijul/src/commands/mod.rs at line 246 [5.133619]

B:BD[4.4414] → [6.36347:36411]

        writeln!(v, "  Date: {}\n", header.timestamp).unwrap();

[4.4414]

[6.36411]

        writeln!(v, "#  Date: {}\n", header.timestamp).unwrap();

Replacement in pijul/src/commands/mod.rs at line 248 [5.133619]
∅:D[6.36453] → [4.4520:4567]
B:BD[4.4520] → [4.4520:4567]
```
            writeln!(v, "    {}", l).unwrap();
```
[6.36453]
[4.4567]
```
            writeln!(v, "#    {}", l).unwrap();
```
Replacement in pijul/src/commands/mod.rs at line 251 [5.133619]
∅:D[6.36503] → [4.4626:4660]
B:BD[4.4626] → [4.4626:4660]
```
            writeln!(v).unwrap();
```
[6.36503]
[4.4660]
```
            writeln!(v, "#").unwrap();
```

Replacement in pijul/src/commands/mod.rs at line 253 [5.133619]

B:BD[4.4696] → [4.4696:4747]

                writeln!(v, "    {}", l).unwrap();

[4.4696]

[4.4747]

                writeln!(v, "#    {}", l).unwrap();

Make interactive unrecord safer

Dependencies

In discussions

Change contents

Replacement in pijul/src/commands/unrecord.rs at line 3 [5.95630]

Replacement in pijul/src/commands/unrecord.rs at line 79 [5.95630]

Insertion in pijul/src/commands/mod.rs at line 175 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 186 [5.133619]

Insertion in pijul/src/commands/mod.rs at line 190 [5.133619]

Insertion in pijul/src/commands/mod.rs at line 195 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 211 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 216 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 219 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 223 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 228 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 232 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 246 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 248 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 251 [5.133619]

Replacement in pijul/src/commands/mod.rs at line 253 [5.133619]