pijul_org / pijul

#122 move into dir fails at record time

Opened by FlorentBecker, on June 9, 2017
FlorentBecker commented on June 9, 2017

This is documented in "move to dir". If one uses pijul mv to move a file into a directory, then record fails with the following error:

thread 'main' panicked at 'assertion failed: parent_node.line.is_root()', pijul/libpijul/src/record.rs:243
laumann commented on August 11, 2017

Bump! I'm hitting the same problem at the moment. But as it's implemented as a debug_assert! this error does not occur in release builds.

With a release build, recording a file move seems to work as intended, so maybe the debug_assert! should just be removed?

pmeunier commented on August 12, 2017

Yes, this debug_assert tests that we're not moving the file into a diretory created by this patch, which is probably not the right thing to test. I'm removing it now.