pijul_org / pijul

#216 Correctly use the TAG flag when recording a tag

Opened by lthms, on October 20, 2017
Feature
pijul-0.9
Closed
lthms commented on October 20, 2017

Okay then. I have been willing to display the tags using a special node shape in show-dependencies, leading me to find out nothing distinguish a tag from another “regular” patch. As a consequences, I have started to hack my way around this issue, only to find out if I set the flags field of UnsignedPatch with the correct value (as far as I understand), then the hash verification of the tag fails.

Any idea?

I guess we have to update the function from_reader_compressed somehow, but the related code is not very clear for me so I don’t know what to do. Any help is welcome!

lthms commented on October 20, 2017

There is an issue with the patch view.

lthms commented on October 25, 2017

Hi @pmeunier.

I was wondering if you by any chance had some time to have a look at this patch. I tried to get around but I can't see why it is not working and why I keep getting the WrongHash error for tags recorded with a pijul built with this patch ):

lthms commented on October 25, 2017

Outdated, see latest patch proposal

lthms commented on October 25, 2017

Preview

lthms commented on October 25, 2017

I think we are good for review!

lthms added tag
pijul-0.9
on November 15, 2017
lthms closed this discussion on November 30, 2017