pijul_org / pijul

#33 Handle the absence of SSH keys better

Opened by clayrat, on April 4, 2017
clayrat commented on April 4, 2017

Currently (at least on Windows) Pijul just crashes with a panic if the key is not found:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IO(Error { repr: Os { code: 2, message: "The system cannot find the file specified." } })', C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libcore\result.rs:868  

And if the key is in the wrong format:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: CouldNotReadKey', C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libcore\result.rs:868      

It would be nice to print a proper error message instead.

clayrat commented on April 5, 2017
pmeunier commented on May 19, 2017

Thanks for reporting! I believe this is fixed by #ARLk0ZpNJszZQlnSuFjq41iXThDmlne3fgicUHpVWShHoIJYm3oclQKLAjVpRR0OOMtUELT0zg9WHRRoxaUkx3Q

Feel free to reopen if this is not the case.