{"header":{"message":"Correct usage of `tokio::select!`","description":null,"timestamp":"2020-11-26T15:30:04.59560489Z","authors":[{"full_name":"Pierre-Étienne Meunier","name":"pmeunier"}]},"hash":"KNLLUDOIG47X7V7SMRTKBCLZ6SCKEETLNKBNS5ARCYCD2RJLIEQAC","authors":[],"deps":{"hashes":[["KNLLUDOIG47X7V7SMRTKBCLZ6SCKEETLNKBNS5ARCYCD2RJLIEQAC","Correct usage of `tokio::select!`"],["AA",null],["Y5HHIQXVHT3P7DNMG2G3UASKPLN4FBY7EY6ZSOWZBRJMPR6X6CGQC","Wait for the connection to be encrypted in `connect`"],["SJBZKVM5LUAKYLICNC5IKL6Y4GIMAZ4TBKTRU5UN3KGQ4L2GWBMQC","Debug messages"],["7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC","Reboot because of a bad change"]],"deps":["Y5HHIQXVHT3P7DNMG2G3UASKPLN4FBY7EY6ZSOWZBRJMPR6X6CGQC","SJBZKVM5LUAKYLICNC5IKL6Y4GIMAZ4TBKTRU5UN3KGQ4L2GWBMQC"],"known":["7FRJYUI62VW257VVFQXND6OKSAILVTHGEJCXFE6CG6FIOIUTDVYAC"]},"hunks":[{"Replacement":{"inode":{"change":4,"pos":166688},"path":"thrussh/src/ssh_read.rs","line":45,"ins":{"up_context":[{"change":4,"pos":167813}],"down_context":[{"change":4,"pos":167823}],"flag":"","start":0,"end":274,"inode":{"change":4,"pos":166688}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":167813},"to":{"change":4,"start":167813,"end":167823},"introduced_by":4}],"inode":{"change":4,"pos":166688}},"ins_contents":[{"Add":" pub r: R,"},{"Add":"}"},{"Add":""},{"Add":"impl SshRead {"},{"Add":" pub fn split(self) -> (SshRead>, tokio::io::WriteHalf) {"},{"Add":" let (r, w) = tokio::io::split(self.r);"},{"Add":" (SshRead {"},{"Add":" id: self.id,"},{"Add":" r"},{"Add":" }, w)"},{"Add":" }"}],"del_contents":[{"Del":" r: R,\n"}]}},{"Edit":{"inode":{"change":4,"pos":166688},"path":"thrussh/src/ssh_read.rs","line":58,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":167826}],"down_context":[{"change":4,"pos":167826}],"flag":"","start":275,"end":276,"inode":{"change":4,"pos":166688}}},"contents":[{"Add":""}]}},{"Edit":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":25,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":204219}],"down_context":[{"change":4,"pos":204219}],"flag":"","start":277,"end":293,"inode":{"change":4,"pos":203388}}},"contents":[{"Add":"use tokio::pin;"}]}},{"Edit":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":443,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":217871}],"down_context":[{"change":4,"pos":217871}],"flag":"","start":294,"end":608,"inode":{"change":4,"pos":203388}}},"contents":[{"Add":"}"},{"Add":""},{"Add":"async fn start_reading(mut stream_read: R, mut buffer: SSHBuffer, cipher: Arc) -> Result<(usize, R, SSHBuffer), anyhow::Error> {"},{"Add":" buffer.buffer.clear();"},{"Add":" let n = cipher::read(&mut stream_read, &mut buffer, &cipher).await?;"},{"Add":" Ok((n, stream_read, buffer))"}]}},{"Replacement":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":482,"ins":{"up_context":[{"change":4,"pos":218911}],"down_context":[{"change":4,"pos":218950}],"flag":"","start":609,"end":807,"inode":{"change":4,"pos":203388}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":218911},"to":{"change":4,"start":218911,"end":218950},"introduced_by":4}],"inode":{"change":4,"pos":203388}},"ins_contents":[{"Add":""},{"Add":" let (stream_read, mut stream_write) = stream.split();"},{"Add":" let buffer = SSHBuffer::new();"},{"Add":" let reading = start_reading(stream_read, buffer, session.common.cipher.clone());"},{"Add":" pin!(reading);"}],"del_contents":[{"Del":" let mut buffer = SSHBuffer::new();\n"}]}},{"Replacement":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":490,"ins":{"up_context":[{"change":4,"pos":219017}],"down_context":[{"change":4,"pos":219101}],"flag":"","start":808,"end":869,"inode":{"change":4,"pos":203388}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":219017},"to":{"change":4,"start":219017,"end":219101},"introduced_by":4}],"inode":{"change":4,"pos":203388}},"ins_contents":[{"Add":" Ok((_, stream_read, buffer)) = &mut reading => {"}],"del_contents":[{"Del":" _ = cipher::read(&mut stream, &mut buffer, &session.common.cipher) => {\n"}]}},{"Edit":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":524,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":220266}],"down_context":[{"change":4,"pos":220266}],"flag":"","start":870,"end":966,"inode":{"change":4,"pos":203388}}},"contents":[{"Add":" reading.set(start_reading(stream_read, buffer, session.common.cipher.clone()));"}]}},{"Replacement":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":563,"ins":{"up_context":[{"change":4,"pos":221994}],"down_context":[{"change":4,"pos":222009}],"flag":"","start":967,"end":988,"inode":{"change":4,"pos":203388}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":221994},"to":{"change":4,"start":221994,"end":222009},"introduced_by":4}],"inode":{"change":4,"pos":203388}},"ins_contents":[{"Add":" stream_write"}],"del_contents":[{"Del":" stream\n"}]}},{"Edit":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":566,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":222090},"to":{"change":4,"start":222090,"end":222121},"introduced_by":4}],"inode":{"change":4,"pos":203388}}},"contents":[{"Del":" buffer.buffer.clear();\n"}]}},{"Replacement":{"inode":{"change":4,"pos":203388},"path":"thrussh/src/server/mod.rs","line":570,"ins":{"up_context":[{"change":4,"pos":222223}],"down_context":[{"change":4,"pos":222398}],"flag":"","start":989,"end":1224,"inode":{"change":4,"pos":203388}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":222223},"to":{"change":4,"start":222223,"end":222398},"introduced_by":4}],"inode":{"change":4,"pos":203388}},"ins_contents":[{"Add":" stream_write.shutdown().await?;"},{"Add":" loop {"},{"Add":" let (n, r, b) = (&mut reading).await?;"},{"Add":" if n == 0 {"},{"Add":" break"},{"Add":" } else {"},{"Add":" reading.set(start_reading(r, b, session.common.cipher.clone()))"},{"Add":" }"}],"del_contents":[{"Del":" stream.shutdown().await?;\n buffer.buffer.clear();\n while cipher::read(&mut stream, &mut buffer, &session.common.cipher).await? != 0 {\n buffer.buffer.clear();\n"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":36,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":336202}],"down_context":[{"change":4,"pos":336202}],"flag":"","start":1225,"end":1241,"inode":{"change":4,"pos":334998}}},"contents":[{"Add":"use tokio::pin;"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":809,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":358296}],"down_context":[{"change":4,"pos":358296}],"flag":"","start":1242,"end":1556,"inode":{"change":4,"pos":334998}}},"contents":[{"Add":"async fn start_reading(mut stream_read: R, mut buffer: SSHBuffer, cipher: Arc) -> Result<(usize, R, SSHBuffer), anyhow::Error> {"},{"Add":" buffer.buffer.clear();"},{"Add":" let n = cipher::read(&mut stream_read, &mut buffer, &cipher).await?;"},{"Add":" Ok((n, stream_read, buffer))"},{"Add":"}"},{"Add":""}]}},{"Replacement":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":818,"ins":{"up_context":[{"change":4,"pos":358408}],"down_context":[{"change":4,"pos":358431}],"flag":"","start":1557,"end":1589,"inode":{"change":4,"pos":334998}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":358408},"to":{"change":4,"start":358408,"end":358431},"introduced_by":4}],"inode":{"change":4,"pos":334998}},"ins_contents":[{"Add":" mut stream: SshRead,"}],"del_contents":[{"Del":" mut stream: R,\n"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":829,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":358814},"to":{"change":4,"start":358814,"end":358857},"introduced_by":4}],"inode":{"change":4,"pos":334998}}},"contents":[{"Del":" let mut buffer = SSHBuffer::new();\n"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":831,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":358941}],"down_context":[{"change":4,"pos":358941}],"flag":"","start":1590,"end":1802,"inode":{"change":4,"pos":334998}}},"contents":[{"Add":""},{"Add":" let (stream_read, mut stream_write) = stream.split();"},{"Add":" let buffer = SSHBuffer::new();"},{"Add":" let reading = start_reading(stream_read, buffer, self.common.cipher.clone());"},{"Add":" pin!(reading);"},{"Add":""}]}},{"Replacement":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":839,"ins":{"up_context":[{"change":4,"pos":359012}],"down_context":[{"change":4,"pos":359160}],"flag":"","start":1803,"end":1917,"inode":{"change":4,"pos":334998}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":359012},"to":{"change":4,"start":359012,"end":359160},"introduced_by":4}],"inode":{"change":4,"pos":334998}},"ins_contents":[{"Add":" Ok((_, stream_read, buffer)) = &mut reading => {"},{"Add":" if buffer.buffer.len() < 5 {"}],"del_contents":[{"Del":" n = cipher::read(&mut stream, &mut buffer, &self.common.cipher) => {\n if n.is_err() || buffer.buffer.len() < 5 {\n"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":864,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":384}],"down_context":[{"change":4,"pos":360055}],"flag":"","start":1918,"end":2015,"inode":{"change":4,"pos":334998}}},"contents":[{"Add":" reading.set(start_reading(stream_read, buffer, self.common.cipher.clone()));"}]}},{"Replacement":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":930,"ins":{"up_context":[{"change":3,"pos":298}],"down_context":[{"change":4,"pos":364366}],"flag":"","start":2016,"end":2142,"inode":{"change":4,"pos":334998}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":298},"to":{"change":4,"start":364252,"end":364366},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":364252},"to":{"change":4,"start":364252,"end":364366},"introduced_by":4}],"inode":{"change":4,"pos":334998}},"ins_contents":[{"Add":" stream_write.write_all(&self.common.write_buffer.buffer).await?;"},{"Add":" stream_write.flush().await?;"}],"del_contents":[{"Del":" stream.write_all(&self.common.write_buffer.buffer).await?;\n stream.flush().await?;\n"}]}},{"Edit":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":933,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":364380},"to":{"change":4,"start":364380,"end":364415},"introduced_by":4}],"inode":{"change":4,"pos":334998}}},"contents":[{"Del":" buffer.buffer.clear();\n"}]}},{"Replacement":{"inode":{"change":4,"pos":334998},"path":"thrussh/src/client/mod.rs","line":943,"ins":{"up_context":[{"change":4,"pos":364852}],"down_context":[{"change":4,"pos":365095}],"flag":"","start":2143,"end":2187,"inode":{"change":4,"pos":334998}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":364852},"to":{"change":4,"start":364852,"end":365095},"introduced_by":4}],"inode":{"change":4,"pos":334998}},"ins_contents":[{"Add":" stream_write.shutdown().await?;"}],"del_contents":[{"Del":" stream.shutdown().await?;\n\n // Shutdown\n buffer.buffer.clear();\n while cipher::read(&mut stream, &mut buffer, &self.common.cipher).await? != 0 {\n buffer.buffer.clear();\n }\n"}]}}],"owner":"Eugeny","repo":"thrussh","token":"GLe/w60ORqoy+2SZbRkpPPWaLzJ9Uvwid8qdBhJJu30=","login":null}

…

Dependencies

Change contents