Finchie/l10n_embed - Change 5I5NR4DQA6SGUUJXCDBGATRVT2US6HMCCRFJB2YF2YG7ZZKSZHKQC

Make `Localize::CANONICAL_LOCALE` a function instead of associated constant

Part of making the Localize trait dyn-compatible, also allows a default implementation so generic formatters (such as numbers and strings) don't have to explicitly set their own canonical locale.

Created by finchie on July 21, 2025

5I5NR4DQA6SGUUJXCDBGATRVT2US6HMCCRFJB2YF2YG7ZZKSZHKQC

Dependencies

In channels

main

Change contents

Replacement in fluent_embed_derive/src/macro_impl/mod.rs at line 62 [5.76]

B:BD[4.391] → [4.391:454]

B:BD[4.454] → [6.579:628]

∅:D[6.628] → [4.530:604]

B:BD[4.530] → [4.530:604]

B:BD[4.604] → [6.629:680]

    let attribute: syn::LitStr = syn::parse2(attribute_stream)
        .map_err(ParseError::InvalidAttribute)?;
    let derive_input: syn::DeriveInput = syn::parse2(derive_input_stream)
        .map_err(ParseError::InvalidDeriveInput)?;

[4.391]

[4.682]

    let attribute: syn::LitStr =
        syn::parse2(attribute_stream).map_err(ParseError::InvalidAttribute)?;
    let derive_input: syn::DeriveInput =
        syn::parse2(derive_input_stream).map_err(ParseError::InvalidDeriveInput)?;

Replacement in fluent_embed_derive/src/macro_impl/mod.rs at line 171 [5.76]

∅:D[7.282] → [8.97:254]

∅:D[9.788] → [8.97:254]

∅:D[10.3378] → [8.97:254]

B:BD[11.286] → [8.97:254]

            const CANONICAL_LOCALE: ::fluent_embed::icu_locale::LanguageIdentifier =
                ::fluent_embed::icu_locale::langid!(#canonical_locale);

[7.282]

[5.1713]

            fn canonical_locale(&self) -> ::fluent_embed::icu_locale::LanguageIdentifier {
                ::fluent_embed::icu_locale::langid!(#canonical_locale)
            }

Replacement in fluent_embed_derive/src/macro_impl/derive.rs at line 87 [13.39]

B:BD[12.1776] → [2.0:89]

    quote!(vec![Self::CANONICAL_LOCALE, #(::fluent_embed::langid!(#locale_literals)),*])

[12.1776]

[12.1841]

    quote!(vec![self.canonical_locale(), #(::fluent_embed::langid!(#locale_literals)),*])

Replacement in fluent_embed_derive/src/lib.rs at line 46 [14.74]

∅:D[7.405] → [4.2462:2641]

B:BD[4.2462] → [4.2462:2641]

                            const CANONICAL_LOCALE: ::fluent_embed::icu_locale::LanguageIdentifier =
                                ::fluent_embed::icu_locale::langid!("en-US");

[7.405]

[15.574]

                            fn canonical_locale(&self) -> ::fluent_embed::icu_locale::LanguageIdentifier {
                                ::fluent_embed::icu_locale::langid!("en-US")
                            }

Replacement in fluent_embed/src/time.rs at line 7 [16.53]
B:BD[16.221] → [17.1721:1767]
```
use icu_locale::{LanguageIdentifier, langid};
```
[16.221]
[17.1767]
```
use icu_locale::LanguageIdentifier;
```
Deletion in fluent_embed/src/time.rs at line 16 [16.53]
∅:D[18.52] → [11.3849:4061]
∅:D[7.507] → [11.3849:4061]
B:BD[11.3849] → [11.3849:4061]
B:BD[11.4061] → [7.508:545]
∅:D[7.545] → [11.4115:4121]
B:BD[11.4115] → [11.4115:4121]
∅:D[11.4121] → [19.124:125]
B:BD[19.124] → [19.124:125]
```
    const CANONICAL_LOCALE: LanguageIdentifier = langid!("en-US");
    fn available_locales(&self) -> Vec<LanguageIdentifier> {
        // TODO: keep track of all locales with Fluent data, and return only those
        vec![Self::CANONICAL_LOCALE]
    }
```
Replacement in fluent_embed/src/string.rs at line 6 [20.34]
B:BD[20.170] → [17.1933:1979]
```
use icu_locale::{LanguageIdentifier, langid};
```
[20.139]
[20.215]
```
use icu_locale::LanguageIdentifier;
```

Deletion in fluent_embed/src/string.rs at line 11 [20.34]

B:BD[3.95] → [3.95:170]

∅:D[3.170] → [20.433:434]

B:BD[20.433] → [20.433:434]

B:BD[20.434] → [3.171:390]

∅:D[3.390] → [20.638:639]

B:BD[20.638] → [20.638:639]

            const CANONICAL_LOCALE: LanguageIdentifier = langid!("en-US");
            fn available_locales(&self) -> Vec<LanguageIdentifier> {
                // TODO: keep track of all locales with Fluent data, and return only those
                vec![Self::CANONICAL_LOCALE]
            }

Replacement in fluent_embed/src/lib.rs at line 18 [21.82]

∅:D[7.730] → [11.4685:4752]

B:BD[11.4685] → [11.4685:4752]

∅:D[11.4752] → [21.427:475]

B:BD[21.427] → [21.427:475]

    // TODO: this should be project-wide and tracked at build time
    const CANONICAL_LOCALE: LanguageIdentifier;

[7.730]

[21.511]

    fn message_for_locale(&self, locale: &LanguageIdentifier) -> String;
    fn canonical_locale(&self) -> LanguageIdentifier {
        langid!("en-US")
    }

Replacement in fluent_embed/src/lib.rs at line 24 [21.82]

B:BD[21.512] → [11.4753:4813]

B:BD[11.4813] → [17.2081:2154]

    fn available_locales(&self) -> Vec<LanguageIdentifier>;
    fn message_for_locale(&self, locale: &LanguageIdentifier) -> String;

[21.512]

[11.4956]

    fn available_locales(&self) -> Vec<LanguageIdentifier> {
        // TODO: keep track of all locales with Fluent data, and return only those
        vec![self.canonical_locale()]
    }

Replacement in fluent_embed/src/lib.rs at line 45 [21.82]

B:BD[17.2219] → [17.2219:2316]

            env_preferences::get_locales_lossy().unwrap_or(vec![Self::CANONICAL_LOCALE.into()]);

[17.2219]

[22.460]

            env_preferences::get_locales_lossy().unwrap_or(vec![self.canonical_locale().into()]);

Replacement in fluent_embed/src/lib.rs at line 54 [21.82]

B:BD[8.3683] → [8.3683:3742]

            Self::CANONICAL_LOCALE.to_string().as_bytes(),

[8.3683]

[8.3742]

            self.canonical_locale().to_string().as_bytes(),

Replacement in fluent_embed/src/decimal.rs at line 8 [23.2537]
B:BD[3.846] → [3.846:892]
```
use icu_locale::{LanguageIdentifier, langid};
```
[3.846]
[3.892]
```
use icu_locale::LanguageIdentifier;
```

Deletion in fluent_embed/src/decimal.rs at line 13 [23.2537]

B:BD[3.991] → [3.991:1286]

∅:D[3.1286] → [23.2824:2825]

∅:D[8.4237] → [23.2824:2825]

B:BD[23.2824] → [23.2824:2825]

            const CANONICAL_LOCALE: LanguageIdentifier = langid!("en-US");
            fn available_locales(&self) -> Vec<LanguageIdentifier> {
                // TODO: keep track of all locales with Fluent data, and return only those
                vec![Self::CANONICAL_LOCALE]
            }

Deletion in fluent_embed/src/decimal.rs at line 24 [23.2537]

B:BD[3.1614] → [3.1614:1689]

∅:D[3.1689] → [23.3830:3831]

B:BD[23.3830] → [23.3830:3831]

B:BD[23.3831] → [3.1690:1909]

∅:D[3.1909] → [23.4035:4036]

B:BD[23.4035] → [23.4035:4036]

            const CANONICAL_LOCALE: LanguageIdentifier = langid!("en-US");
            fn available_locales(&self) -> Vec<LanguageIdentifier> {
                // TODO: keep track of all locales with Fluent data, and return only those
                vec![Self::CANONICAL_LOCALE]
            }

Deletion in fluent_embed/src/decimal.rs at line 50 [23.2537]

∅:D[7.1016] → [23.4348:4560]

∅:D[8.4988] → [23.4348:4560]

B:BD[23.4348] → [23.4348:4560]

B:BD[23.4560] → [7.1017:1054]

∅:D[7.1054] → [23.4614:4621]

B:BD[23.4614] → [23.4614:4621]

    const CANONICAL_LOCALE: LanguageIdentifier = langid!("en-US");
    fn available_locales(&self) -> Vec<LanguageIdentifier> {
        // TODO: keep track of all locales with Fluent data, and return only those
        vec![Self::CANONICAL_LOCALE]
    }