Finchie/l10n_embed - Change U2PHMYPDFQQYTPDVVJLWDJM5G45ILXLWDDDTZVV2NBOSCED323MQC

Return `String` directly instead of writing to buffer in `Localize::localize`

This makes the API significantly easier to use, especially since everything was just creating the same buffer anyways. If the user wants to use std::io::Write, they can still do so, by using the lower-level Localize::message_for_locale

Created by finchie on June 4, 2025

U2PHMYPDFQQYTPDVVJLWDJM5G45ILXLWDDDTZVV2NBOSCED323MQC

Dependencies

In channels

main

Change contents

Replacement in fluent_embed_interaction/src/prompt/select.rs at line 20 [4.109]

B:BD[4.685] → [4.685:1013]

            .map(|item| {
                let mut buffer = Vec::new();
                item.localize(&mut buffer).map(|_| buffer)
            })
            .collect::<Result<Vec<Vec<u8>>, LocalizationError>>()?
            .into_iter()
            .map(|item| String::from_utf8(item).map_err(LocalizationError::InvalidOutput))

[4.685]

[4.1013]

            .map(Localize::localize)

Replacement in fluent_embed_interaction/src/prompt/password.rs at line 27 [4.2012]

B:BD[4.2753] → [4.2753:2895]

        let mut buffer = Vec::new();
        confirmation.localize(&mut buffer)?;
        let confirmation_text = String::from_utf8(buffer)?;

[4.2753]

[4.2895]

        let confirmation_text = confirmation.localize()?;
        let mismatch_error_text = mismatch_error.localize()?;

Deletion in fluent_embed_interaction/src/prompt/password.rs at line 30 [4.2012]

B:BD[4.2896] → [4.2896:3043]

        let mut buffer = Vec::new();
        mismatch_error.localize(&mut buffer)?;
        let mismatch_error_text = String::from_utf8(buffer)?;

Replacement in fluent_embed_interaction/src/prompt/macros.rs at line 29 [4.4406]

B:BD[4.5087] → [4.5087:5244]

                let mut buffer = Vec::new();
                prompt.localize(&mut buffer)?;
                let localized_text = String::from_utf8(buffer)?;

[4.5087]

[4.5244]

                let localized_text = prompt.localize()?;

Replacement in fluent_embed_interaction/src/prompt/macros.rs at line 50 [4.4406]

B:BD[4.5892] → [4.5892:6188]

                            let mut buffer = Vec::new();
                            message
                                .localize(&mut buffer)
                                .map_err(|error| error.to_string())?;
                            Err(String::from_utf8_lossy(&buffer).to_string())

[4.5892]

[4.6188]

                            Err(message.localize().unwrap())

Replacement in fluent_embed_interaction/src/prompt/input.rs at line 18 [4.6488]

B:BD[4.7037] → [4.7037:7171]

        let mut buffer = Vec::new();
        default.localize(&mut buffer)?;
        let localized_text = String::from_utf8(buffer)?;

[4.7037]

[4.7171]

        let localized_text = default.localize()?;

Replacement in fluent_embed_interaction/src/progress.rs at line 26 [3.513]

B:BD[3.1327] → [3.1327:1461]

        let mut buffer = Vec::new();
        message.localize(&mut buffer)?;
        let localized_text = String::from_utf8(buffer)?;

[3.1327]

[3.1461]

        let localized_text = message.localize()?;

Replacement in fluent_embed/src/lib.rs at line 52 [6.82]

B:BD[5.3447] → [2.778:871]

    fn localize<W: std::io::Write>(&self, writer: &mut W) -> Result<(), LocalizationError> {

[5.3447]

[7.321]

    fn localize(&self) -> Result<String, LocalizationError> {

Insertion in fluent_embed/src/lib.rs at line 73 [6.82]
[8.5246]
[5.3772]
```
        let mut buffer = Vec::new();
```
Replacement in fluent_embed/src/lib.rs at line 76 [6.82]
B:BD[5.3805] → [5.3805:3825]
```
            writer,
```
[5.3805]
[5.3825]
```
            &mut buffer,
```

Replacement in fluent_embed/src/lib.rs at line 78 [6.82]

B:BD[5.3914] → [5.3914:3924]

[5.3914]

[8.5304]

        )?;
        let localized_text = String::from_utf8(buffer)?;
        Ok(localized_text)