{"header":{"message":"fix(vm): allow immutable access to symbol table","description":null,"timestamp":"2024-02-29T14:42:10.114906159Z","authors":[{}]},"hash":"7ZAXEGS7NVSQIZXZKNPNXEDXW44VNZMMRVPZ4LTFCQS4W6HXG4UQC","authors":[{"login":"Jengamon","key":"47a75hR6eVaawZfVGBs2CqZUKZbcNz5Ago5CubrCkWvZ"}],"deps":{"hashes":[["7ZAXEGS7NVSQIZXZKNPNXEDXW44VNZMMRVPZ4LTFCQS4W6HXG4UQC","fix(vm): allow immutable access to symbol table"],["AA",null],["2E3D3TGY4B4L6VKJ6WKDHPS4BD5JNJM2I56RHHYZNVABUTGQUTPQC","feat(vm): provide view of internals for debugging"],["5V5RUGDG6RCDZU5ZJSBOMUDMPSUD7HQ5DXUQQPEPSGICQEGM6XOAC","feat(vm): sketch out how to use VM data outside of a VM instance"],["ERRF37DMR4GWXAHSLA5U4PKLK3AL3PGD4GP6YPEK3SHLN3AFY7MAC","feat(vm): create rudimentary symbol table"],["CZI7ZLGRQBWWOHFJRBMHUJ3QZH3S6XB6HFHBRD6YWWEXLMBH4PGAC","feat: add #![warn(missing_docs)] on the way to deny and eventually forbid"],["Y26CTXMO7XJMHSZNRBCVQAPFAJZ2LOO47WI2V2LCZU6SG52VOP7QC","feat(vm): start vm work"],["ABFTXJS57ESOF4DIRYCYDJ3DLYCU5T7UIWB7HAUUXVQZ3LANAVMQC","feat(vm): start sketching out value impl"]],"deps":["2E3D3TGY4B4L6VKJ6WKDHPS4BD5JNJM2I56RHHYZNVABUTGQUTPQC"],"known":["ERRF37DMR4GWXAHSLA5U4PKLK3AL3PGD4GP6YPEK3SHLN3AFY7MAC","CZI7ZLGRQBWWOHFJRBMHUJ3QZH3S6XB6HFHBRD6YWWEXLMBH4PGAC","Y26CTXMO7XJMHSZNRBCVQAPFAJZ2LOO47WI2V2LCZU6SG52VOP7QC","5V5RUGDG6RCDZU5ZJSBOMUDMPSUD7HQ5DXUQQPEPSGICQEGM6XOAC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":4,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":11},"to":{"change":2,"start":11,"end":30},"introduced_by":2}],"inode":{"change":3,"pos":30}}},"contents":[{"Del":" cell::RefCell,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":31,"ins":{"up_context":[{"change":3,"pos":652}],"down_context":[{"change":2,"pos":87}],"flag":"BLOCK","start":0,"end":90,"inode":{"change":3,"pos":30}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":652},"to":{"change":3,"start":652,"end":754},"introduced_by":3}],"inode":{"change":3,"pos":30}},"ins_contents":[{"Add":" /// Symbol table for all bytecode labels in this block"},{"Add":" symbol_table: SymbolTable,"}],"del_contents":[{"Del":" /// Symbol table for all bytecode functions in this block\n symbol_table: RefCell,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":38,"ins":{"up_context":[{"change":3,"pos":770}],"down_context":[{"change":3,"pos":939}],"flag":"BLOCK","start":91,"end":685,"inode":{"change":3,"pos":30}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":770},"to":{"change":3,"start":770,"end":939},"introduced_by":3}],"inode":{"change":3,"pos":30}},"ins_contents":[{"Add":" /// Get the block offset of a specific label"},{"Add":" pub fn get_offset>(&self, label: S) -> Option {"},{"Add":" self.symbol_table"},{"Add":" .id(label)"},{"Add":" .and_then(|sym| self.labels.get(&sym).copied())"},{"Add":" }"},{"Add":""},{"Add":" /// The symbol table of block labels"},{"Add":" pub fn symbols(&self) -> &SymbolTable {"},{"Add":" &self.symbol_table"},{"Add":" }"},{"Add":""},{"Add":" /// Breakpoint access"},{"Add":" pub fn breakpoints(&self) -> &HashSet {"},{"Add":" &self.breakpoints"},{"Add":" }"},{"Add":""},{"Add":" /// Mutable breakpoint access"},{"Add":" pub fn breakpoints_mut(&mut self) -> &mut HashSet {"},{"Add":" &mut self.breakpoints"}],"del_contents":[{"Del":" fn get_offset>(&self, name: S) -> Option {\n self.labels\n .get(&self.symbol_table.borrow_mut().id(name))\n .copied()\n"}]}},{"Replacement":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":86,"ins":{"up_context":[{"change":3,"pos":1289}],"down_context":[{"change":3,"pos":1350}],"flag":"BLOCK","start":686,"end":736,"inode":{"change":3,"pos":30}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1289},"to":{"change":3,"start":1289,"end":1350},"introduced_by":3}],"inode":{"change":3,"pos":30}},"ins_contents":[{"Add":" /// Create a new VM starting at instruction 0"}],"del_contents":[{"Del":" /// Create a new VM using code compiled into a [`Block`]\n"}]}},{"Edit":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":88,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1389}],"down_context":[{"change":3,"pos":1389}],"flag":"BLOCK","start":737,"end":894,"inode":{"change":3,"pos":30}}},"contents":[{"Add":" Self::with_start(block, 0)"},{"Add":" }"},{"Add":""},{"Add":" /// Create a new VM starting at a certain location"},{"Add":" pub fn with_start(block: Block, start: usize) -> Self {"}]}},{"Replacement":{"inode":{"change":3,"pos":30},"path":"magus_core/src/vm.rs","line":97,"ins":{"up_context":[{"change":3,"pos":1531}],"down_context":[{"change":3,"pos":1687}],"flag":"BLOCK","start":895,"end":928,"inode":{"change":3,"pos":30}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1531},"to":{"change":3,"start":1531,"end":1687},"introduced_by":3}],"inode":{"change":3,"pos":30}},"ins_contents":[{"Add":" inst_ptr: start,"}],"del_contents":[{"Del":" // Get the offset to a label \"_start\", or start at the first instruction\n inst_ptr: block.get_offset(\"_start\").unwrap_or(0),\n"}]}},{"Replacement":{"inode":{"change":8,"pos":385},"path":"magus_core/src/value.rs","line":161,"ins":{"up_context":[{"change":3,"pos":1201}],"down_context":[{"change":3,"pos":1404}],"flag":"BLOCK","start":929,"end":1354,"inode":{"change":8,"pos":385}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1201},"to":{"change":3,"start":1201,"end":1404},"introduced_by":3}],"inode":{"change":8,"pos":385}},"ins_contents":[{"Add":" pub fn id>(&self, source: S) -> Option {"},{"Add":" self.1"},{"Add":" .iter()"},{"Add":" .position(|s| s.as_ref() == source.as_ref())"},{"Add":" .map(|pos| SymbolId(self.0, pos))"},{"Add":" }"},{"Add":""},{"Add":" /// If a valid symbol, get the id, otherwise, create a new id referencing the symbol"},{"Add":" pub fn id_mut>(&mut self, source: S) -> SymbolId {"},{"Add":" self.id(source.as_ref()).unwrap_or_else(|| {"}],"del_contents":[{"Del":" pub fn id>(&mut self, source: S) -> SymbolId {\n if let Some(pos) = self.1.iter().position(|s| s.as_ref() == source.as_ref()) {\n SymbolId(self.0, pos)\n } else {\n"}]}},{"Replacement":{"inode":{"change":8,"pos":385},"path":"magus_core/src/value.rs","line":174,"ins":{"up_context":[{"change":3,"pos":1531}],"down_context":[{"change":3,"pos":1541}],"flag":"BLOCK","start":1355,"end":1366,"inode":{"change":8,"pos":385}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1531},"to":{"change":3,"start":1531,"end":1541},"introduced_by":3}],"inode":{"change":8,"pos":385}},"ins_contents":[{"Add":" })"}],"del_contents":[{"Del":" }\n"}]}}],"owner":"Jengamon","repo":"magus","token":"+5W/qX0eLyfd9qQBmzdHx15aE1hd98Z/CRbAUtS0mqM=","login":null}

…

Dependencies

Change contents