Robin_Jadoul/testing - Change G3FNNIIUCVMPJUICDYPXVS6BP6225LIQZOV5MRNEGCBC5QY3N6NAC

Limiting the amount of messages that can be buffered while rekeying to two channel windows

This is mostly a security feature against malicious implementations that could try to saturate a server's (or a client's memory) by never responding to key re-exchange requests

Created by pmeunier on July 6, 2021

G3FNNIIUCVMPJUICDYPXVS6BP6225LIQZOV5MRNEGCBC5QY3N6NAC

Dependencies

In channels

main

Change contents

Insertion in thrussh/src/server/session.rs at line 14 [3.188192]
[2.46]
[3.188593]
```
    pub(crate) pending_len: u32,
```
Insertion in thrussh/src/server/mod.rs at line 478 [3.203388]
[2.82]
[3.218750]
```
        pending_len: 0,
```
Insertion in thrussh/src/server/encrypted.rs at line 94 [3.230083]
[2.349]
[3.233171]
```
                self.pending_len = 0;
```

Insertion in thrussh/src/server/encrypted.rs at line 101 [3.230083]

[2.440]

                self.pending_len += buf.len() as u32;
                if self.pending_len > 2 * self.target_window_size {
                    return Err(Error::Pending.into())
                }

Insertion in thrussh/src/lib.rs at line 409 [3.278640]
[4.13108]
[4.13108]
```
    #[error("Pending buffer limit reached")]
    Pending,
```
Insertion in thrussh/src/client/mod.rs at line 53 [3.334998]
[2.1060]
[3.336548]
```
    pending_len: u32,
```
Insertion in thrussh/src/client/mod.rs at line 813 [3.334998]
[2.1096]
[3.358127]
```
        pending_len: 0,
```
Insertion in thrussh/src/client/encrypted.rs at line 108 [3.383877]
[2.1382]
[3.388084]
```
                    self.pending_len = 0;
```

Insertion in thrussh/src/client/encrypted.rs at line 115 [3.383877]

[2.1536]

                    self.pending_len += buf.len() as u32;
                    if self.pending_len > 2 * self.target_window_size {
                        return Err(Error::Pending.into())
                    }

Replacement in thrussh/Cargo.toml at line 5 [3.426118]
B:BD[3.426214] → [2.1817:1836]
```
version = "0.33.3"
```
[3.426214]
[3.426233]
```
version = "0.33.5"
```

Limiting the amount of messages that can be buffered while rekeying to two channel windows

Dependencies

In channels

Change contents

Insertion in thrussh/src/server/session.rs at line 14 [3.188192]

Insertion in thrussh/src/server/mod.rs at line 478 [3.203388]

Insertion in thrussh/src/server/encrypted.rs at line 94 [3.230083]

Insertion in thrussh/src/server/encrypted.rs at line 101 [3.230083]

Insertion in thrussh/src/lib.rs at line 409 [3.278640]

Insertion in thrussh/src/client/mod.rs at line 53 [3.334998]

Insertion in thrussh/src/client/mod.rs at line 813 [3.334998]

Insertion in thrussh/src/client/encrypted.rs at line 108 [3.383877]

Insertion in thrussh/src/client/encrypted.rs at line 115 [3.383877]

Replacement in thrussh/Cargo.toml at line 5 [3.426118]