akkartik/broadsheet.love - Change IFTYOERMW7P3I24WISZN35X3GWJ5MSMRYDRBK3L52GCZTPP3CWZQC

line.y -> line_cache.starty in a few more places

Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary.

Created by Kartik K. Agaram on July 27, 2022

IFTYOERMW7P3I24WISZN35X3GWJ5MSMRYDRBK3L52GCZTPP3CWZQC

Dependencies

In channels

main

Change contents

Replacement in undo.lua at line 70 [4.1]

B:BD[4.1978] → [4.1978:2236]

      table.insert(event.lines, {mode='drawing', y=line.y, h=line.h, points=points, shapes=shapes, pending={}})
--?       table.insert(event.lines, {mode='drawing', y=line.y, h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})

[4.1978]

[4.2236]

      table.insert(event.lines, {mode='drawing', h=line.h, points=points, shapes=shapes, pending={}})
--?       table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})

Replacement in text_tests.lua at line 834 [7.2]

B:BD[5.19386] → [6.1150:1232]

  edit.draw(Editor_state)  -- populate line.y for each line in Editor_state.lines

[5.19386]

[3.5639]

  edit.draw(Editor_state)  -- populate line_cache.starty for each line Editor_state.line_cache

Replacement in text_tests.lua at line 852 [7.2]

B:BD[5.20197] → [6.1233:1315]

  edit.draw(Editor_state)  -- populate line.y for each line in Editor_state.lines

[5.20197]

[8.2]

  edit.draw(Editor_state)  -- populate line_cache.starty for each line Editor_state.line_cache

Replacement in text_tests.lua at line 873 [7.2]

B:BD[5.21125] → [6.1316:1398]

  edit.draw(Editor_state)  -- populate line.y for each line in Editor_state.lines

[5.21125]

[9.581]

  edit.draw(Editor_state)  -- populate line_cache.starty for each line Editor_state.line_cache

Replacement in text_tests.lua at line 899 [7.2]

B:BD[5.22267] → [6.1399:1481]

  edit.draw(Editor_state)  -- populate line.y for each line in Editor_state.lines

[5.22267]

[10.446]

  edit.draw(Editor_state)  -- populate line_cache.starty for each line Editor_state.line_cache

Replacement in edit.lua at line 289 [11.413]

B:BD[6.6311] → [6.6311:6394]

  for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[6.6311]

[6.6394]

  for _,line_cache in ipairs(State.line_cache) do line_cache.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 353 [11.413]

B:BD[11.12265] → [6.7858:7943]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.12265]

[2.2587]

    for _,line in ipairs(State.lines) do line.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 369 [11.413]

B:BD[11.12746] → [6.8140:8225]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.12746]

[2.2624]

    for _,line_cache in ipairs(State.line_cache) do line_cache.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 385 [11.413]

B:BD[11.13241] → [6.8422:8507]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.13241]

[12.3829]

    for _,line_cache in ipairs(State.line_cache) do line_cache.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 391 [11.413]

B:BD[11.13432] → [6.8508:8593]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.13432]

[3.22975]

    for _,line_cache in ipairs(State.line_cache) do line_cache.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 398 [11.413]

B:BD[11.13689] → [6.8683:8768]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.13689]

[11.13768]

    for _,line in ipairs(State.lines) do line.starty = nil end  -- just in case we scroll

Replacement in edit.lua at line 419 [11.413]
B:BD[11.14561] → [11.14561:14592]
```
    -- DON'T reset line.y here
```
[11.14561]
[13.15]
```
    -- DON'T reset line_cache.starty here
```

Replacement in edit.lua at line 454 [11.413]

B:BD[11.15878] → [6.9507:9592]

    for _,line in ipairs(State.lines) do line.y = nil end  -- just in case we scroll

[11.15878]

[14.7099]

    for _,line_cache in ipairs(State.line_cache) do line_cache.starty = nil end  -- just in case we scroll