akkartik/crosstable.love - Change 5ZCQGZP5VK6RIXOFQ7L4OGXFRRBPWWJNQYTWVUKJRCO7UTBPA3IAC

save 2 more alternate formats for test failures

Created by Kartik K. Agaram on January 22, 2023

5ZCQGZP5VK6RIXOFQ7L4OGXFRRBPWWJNQYTWVUKJRCO7UTBPA3IAC

Dependencies

In channels

main

Change contents

Replacement in app.lua at line 436 [4.2]

B:BD[3.47] → [2.18:100]

    xpcall(_G[name], function(err) add_debug_info_to_test_failure(name, err) end)

[3.47]

[5.7548]

    xpcall(_G[name], function(err) record_error_with_heuristic_location(name, err) end)

Replacement in app.lua at line 445 [4.2]

B:BD[6.143] → [2.101:175]

  xpcall(test, function(err) add_debug_info_to_test_failure('', err) end)

[6.143]

[7.2065]

  xpcall(test, function(err) record_error_with_heuristic_location('', err) end)

Replacement in app.lua at line 449 [4.2]

B:BD[5.7569] → [2.176:268]

-- add test_name and file/line/test
function add_debug_info_to_test_failure(test_name, err)

[5.7569]

[8.60839]

-- Test_errors will be an array
function record_error(test_name, err)
  local err_without_line_number = err:gsub('^[^:]*:[^:]*: ', '')
  table.insert(Test_errors, test_name..' -- '..err_without_line_number)
end
-- Test_errors will be an array
-- add test_name and guess at file/line
function record_error_with_heuristic_location(test_name, err)

Insertion in app.lua at line 463 [4.2]

[8.61188]

end
-- Test_errors will be a table by test name
function record_error_with_stack_trace(test_name, err)
  local err_without_line_number = err:gsub('^[^:]*:[^:]*: ', '')
  Test_errors[test_name] = debug.traceback(err_without_line_number)