akkartik/pensieve.love - Change KVJTEXMSVG43EWSARA5O52EV2D4QTQZGO5RNSPVBHYZSWUMNI25QC

fix all tests in LÖVE v12

This is all quite hacky. Many of my tests are unfortunately brittle to changes in text rendering. Fortunately there's only one test that currently requires a hacky special case (and a second test I tweaked slightly to be more robust).

I can't think of a better approach. It doesn't help to standardize the font, because version changes still come with changes to text-shaping algorithms even if the font itself is unchanged. I could base all my assertions on the widths of individual characters, but that would make the tests much less readable and not express intent as clearly. So here we are, with hopefully just a few hacky special cases (there might be a few more as LÖVE v12 advances towards publication, and in further versions).

Created by Kartik K. Agaram on October 9, 2023

KVJTEXMSVG43EWSARA5O52EV2D4QTQZGO5RNSPVBHYZSWUMNI25QC

Dependencies

In channels

main

Change contents

Replacement in text_tests.lua at line 1119 [5.2]

B:BD[4.26911] → [2.2:42]

  App.screen.check(y, 'mn', 'screen:3')

[4.26911]

[5.10090]

  if Version == '12.0' then
    -- HACK: Maybe v12.0 uses a different font? Strange that it only causes
    -- issues in a couple of places.
    -- We'll need to rethink our tests if issues like this start to multiply.
    App.screen.check(y, 'mno ', 'screen:3')
  else
    App.screen.check(y, 'mn', 'screen:3')
  end

Replacement in text_tests.lua at line 1836 [5.2]

B:BD[5.33004] → [6.12469:12584]

  edit.run_after_mouse_release(Editor_state, Editor_state.left+8,Editor_state.top+Editor_state.line_height*2+5, 1)

[5.33004]

[5.33130]

  edit.run_after_mouse_release(Editor_state, Editor_state.left+2,Editor_state.top+Editor_state.line_height*2+5, 1)

Replacement in text_tests.lua at line 1839 [5.2]

B:BD[7.18567] → [7.18567:18622]

  check_eq(Editor_state.cursor1.pos, 26, 'cursor:pos')

[7.18567]

[5.33305]

  check_eq(Editor_state.cursor1.pos, 25, 'cursor:pos')

Replacement in source_text_tests.lua at line 1089 [8.3498]

B:BD[8.35876] → [3.6:46]

  App.screen.check(y, 'mn', 'screen:3')

[8.35876]

[8.35980]

  if Version == '12.0' then
    -- HACK: Maybe v12.0 uses a different font? Strange that it only causes
    -- issues in a couple of places.
    -- We'll need to rethink our tests if issues like this start to multiply.
    App.screen.check(y, 'mno ', 'screen:3')
  else
    App.screen.check(y, 'mn', 'screen:3')
  end

Replacement in source_text_tests.lua at line 1806 [8.3498]

B:BD[8.73266] → [9.13209:13324]

  edit.run_after_mouse_release(Editor_state, Editor_state.left+8,Editor_state.top+Editor_state.line_height*2+5, 1)

[8.73266]

[8.73379]

  edit.run_after_mouse_release(Editor_state, Editor_state.left+2,Editor_state.top+Editor_state.line_height*2+5, 1)

Replacement in source_text_tests.lua at line 1809 [8.3498]

B:BD[7.41413] → [7.41413:41468]

  check_eq(Editor_state.cursor1.pos, 26, 'cursor:pos')

[7.41413]

[8.73630]

  check_eq(Editor_state.cursor1.pos, 25, 'cursor:pos')