akkartik/driver.love - Change N2JXCLNTZMW4KD2BGALD326JEQCVQ2AAD4JWBWEG5GQLERPKQRPQC

bugfix: don't retry after the SDL hard crash

This is a follow-up to the following changes:

NPXISSWQSW45YFZPNLVVRU4MKWXLEINO4LDGAZFL7BVY25BSNNXAC
VUJJNWJDHQFAQO4QGV7YOXG3K7M66P7SIYNA22R36LIBDKFMKPIQC

Scenario:

run on a machine with low video RAM
spread out an app's code over a large area but smaller than the 16000x16000 check in snapshot_canvas
press ctrl+g to trigger the animation
the call to newCanvas raises an SDL error due to insufficient video RAM to cover the whole surface
app goes into error event loop (error_run_frame in live.lua)
press a key
—> before this commit, app goes back to main event loop <—
close the window
app writes settings to config in the save directory before quitting
settings include a really large viewport
app fails to recover

This particular error is serious enough we don't want to just randomly see if things got better. We don't want to leave the error loop unless there's a code change and any affirmative reason to believe things might have improved.

Note: I'm seeing some reports that the above scenario might be easier to trigger on Windows. The key release of ctrl+g might itself be taking the app out of the error event loop. This fix should improve matters on any OS.

Created by akkartik on April 17, 2025

N2JXCLNTZMW4KD2BGALD326JEQCVQ2AAD4JWBWEG5GQLERPKQRPQC

Dependencies

In channels

main

Change contents

Insertion in reference.md at line 26 [4.17]

[3.143]


## Variables you can set/read
* `Disallow_error_recovery_on_key_release` -- currently needed to handle one
  specific hard-to-recover-from error in `snapshot_canvas`. Subject to
  removal, but I'll document it here as long as I support it. Please
  [let me know](http://akkartik.name/contact) if you find a new need to read
  or write it.

Replacement in live.lua at line 403 [7.722]

B:BD[5.659] → [6.392:447]

∅:D[6.447] → [5.659:737]

B:BD[5.659] → [5.659:737]

        print('=== trying to restore main event loop')
        error_frame_keys_down[a] = nil
        App.run_frame = main_run_frame

[5.659]

[5.737]

        if not Disallow_error_recovery_on_key_release then
          print('=== trying to restore main event loop')
          error_frame_keys_down[a] = nil
          App.run_frame = main_run_frame
        end

Insertion in 0086-snapshot_canvas at line 16 [9.14387]
[8.754]
[2.336]
```
	Disallow_error_recovery_on_key_release = true
```
Insertion in 0086-snapshot_canvas at line 24 [9.14387]
[9.14941]
[9.14941]
```
	Disallow_error_recovery_on_key_release = nil
```