akkartik/pensieve.love - Change EMHRPJ3RAVIVJEQIRXIVDGENV6QHUUGXXRWTJ3BXC7SZNC66VK5QC

no, that's not right

Bugfix: we want selections to persist even when we lift up the shift key.

This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them.

Current cross-cutting concerns we're explicitly scattering code for.

autosave
undo
selection management

Created by Kartik K. Agaram on June 20, 2022

EMHRPJ3RAVIVJEQIRXIVDGENV6QHUUGXXRWTJ3BXC7SZNC66VK5QC

Dependencies

In channels

main

Change contents

Insertion in text_tests.lua at line 187 [5.2]

[3.1122]

[4.2]

end
function test_select_text()
  io.write('\ntest_select_text')
  -- display a line of text
  App.screen.init{width=80, height=80}
  Lines = load_array{'abc def'}
  Line_width = 75
  Cursor1 = {line=1, pos=1}
  Screen_top1 = {line=1, pos=1}
  Screen_bottom1 = {}
  App.draw()
  -- select a letter
  App.fake_key_press('lshift')
  App.run_after_keychord('S-right')
  App.fake_key_release('lshift')
  App.keyreleased('lshift')
  -- selection persists even after shift is released
  check_eq(Selection1.line, 1, 'F - test_select_text/selection:line')
  check_eq(Selection1.pos, 1, 'F - test_select_text/selection:pos')
  check_eq(Cursor1.line, 1, 'F - test_select_text/cursor:line')
  check_eq(Cursor1.pos, 2, 'F - test_select_text/cursor:pos')

Insertion in text.lua at line 178 [8.1]
[6.1504]
[7.134]
```
    Selection1 = {}
```
Insertion in text.lua at line 190 [8.1]
[6.1617]
[9.2046]
```
    Selection1 = {}
```
Insertion in text.lua at line 195 [8.1]
[10.67]
[11.8453]
```
      Selection1 = {}
```
Insertion in text.lua at line 234 [8.1]
[6.1843]
[9.3034]
```
    Selection1 = {}
```
Insertion in text.lua at line 239 [8.1]
[10.111]
[11.8533]
```
      Selection1 = {}
```
Insertion in text.lua at line 272 [8.1]
[6.2102]
[12.209]
```
    Selection1 = {}
```

Insertion in main.lua at line 410 [14.2]

[10.649]

[13.3116]

  if not App.shift_down() then
    Selection1 = {}
  end

Insertion in main.lua at line 444 [14.2]
[15.3819]
[16.4279]
```
    Selection1 = {}
```
Insertion in main.lua at line 448 [14.2]
[16.4470]
[16.4470]
```
    Selection1 = {}
```
Insertion in main.lua at line 452 [14.2]
[16.4615]
[16.4661]
```
    Selection1 = {}
```
Insertion in main.lua at line 456 [14.2]
[16.4795]
[17.71]
```
    Selection1 = {}
```
Insertion in main.lua at line 469 [14.2]
[17.359]
[17.359]
```
    Selection1 = {}
```
Insertion in main.lua at line 482 [14.2]
[18.46]
[18.46]
```
    Selection1 = {}
```
Insertion in main.lua at line 490 [14.2]
[18.173]
[18.173]
```
    Selection1 = {}
```
Insertion in main.lua at line 498 [14.2]
[10.716]
[18.289]
```
    Selection1 = {}
```
Insertion in main.lua at line 520 [14.2]
[18.1959]
[18.1959]
```
    Selection1 = {}
```
Deletion in main.lua at line 568 [14.2]
B:BD[19.1591] → [2.710:767]
```
  if not App.shift_down() then
    Selection1 = {}
  end
```

no, that's not right

Dependencies

In channels

Change contents

Insertion in text_tests.lua at line 187 [5.2]

Insertion in text.lua at line 178 [8.1]

Insertion in text.lua at line 190 [8.1]

Insertion in text.lua at line 195 [8.1]

Insertion in text.lua at line 234 [8.1]

Insertion in text.lua at line 239 [8.1]

Insertion in text.lua at line 272 [8.1]

Insertion in main.lua at line 410 [14.2]

Insertion in main.lua at line 444 [14.2]

Insertion in main.lua at line 448 [14.2]

Insertion in main.lua at line 452 [14.2]

Insertion in main.lua at line 456 [14.2]

Insertion in main.lua at line 469 [14.2]

Insertion in main.lua at line 482 [14.2]

Insertion in main.lua at line 490 [14.2]

Insertion in main.lua at line 498 [14.2]

Insertion in main.lua at line 520 [14.2]

Deletion in main.lua at line 568 [14.2]