drop final mention of state global beyond main.lua

[?]

Jul 13, 2022, 5:05 AM

P5QNVXSNGPUYFDBHK6KJMFDVG6U6S5Q3KRQICGK7AZ7FKZE7OJJQC

Dependencies

[2] KTZQ57HV replace globals with args in a few functions
[3] LUNH47XX make text and drawings the same width
[4] BLWAYPKV extract a module
[5] 7DPPMI2U another integer coordinate
[6] DLQAEAC7 add state arg to Drawing.mouse_pressed
[7] HYEAFRZ2 split mouse_pressed events between Text and Drawing
[8] QXVD2RIF add state arg to Drawing.mouse_released
[9] UHB4GARJ left/right margin -> left/right coordinates
[10] SRVDX4I5 local var
[11] LAW2O3NW extract variable Margin_left
[12] C45WCXJ2 keep drawings within the line width slider as well
[13] 5DOTWNVM right margin
[14] 65HNIAOS make freehand drawings smoother
[15] VHQCNMAR several more modules
[16] RT6EV6OP delegate update events to drawings
[17] DRFE3B3Z mouse buttons are integers, not strings
[18] M6TH7VSZ rip out notion of Line_width
[19] 253TWKDA clean up
[20] 23MA4T3G add state arg to Drawing.keychord_pressed
[21] PJEQCTBL add state arg to Drawing.update
[22] P4376EXK add state arg to few functions
[23] XNFTJHC4 split keyboard handling between Text and Drawing
[24] NYQ7HD4D move
[25] XRLJDW3W casting about for more helpers to extract..
[26] OWK3U6VD tests for drawing polygons
[27] DLQMM265 scroll past first page
[28] WPW3AVFS more precise shape selection
[29] JFFUF5AL override mouse state lookups in tests
[30] 7JH2ZT3F add state arg to Drawing.draw
[31] R3JZDBI2 drop heavyweight near check on file load/store
[32] 3RGHOJ25 DRY some code
[33] YCDYGEZU include drawing index in a few places
[34] LF7BWEG4 group all editor globals
[35] PTT4K4EU use the provided args everywhere
[36] 3HVBAZPA add state arg to a few functions
[37] WTDKUACN rectangle and square shapes
[38] 6DE7RBZ6 move mouse_released events to Drawing

Change contents

replacement in drawing.lua at line 29

[3.817]→[3.36956:37029](∅→∅)

local mx,my = Drawing.coord(pmx-State.left), Drawing.coord(pmy-line.y)

[3.817]

[3.894]

local mx,my = Drawing.coord(pmx-State.left, State.width), Drawing.coord(pmy-line.y, State.width)
replacement in drawing.lua at line 123

[3.1944]→[3.1644:1730](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[3.1944]

[3.2082]

local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)
replacement in drawing.lua at line 130

[3.2327]→[3.1731:1817](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[3.2327]

[3.2465]

local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)
replacement in drawing.lua at line 159

[3.2201]→[3.2201:2267](∅→∅)

local mx,my = Drawing.coord(pmx-left), Drawing.coord(pmy-top)

[3.2201]

[3.2267]

local mx,my = Drawing.coord(pmx-left, width), Drawing.coord(pmy-top, width)
replacement in drawing.lua at line 173

[3.3281]→[3.3281:3347](∅→∅)

local mx,my = Drawing.coord(pmx-left), Drawing.coord(pmy-top)

[3.3281]

[3.3347]

local mx,my = Drawing.coord(pmx-left, width), Drawing.coord(pmy-top, width)
replacement in drawing.lua at line 181

[3.3457]→[3.2027:2113](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[3.3457]

[3.3555]

local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)
replacement in drawing.lua at line 189

[3.3892]→[3.2202:2288](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[3.3892]

[3.3990]

local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)
edit in drawing.lua at line 206

[3.646]→[3.4359:4360](∅→∅)
replacement in drawing.lua at line 214

[3.191]→[3.37550:37678](∅→∅)

drawing.pending = {mode=State.current_drawing_mode, points={{x=Drawing.coord(x-State.left), y=Drawing.coord(y-drawing.y)}}}

[3.191]

[3.326]

drawing.pending = {mode=State.current_drawing_mode, points={{x=Drawing.coord(x-State.left, State.width), y=Drawing.coord(y-drawing.y, State.width)}}}
replacement in drawing.lua at line 216

[3.422]→[2.5568:5697](∅→∅)

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[3.422]

[3.537]

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)
replacement in drawing.lua at line 219

[3.740]→[2.5698:5827](∅→∅)

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[3.740]

[3.855]

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)
replacement in drawing.lua at line 222

[3.978]→[2.5828:5957](∅→∅)

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[3.978]

[3.1093]

local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)
replacement in drawing.lua at line 243

[3.433]→[3.38006:38138](∅→∅)

table.insert(drawing.pending.points, {x=Drawing.coord(App.mouse_x()-State.left), y=Drawing.coord(App.mouse_y()-drawing.y)})

[3.433]

[3.565]

table.insert(drawing.pending.points, {x=Drawing.coord(App.mouse_x()-State.left, State.width), y=Drawing.coord(App.mouse_y()-drawing.y, State.width)})
replacement in drawing.lua at line 245

[3.614]→[3.38139:38217](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.614]

[3.684]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 253

[2.6098]→[3.38218:38294](∅→∅),[3.881]→[3.38218:38294](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.6098]

[3.949]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 299

[3.227]→[3.38295:38373](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.227]

[3.297]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 306

[3.627]→[3.38374:38452](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.627]

[3.697]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 318

[3.1231]→[3.38544:38622](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.1231]

[3.1301]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 326

[3.1668]→[3.38623:38703](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.1668]

[3.1740]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 341

[3.2366]→[3.38704:38784](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.2366]

[3.2438]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 352

[3.2970]→[3.38785:38863](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.2970]

[3.3040]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 359

[3.3348]→[3.38864:38942](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[3.3348]

[3.3418]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 465

[3.413]→[3.38943:39041](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[3.413]

[2.7883]

local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)
replacement in drawing.lua at line 470

[3.467]→[3.39042:39140](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[3.467]

[2.7963]

local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)
replacement in drawing.lua at line 481

[3.7258]→[3.39141:39239](∅→∅)

local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[3.7258]

[3.7414]

local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)
replacement in drawing.lua at line 619

[2.8334]→[3.39240:39318](∅→∅),[3.749]→[3.39240:39318](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.8334]

[3.19800]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 636

[2.8406]→[3.39319:39397](∅→∅),[3.867]→[3.39319:39397](∅→∅)

local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.8406]

[3.20403]

local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)
replacement in drawing.lua at line 717

[3.27533]→[3.27533:27579](∅→∅),[3.27579]→[3.39509:39555](∅→∅)

function Drawing.coord(n) -- pixels to parts
return math.floor(n*256/Editor_state.width)

[3.27533]

[3.11944]

function Drawing.coord(n, width) -- pixels to parts
return math.floor(n*256/width)