drop some redundant args when clearing the cache

[?]

Jul 17, 2022, 3:18 PM

LSYLEVBDBZBGLSCXTRBW46WT4TUMMSPCH7M6HSNYI5SIH2WNPYEAC

Dependencies

[2] QCPXQ2E3 add state arg to a few functions
[3] 2RXZ3PGO beginning of a new approach to scroll+wrap
[4] KOYAJWE4 extract a couple more methods
[5] PLKNHYZ4 extract a function
[6] SPSW74Y5 add state arg to Text.keychord_pressed
[7] 7LVK4KRD fix a failing test
[8] 2ZYV7D3W handle tab characters
[9] KZ5GAYRP this fixes the immediate regression
[10] 4J2L6JMR bugfix: deleting a selection spanning pages
[11] WOXIYUTL bugfix: manage screen_top and cursor when resizing
[12] XNFTJHC4 split keyboard handling between Text and Drawing
[13] PX7DDEMO autosave slightly less aggressively
[14] MYC7XR5Q bugfix: lines that aren't drawn from the start
[15] LF7BWEG4 group all editor globals
[16] Z5HLXU4P add state arg to a few functions
[17] LXTTOB33 extract a couple of files
[18] R53OF3ON one bug I've repeatedly run into while testing with Moby Dick
[19] 4CTZOJPC stop pretending globals are local
[20] CG3264MM move
[21] HOSPP2AN crisp font rendering
[22] 65XHTZEK regression: couldn't do many drawing operations because line.y was reset
[23] S2MISTTM add state arg to a few functions
[24] GN3IF4WF bugfix: pasting newlines
[25] HMODUNJE scroll on backspace
[26] PTDO2SOT add state arg to schedule_save
[27] AYE2VEGJ extract a couple of methods
[28] BULPIBEG beginnings of a module for the text editor
[29] OGUV4HSA remove some memory leaks from rendered fragments

Change contents

replacement in text.lua at line 155

[3.344]→[3.344:396](∅→∅)

Text.clear_cache(State.lines[State.cursor1.line])

[3.344]

[3.396]

Text.clear_screen_line_cache(State, State.cursor1.line)
replacement in text.lua at line 221

[3.3000]→[3.2756:2810](∅→∅)

Text.clear_cache(State.lines[State.cursor1.line])

[3.3000]

[3.2810]

Text.clear_screen_line_cache(State, State.cursor1.line)
replacement in text.lua at line 257

[3.3922]→[3.4211:4265](∅→∅)

Text.clear_cache(State.lines[State.cursor1.line])

[3.3922]

[3.137]

Text.clear_screen_line_cache(State, State.cursor1.line)
replacement in text.lua at line 349

[3.2389]→[3.2389:2495](∅→∅)

Text.clear_cache(State.lines[State.cursor1.line])
Text.clear_cache(State.lines[State.cursor1.line+1])

[3.2389]

[3.2495]

Text.clear_screen_line_cache(State, State.cursor1.line)
Text.clear_screen_line_cache(State, State.cursor1.line+1)
replacement in text.lua at line 987

[3.732]→[2.5912:5951](∅→∅)

for _,line in ipairs(State.lines) do

[3.732]

[3.1828]

for line_index,line in ipairs(State.lines) do
replacement in text.lua at line 990

[3.1874]→[3.317:344](∅→∅),[3.20]→[3.317:344](∅→∅)

Text.clear_cache(line)

[3.1874]

[3.2910]

Text.clear_screen_line_cache(State, line_index)
replacement in text.lua at line 994

[3.2921]→[3.345:438](∅→∅)

function Text.clear_cache(line)
line.fragments = nil
line.screen_line_starting_pos = nil

[3.2921]

[3.438]

function Text.clear_screen_line_cache(State, line_index)
State.lines[line_index].fragments = nil
State.lines[line_index].screen_line_starting_pos = nil
replacement in select.lua at line 140

[3.47298]→[3.2618:2656](∅→∅)

Text.clear_cache(State.lines[minl])

[3.47298]

[3.2656]

Text.clear_screen_line_cache(State, minl)