akkartik/driver.love - Change TBB7GHINPHDTKI3B6U3M2OF7UGQ5V5DUHODB7UNKNZMBA4NWKUFAC

snapshot: a cleaner organization

scenarios:

Zoom = 1
- pan with mouse: ✓
- pan with up arrow: ✓
- pan with down arrow: ✓
Zoom < 1
- pan with mouse: ✓
- pan with up arrow: ✓
- pan with down arrow: ✗
Zoom > 1
- pan with mouse: ✓
- pan with up arrow: ✗
- pan with down arrow: ✓

What ✓ means:

pan with mouse: lines don't slide relative to the surface
- will still slide relative to the surface when zooming in/out; that's unavoidable because we want integer pixels for crisp text
pan with keyboard: at least some part of cursor is always peeking within the viewport
- might still look ugly, with the line containing the cursor almost invisible, but hitting the down arrow will never pan upwards, or vice versa

Still not working though. I'm pretty much guaranteeing by construction that if Viewport.y was set from screen_top1, then screen_top1 will not be perturbed. And yet using scale() inside update_editor_box is incorrect. Hmm..

Created by Kartik K. Agaram on October 25, 2023

TBB7GHINPHDTKI3B6U3M2OF7UGQ5V5DUHODB7UNKNZMBA4NWKUFAC

Dependencies

In channels

main

Change contents

Replacement in 0030-update_editor_box at line 1 [3.26]

B:BD[3.26] → [2.32:103]

update_editor_box = function(node, preserve_screen_top_of_cursor_node)

[3.26]

[3.98]

update_editor_box = function(node, skip_updating_screen_top_for)

Replacement in 0030-update_editor_box at line 4 [3.26]
∅:D[4.519] → [5.31:60]
B:BD[3.137] → [5.31:60]
∅:D[5.60] → [6.67:97]
B:BD[7.153] → [6.67:97]
```
	if node.y > Viewport.y then
		if node ~= Cursor_node then
```
[4.519]
[3.238]
```
	if node ~= skip_updating_screen_top_for then
		if node.y > Viewport.y then
```

Insertion in 0030-update_editor_box at line 8 [3.26]

[3.309]

			node.editor.top = vy(node.y)
		else
			node.editor.screen_top1, node.editor.top = schema1_of_y(node.editor, scale(Viewport.y-node.y))

Deletion in 0030-update_editor_box at line 12 [3.26]
B:BD[3.315] → [8.31:62]
∅:D[9.58] → [3.346:352]
∅:D[8.62] → [3.346:352]
B:BD[3.346] → [3.346:352]
B:BD[3.352] → [8.63:153]
```
		node.editor.top = vy(node.y)
	else
		node.editor.screen_top1, node.editor.top = schema1_of_y(node.editor, Viewport.y-node.y)
```

Replacement in 0028-A at line 1 [10.6019]

B:BD[10.6019] → [2.111:160]

A = function(preserve_screen_top_of_cursor_node)

[10.6019]

[8.1424]

A = function(skip_updating_screen_top_for)

Replacement in 0028-A at line 4 [10.6019]

∅:D[4.536] → [8.1834:1880]

B:BD[8.1834] → [8.1834:1880]

	compute_layout(Page, Page.x,Page.y, Surface)

[4.536]

[8.1929]

	compute_layout(Page, Page.x,Page.y, Surface, skip_updating_screen_top_for)

Replacement in 0028-A at line 6 [10.6019]
B:BD[8.1955] → [2.161:200]
```
	B(preserve_screen_top_of_cursor_node)
```
[8.1955]
[8.1960]
```
	B(skip_updating_screen_top_for)
```

Insertion in 0023-on.keychord_press at line 24 [11.26]

[11.638]

			A(--[[skip updating screen_top for]] Cursor_node)
			return

Replacement in 0023-on.keychord_press at line 27 [11.26]
B:BD[11.644] → [2.211:262]
```
		A(--[[preserve screen_top of cursor node]] true)
```
[11.644]
[11.695]
```
		A()
```
Replacement in 0023-on.keychord_press at line 61 [11.26]
B:BD[11.1610] → [12.463:466]
```
end
```
[11.1610]
```
end
```

Insertion in 0022-on.text_input at line 7 [13.1238]

[13.1585]

			A(--[[skip updating screen_top for]] Cursor_node)
			return

Replacement in 0022-on.text_input at line 10 [13.1238]
B:BD[13.1591] → [2.264:315]
```
		A(--[[preserve screen_top of cursor node]] true)
```
[13.1591]
[13.1642]
```
		A()
```
Replacement in 0022-on.text_input at line 12 [13.1238]
B:BD[13.1647] → [2.316:319]
```
end
```
[13.1647]
```
end
```

Replacement in 0021-compute_layout at line 1 [13.4307]

B:BD[13.4307] → [2.321:411]

compute_layout = function(node, x,y, nodes_to_render, preserve_screen_top_of_cursor_node)

[13.4307]

[13.4398]

compute_layout = function(node, x,y, nodes_to_render, skip_updating_screen_top_for)

Replacement in 0021-compute_layout at line 34 [13.4307]

B:BD[13.5191] → [2.412:475]

			update_editor_box(node, preserve_screen_top_of_cursor_node)

[13.5191]

[13.5254]

			update_editor_box(node, skip_updating_screen_top_for)

Replacement in 0019-B at line 1 [14.6168]

B:BD[14.6168] → [2.478:527]

B = function(preserve_screen_top_of_cursor_node)

[14.6168]

[8.4517]

B = function(skip_updating_screen_top_for)

Replacement in 0019-B at line 19 [14.6168]

B:BD[8.5063] → [2.528:591]

				update_editor_box(obj, preserve_screen_top_of_cursor_node)

[8.5063]

[8.5090]

				update_editor_box(obj, skip_updating_screen_top_for)

Replacement in 0019-B at line 25 [14.6168]
B:BD[8.5188] → [2.592:595]
```
end
```
[8.5188]
```
end
```

snapshot: a cleaner organization

Dependencies

In channels

Change contents

Replacement in 0030-update_editor_box at line 1 [3.26]

Replacement in 0030-update_editor_box at line 4 [3.26]

Insertion in 0030-update_editor_box at line 8 [3.26]

Deletion in 0030-update_editor_box at line 12 [3.26]

Replacement in 0028-A at line 1 [10.6019]

Replacement in 0028-A at line 4 [10.6019]

Replacement in 0028-A at line 6 [10.6019]

Insertion in 0023-on.keychord_press at line 24 [11.26]

Replacement in 0023-on.keychord_press at line 27 [11.26]

Replacement in 0023-on.keychord_press at line 61 [11.26]

Insertion in 0022-on.text_input at line 7 [13.1238]

Replacement in 0022-on.text_input at line 10 [13.1238]

Replacement in 0022-on.text_input at line 12 [13.1238]

Replacement in 0021-compute_layout at line 1 [13.4307]

Replacement in 0021-compute_layout at line 34 [13.4307]

Replacement in 0019-B at line 1 [14.6168]

Replacement in 0019-B at line 19 [14.6168]

Replacement in 0019-B at line 25 [14.6168]