akkartik/pensieve.love - Change 53LXFA2O4DZ2GJ7GC6M3FUUNFJ5MOKSUJ74XU2YNLO3HSOEASSXAC

some more logs

The previous commit was super useful. The links are not actually being lost when I exit pensieve. Instead, they're somehow not being set in some code path that I haven't tracked down yet.

The important thing is, I've been missing things because I wasn't running it from a terminal. prints (that the links are empty) were disappearing that would have helped diagnose it. Lesson learned: always send error prints to the log as well. At least there we have a hope of spotting them.

Once we start emitting prints to the log, also include the function name. On errors so far we've not bothered because the default LOVE error handler shows the stack trace. However the logs don't record the stack, and we might go looking at them long after the app crashes. The print doesn't need function names, but the log does so we'll just lowest-common-denominator both.

Created by Kartik K. Agaram on March 8, 2023

53LXFA2O4DZ2GJ7GC6M3FUUNFJ5MOKSUJ74XU2YNLO3HSOEASSXAC

Dependencies

In channels

main

Change contents

Replacement in run.lua at line 143 [8.178044]

B:BD[7.8441] → [7.8441:8583]

  print('reading notes from '..love.filesystem.getSaveDirectory()..'/'..Directory)
  print('put any notes there (and make frequent backups)')

[7.8441]

[7.8583]

  print_and_log('reading notes from '..love.filesystem.getSaveDirectory()..'/'..Directory)
  print_and_log('put any notes there (and make frequent backups)')

Insertion in run.lua at line 167 [8.178044]
[8.179341]
[8.179341]
```
end
function print_and_log(s)
  print(s)
  log(3, s)
```
Replacement in run.lua at line 269 [8.178044]
B:BD[7.12271] → [7.12271:12294]
```
      print(line.mode)
```
[7.12271]
[7.12294]
```
      print_and_log('refresh_pane_height: '..line.mode)
```
Replacement in run.lua at line 370 [8.178044]
B:BD[7.16461] → [7.16461:16494]
```
    print(Display_settings.mode)
```
[7.16461]
[7.16494]
```
    print_and_log('run.draw: '..Display_settings.mode)
```

Replacement in run.lua at line 647 [8.178044]

B:BD[7.25284] → [7.25284:25317]

    print(Display_settings.mode)

[7.25284]

[7.25317]

    print_and_log('run.mouse_press: '..Display_settings.mode)

Replacement in run.lua at line 761 [8.178044]

B:BD[7.28747] → [7.28747:28780]

    print(Display_settings.mode)

[7.28747]

[7.28780]

    print_and_log('run.text_input: '..Display_settings.mode)

Replacement in run.lua at line 833 [8.178044]

B:BD[7.30419] → [7.30419:30452]

    print(Display_settings.mode)

[7.30419]

[7.30452]

    print_and_log('run.keychord_press: '..Display_settings.mode)

Replacement in run.lua at line 1122 [8.178044]

B:BD[7.42198] → [7.42198:42235]

    print('no current note to edit')

[7.42198]

[7.42235]

    print_and_log('keychord_press (maximized): no current note to edit')

Replacement in run.lua at line 1127 [8.178044]

B:BD[7.42331] → [7.42331:42368]

    print('no current note to edit')

[7.42331]

[7.42368]

    print_and_log('keychord_press (maximized): no current note to edit')

Replacement in file.lua at line 107 [10.15083]
B:BD[9.244] → [9.244:268]
```
      print(shape.mode)
```
[9.244]
[9.268]
```
      print_and_log('load_drawing: '..shape.mode)
```
Replacement in file.lua at line 142 [10.15083]
B:BD[9.394] → [9.394:418]
```
      print(shape.mode)
```
[9.394]
[9.418]
```
      print_and_log('store_drawing: '..shape.mode)
```

Replacement in file.lua at line 163 [10.15083]

B:BD[11.494] → [6.393:463]

∅:D[6.463] → [12.47:104]

∅:D[11.494] → [12.47:104]

B:BD[12.47] → [12.47:104]

    log(2, 'save_links: no links; getting rid of .json if it exists')
    print('no links; getting rid of .json if it exists')

[11.494]

[12.104]

    print_and_log('save_links: no links; getting rid of .json if it exists')

Replacement in file.lua at line 234 [10.15083]

B:BD[13.3157] → [13.3157:3181]

      print(shape.mode)

[13.3157]

[13.3181]

      print_and_log('load_drawing_from_array: '..shape.mode)

Insertion in errors.lua at line 3 [14.652]
[14.690]
[3.191]
```
  log(2, 'add_error: '..err)
```

Replacement in commands.lua at line 238 [17.39]

∅:D[15.123] → [16.319:370]

∅:D[4.126] → [16.319:370]

B:BD[16.319] → [16.319:370]

        print('dropping '..Surface[#Surface].name)

[4.126]

[16.370]

        print_and_log('keychord_press (palette) return: dropping '..Surface[#Surface].name)

Replacement in commands.lua at line 546 [17.39]

B:BD[18.956] → [18.956:1017]

    print(('not implemented yet: %s'):format(function_name))

[18.956]

[19.735]

    print_and_log(('run_command: not implemented yet: %s'):format(function_name))

Replacement in commands.lua at line 594 [17.39]

B:BD[2.1279] → [2.1279:1322]

    print('file not found: '..column_name)

[2.1279]

[20.18]

    print_and_log('create_column: file not found: '..column_name)

Replacement in commands.lua at line 1214 [17.39]

B:BD[21.846] → [21.846:899]

  print('renaming link', from, 'of', pane, 'to', to)

[21.846]

[11.1192]

  print_and_log('renaming link', from, 'of', pane, 'to', to)

Replacement in commands.lua at line 1251 [17.39]

B:BD[22.200] → [11.1349:1449]

  print(('clearing link %s of %s (used to point to %s)'):format(rel, pane.id, Links[pane.id][rel]))

[22.200]

[11.1449]

  print_and_log(('clearing link %s of %s (used to point to %s)'):format(rel, pane.id, Links[pane.id][rel]))

Replacement in commands.lua at line 1589 [17.39]

∅:D[5.132] → [23.60:115]

B:BD[23.60] → [23.60:115]

  print('creating directory '..Directory..dirname(id))

[5.132]

[23.115]

  print_and_log('new_pane: creating directory '..Directory..dirname(id))