akkartik/pensieve.love - Change CSV2GBWMGLN6CR3FIUUQ3FTZAFJJFO7DTPNOKOY5IOXNFI4O67IAC

experiment: dramatically simplify the panning check

I think I've been struggling with this because I missed a second call-site (in textinput) where the viewport should be getting updated from the (editable) cursor pane.

One more note: Over the months I completely forgot about the list of manual tests! Utterly baffling, and also extremely important that that is possible.

This program definitely outgrew my brain, and it's only when sitting with it for a while with the prospect of reimplementing it that I was able to find the (gaping) flaw in the design.

(If, indeed, I'm right and I don't uncover some corner case. I've checked the commits of recent months for scenarios, and also the manual tests regarding panning.)

Created by Kartik K. Agaram on December 21, 2022

CSV2GBWMGLN6CR3FIUUQ3FTZAFJJFO7DTPNOKOY5IOXNFI4O67IAC

Dependencies

In channels

main

Change contents

Deletion in run.lua at line 114 [3.178044]

B:BD[2.18] → [2.18:194]

∅:D[2.194] → [4.8050:8051]

∅:D[5.223] → [4.8050:8051]

B:BD[4.8050] → [4.8050:8051]

  -- This little bit of state ensures we don't mess with a pane's screen_top
  -- if it was just used to update the viewport.
  Editable_cursor_pane_updated_screen_top = false

Insertion in run.lua at line 347 [3.178044]
[2.418]
[4.15024]
```
  if options == nil then return true end
```

Replacement in run.lua at line 352 [3.178044]

B:BD[2.515] → [2.515:751]

  if not pane.editable then return true end
  if options == nil then return true end
  if not options.ignore_editable_cursor_pane then return true end
  if not Editable_cursor_pane_updated_screen_top then return true end
  return false

[2.515]

[4.15470]

  return not options.ignore_cursor_pane

Replacement in run.lua at line 737 [3.178044]

B:BD[4.27527] → [6.2412:2438]

              plan_draw()

[4.27527]

[4.27553]

              plan_draw{ignore_cursor_pane=true}

Replacement in run.lua at line 815 [3.178044]

B:BD[2.901] → [2.901:957]

            plan_draw{ignore_editable_cursor_pane=true}

[2.901]

[6.3123]

            plan_draw{ignore_cursor_pane=true}

Replacement in run.lua at line 1161 [3.178044]

B:BD[4.44094] → [2.958:1086]

  Editable_cursor_pane_updated_screen_top = not eq(old_top, pane.screen_top1)
  if Editable_cursor_pane_updated_screen_top then

[4.44094]

[4.44498]

  if not eq(old_top, pane.screen_top1) then