akkartik/pensieve.love - Change GR4RROJFJOGM2WLQSVK5R5UYD7IK6ITF6UP5RVHAHD3J4OFJWGCAC

debug this from scratch, undoing all the hacks

There is no state of grace to git bisect this against.

Though I plan to put back the search bar hack in bring_cursor_into_view. It's not implicated here.

The bug occurs even in the absence of wrapping lines.

I think what is going on is: bring_cursor_into_view updates the viewport but does no scrolling. It assumes plan_draw will take care of that. But we're suppressing plan_draw for the cursor pane. That's the issue.

Created by Kartik K. Agaram on December 29, 2022

GR4RROJFJOGM2WLQSVK5R5UYD7IK6ITF6UP5RVHAHD3J4OFJWGCAC

Dependencies

In channels

main

Change contents

Replacement in run.lua at line 287 [5.178044]
B:BD[3.223] → [4.41:66]
```
--?   print('plan draw')
```
[3.223]
[6.72]
```
  print('plan draw')
```

Insertion in run.lua at line 311 [5.178044]

[7.13711]

[8.39]

          end
          if column_index == 1 and pane_index == 1 then
            print('plan draw before:', pane.screen_top1.line, pane.screen_top1.pos)

Insertion in run.lua at line 318 [5.178044]

[7.13950]

              if column_index == 1 and pane_index == 1 then
                print('plan draw after:', pane.screen_top1.line, pane.screen_top1.pos)
              end

Replacement in run.lua at line 360 [5.178044]
B:BD[5.182317] → [9.491:511]
```
--?   print('draw')
```
[5.182317]
[7.15508]
```
--?   print('draw', Display_settings.y)
```

Replacement in run.lua at line 421 [5.178044]

B:BD[7.17812] → [7.17812:18069]

--?     if Surface[pane.column_index].name == 'search: donate' then
--?       print('draw: search: donate', pane, Display_settings.search_all_pane)
--?       print(#pane.lines, #pane.line_cache, pane._height)
--?       print(pane.lines[1].data)
--?     end

[7.17812]

[7.18069]

    if pane.column_index == 1 and pane.pane_index == 1 then
      print('draw', pane.id, 'from y', pane.top, 'down to screen height', App.screen.height)
      print('screen top', pane.screen_top1.line, pane.screen_top1.pos)
      print('cursor', pane.cursor1.line, pane.cursor1.pos)
    end

Replacement in run.lua at line 739 [5.178044]

B:BD[10.950] → [2.17:112]

              local screen_top_updated = maybe_update_screen_top_of_cursor_pane(pane, old_top)

[10.950]

[7.27494]

              maybe_update_screen_top_of_cursor_pane(pane, old_top)

Replacement in run.lua at line 741 [5.178044]

B:BD[7.27527] → [2.113:192]

              plan_draw{preserve_screen_top_of_cursor_pane=screen_top_updated}

[7.27527]

[7.27553]

              plan_draw{preserve_screen_top_of_cursor_pane=true}

Replacement in run.lua at line 783 [5.178044]
∅:D[10.1029] → [7.28805:28842]
B:BD[5.183567] → [7.28805:28842]
```
--?   print('keychord press', chord)
```
[10.1029]
[10.1031]
```
  print('keychord press', chord)
```

Insertion in run.lua at line 815 [5.178044]

[8.2753]

            print('edit.keychord_press', chord)

Replacement in run.lua at line 820 [5.178044]

B:BD[3.901] → [2.287:364]

            plan_draw{preserve_screen_top_of_cursor_pane=screen_top_updated}

[3.901]

[8.3123]

            plan_draw{preserve_screen_top_of_cursor_pane=true}

Replacement in run.lua at line 1077 [5.178044]

B:BD[7.39394] → [7.39394:39465]

--?   print('viewport before', Display_settings.x, Display_settings.y)

[7.39394]

[7.39465]

  print('bring_in_view: viewport before', Display_settings.x, Display_settings.y)
  print('bring_in_view: pane before', pane.screen_top1.line, pane.screen_top1.pos, pane.cursor1.line, pane.cursor1.pos)

Replacement in run.lua at line 1082 [5.178044]

B:BD[7.39716] → [7.39716:40053]

--?   print(y_of_schema1(pane, pane.cursor1))
--?   print('viewport starts at', Display_settings.y)
--?   print('pane starts at', up_edge_sy(Cursor_pane.col, Cursor_pane.row))
--?   print('cursor line contains ^'..pane.lines[pane.cursor1.line].data..'$')
--?   print('cursor is at', y_of_schema1(pane, pane.cursor1), 'from top of pane')

[7.39716]

[7.40053]

  print('bring_in_view: pane starts at', up_edge_sy(Cursor_pane.col, Cursor_pane.row))
  print('bring_in_view: cursor line contains ^'..pane.lines[pane.cursor1.line].data..'$')
  print('bring_in_view: cursor is at', y_of_schema1(pane, pane.cursor1), 'from top of pane')

Replacement in run.lua at line 1086 [5.178044]
B:BD[7.40153] → [7.40153:40192]
```
--?   print('cursor is at', cursor_sy)
```
[7.40153]
[7.40192]
```
  print('bring_in_view: cursor is at', cursor_sy)
```

Replacement in run.lua at line 1104 [5.178044]

B:BD[7.40899] → [7.40899:41052]

--?       print('cursor used to be at ', cursor_sy - Display_settings.y)
--?       print('subtract', App.screen.height, App.screen.height-Header_height)

[7.40899]

[7.41052]

      print('subtract', App.screen.height, App.screen.height-Header_height)

Replacement in run.lua at line 1106 [5.178044]

B:BD[7.41158] → [7.41158:41568]

      -- Bah, temporarily giving up on debugging.
      Display_settings.y = Display_settings.y + Line_height
--?       print('=>', Display_settings.y)
--?       print('cursor now at ', cursor_sy - Display_settings.y)
--?       print('viewport height', App.screen.height)
--?       print('cursor row starts', App.screen.height - (cursor_sy-Display_settings.y), 'px above bottom of viewport')  -- totally wrong

[7.41158]

[7.41568]

      print('=>', Display_settings.y)
      print('cursor now at ', cursor_sy - Display_settings.y)
      print('viewport height', App.screen.height)
      print('cursor row starts', App.screen.height - (cursor_sy-Display_settings.y), 'px above bottom of viewport')  -- totally wrong

Replacement in run.lua at line 1116 [5.178044]

B:BD[7.41852] → [7.41852:41920]

--?   print('viewport now', Display_settings.x, Display_settings.y)

[7.41852]

[7.41920]

  print('viewport now', Display_settings.x, Display_settings.y)

Insertion in run.lua at line 1154 [5.178044]

[7.43350]

[11.143]

  if eq(old_top, pane.screen_top1) then return end
  print('AAA', pane.screen_top1.line, pane.screen_top1.pos, pane.cursor1.line, pane.cursor1.pos)

Replacement in run.lua at line 1157 [5.178044]

B:BD[11.243] → [2.365:557]

  if not eq(old_top, pane.screen_top1) and eq(old_top, {line=1, pos=1}) and pane.top > Header_height and cursor_sy - Display_settings.y > App.screen.height - Header_height  - Line_height then

[11.243]

[2.557]

  print('cursor is at pixel', cursor_sy)
  if eq(old_top, {line=1, pos=1}) and pane.top > Header_height and cursor_sy - Display_settings.y > App.screen.height - Header_height  - Line_height then

Insertion in run.lua at line 1162 [5.178044]
[2.766]
[11.397]
```
    print('BBB')
```

Insertion in run.lua at line 1166 [5.178044]

[11.597]

    print('Display_settings.y is now', Display_settings.y)

Deletion in run.lua at line 1168 [5.178044]

B:BD[11.608] → [11.608:614]

B:BD[11.614] → [2.767:1089]

  end
  local screen_top_updated = not eq(old_top, pane.screen_top1)
  if screen_top_updated then
    Display_settings.y = up_edge_sy(Cursor_pane.col, Cursor_pane.row) + y_of_schema1(pane, pane.screen_top1)
    Surface.cursor_on_screen_check = true  -- cursor was on screen before keystroke, so it should remain on screen after

Replacement in run.lua at line 1169 [5.178044]

B:BD[2.1095] → [2.1095:1123]

  return screen_top_updated

[2.1095]

[7.44774]

  print('CCC')
  Display_settings.y = up_edge_sy(Cursor_pane.col, Cursor_pane.row) + y_of_schema1(pane, pane.screen_top1)
  Surface.cursor_on_screen_check = true  -- cursor was on screen before keystroke, so it should remain on screen after
  print('Display_settings.y is now', Display_settings.y)