akkartik/pensieve.love - Change OANSMSQYJARQ5ZCJ62CO3TL4EF7ZDJE6RUGGROWDTMTZRHBUGMGQC

delete the optimization of commit 9ca662ece1

I'm not sure what the right solution is, but this seems definitely on the wrong track. It just doesn't make sense to decouple a pane's top margin from Display_settings.y. That causes panes to slide relative to each other, which we want to avoid at all costs. We need a different approach.

Created by Kartik K. Agaram on July 22, 2022

OANSMSQYJARQ5ZCJ62CO3TL4EF7ZDJE6RUGGROWDTMTZRHBUGMGQC

Dependencies

In channels

main

Change contents

Replacement in main.lua at line 120 [5.2]

B:BD[4.3171] → [2.114:191]

  table.insert(column, initialize_pane_with_placeholder_coordinates('foo3'))

[4.3171]

[4.3248]

--?   table.insert(column, initialize_pane_with_placeholder_coordinates('foo3'))

Deletion in main.lua at line 222 [5.2]

B:BD[6.1492] → [3.8:350]

            -- TODO: this optimization avoids drawing a lot off screen, but makes panning less fluid
--?             if pane.show_cursor and not eq(pane.screen_top1, {line=1, pos=1}) then
--?               pane.top = math.max(Margin_top, pane.top)
--? --?               print(('tweaking pane top to %d'):format(pane.top))
--?             end

Replacement in Manual_tests.md at line 28 [7.1]

B:BD[6.4061] → [6.4061:4394]

  * Perhaps keys should not go to cursor pane if it's off screen (or cursor is off screen in edit mode)? Then you only get global keys?
* lines.love assumes cursor can never be above screen top. Do we want to violate this constraint in pensieve? Or move the cursor to satisfy it as needed? Or forbid movements that would violate it?

[6.4061]

[6.4394]

    * TODO: lines.love assumes cursor can never be above screen top. Do we want to violate this constraint in pensieve? Or move the cursor to satisfy it as needed? Or forbid movements that would violate it?
* Keypresses not sent to cursor pane if off screen
* Keypresses not sent to pane in edit mode if its cursor is off screen

Insertion in Manual_tests.md at line 32 [7.1]

[6.4472]

[8.168]


* hit pagedown. All columns scroll down by same amount.
* hit pageup. All columns scroll up by same amount.
* move mouse off any panes, press down and drag around. All columns pan by same amount.
* select a pane, hit ctrl+x, hit pagedown. All columns scroll down by same amount.
* select a pane, hit ctrl+x, hit pageup. All columns scroll up by same amount.
* select a pane, hit ctrl+x, move mouse off any panes, press down and drag around. All columns pan by same amount.
* select a pane, hit ctrl+x, hit pagedown. Cursor remains visible.
* select a pane, hit ctrl+x, hit pageup. Cursor remains visible.
* select a pane, hit ctrl+x, hit pagedown, type some text. Surface does not pan.
* select a pane, hit ctrl+x, hit pagedown, move mouse off any panes, press down and drag around. All columns pan by same amount.
* select a pane, hit pagedown, hit ctrl+x. There should be some indication that the pane can be edited, and where, either on- or off-screen.