akkartik/pensieve.love - Change OKBAAAUJRSAG7VYNKTBHEOOAMNFKREFMW2PHGNEAA2ZKSFONRR4AC

regression caused by the experiment of dabb7a6c4

It's embarrassing: page-down stopped working when I made that change. And page-down was the whole original use case for updating viewport based on the editable pane's screen_top.

This is a big sign that I need to add some tests.

Bottomline: commit dabb7a6c4 is a nice idea, but it only works if we can guarantee that any scrolling operation always moves the cursor past end of the previously visible page. Which is not true of page-down; we tend to have 1-2 screen lines of overlap.

Created by Kartik K. Agaram on February 10, 2023

OKBAAAUJRSAG7VYNKTBHEOOAMNFKREFMW2PHGNEAA2ZKSFONRR4AC

Dependencies

In channels

main

Change contents

Insertion in run.lua at line 796 [4.178044]

[3.2753]

            log(2, 'keychord 1: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))

Insertion in run.lua at line 799 [4.178044]

[5.1181]

[2.328]

            log(2, 'keychord 2: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))

Insertion in run.lua at line 803 [4.178044]

[2.478]

              log(2, 'trying to bring cursor in view downwards')

Insertion in run.lua at line 806 [4.178044]

[2.552]

[6.870]

            log(2, 'keychord 3: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos)..' '..tostring(pane.cursor1.line)..' '..tostring(pane.cursor1.pos))

Insertion in run.lua at line 809 [4.178044]

[2.577]

[3.3123]

            log(2, 'keychord 4: '..chord..' '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos))

Replacement in run.lua at line 1066 [4.178044]

B:BD[7.39394] → [8.460:670]

--?   print('bring_in_view: viewport before', Display_settings.x, Display_settings.y)
--?   print('bring_in_view: pane before', pane.screen_top1.line, pane.screen_top1.pos, pane.cursor1.line, pane.cursor1.pos)

[7.39394]

[7.39465]

  log(2, 'bring_in_view: viewport before: '..tostring(Display_settings.x)..','..Display_settings.y)
  log(2, 'bring_in_view: pane before: '..tostring(pane.screen_top1.line)..' '..tostring(pane.screen_top1.pos)..' '..tostring(pane.cursor1.line)..' '..tostring(pane.cursor1.pos))

Replacement in run.lua at line 1071 [4.178044]

B:BD[7.39716] → [8.671:953]

--?   print('bring_in_view: pane starts at', up_edge_sy(Cursor_pane.col, Cursor_pane.row))
--?   print('bring_in_view: cursor line contains ^'..pane.lines[pane.cursor1.line].data..'$')
--?   print('bring_in_view: cursor is at', y_of_schema1(pane, pane.cursor1), 'from top of pane')

[7.39716]

[7.40053]

  log(2, 'bring_in_view: pane starts at '..tostring(up_edge_sy(Cursor_pane.col, Cursor_pane.row)))
  log(2, 'bring_in_view: cursor line contains ^'..pane.lines[pane.cursor1.line].data..'$')
  log(2, 'bring_in_view: cursor is at '..tostring(y_of_schema1(pane, pane.cursor1))..' from top of pane')

Replacement in run.lua at line 1075 [4.178044]

B:BD[7.40153] → [8.954:1008]

--?   print('bring_in_view: cursor is at', cursor_sy)

[7.40153]

[7.40192]

  log(2, 'bring_in_view: cursor is at '..tostring(cursor_sy))

Insertion in run.lua at line 1078 [4.178044]
[7.40424]
[7.40424]
```
    log(2, 'bring_in_view: all well; returning')
```