akkartik/pensieve.love - Change QBL4YDQ5QC4MZ7RFS4ZSEBPN5WATAJ7UQLUPTXDUMXAMGBGQDOOQC

snapshot

I'm still trying to get those two tests to scroll and keep cursor on screen: typing in text at bottom screen line of screen until it wraps hitting down arrow from bottom screen line of screen (assuming pane extends further down)

But this small tweak to keychord_pressed_on_editable_pane isn't the answer. It ensures down arrow makes forward progress, but the first down arrow past bottom still makes the cursor invisible. Unclear why it gets into that state and how it's able to get out of that state now.

Things I remember now:

pane.cursor_y tracks the bottom pixel of the cursor
when you press down arrow in an editor and it doesn't use it, only the rest of the surface pans, thanks to ignore_editable_cursor_pane.

Another thing I've learned: the bug with down arrow is unrelated to wrapping lines. I can reproduce it in an editor containing all single-char lines.

It's almost like snap_cursor_to_bottom_of_screen isn't operating exactly opposite to draw in some situations. Assuming no line wrapping: screen_top = snap_cursor_to_bottom_of_screen(cursor) screen_bottom = edit.draw() assert(cursor.line == screen_bottom.line)

This is getting violated somehow?! Even if the screen height isn't an integral multiple of line_height, it seems like straightforward modulo arithmetic. If cursor is at bottom screen line and there's no wrapping: screen_top.line = cursor.line - math.floor(App.screen.height/line_height) screen_bottom.line = screen_top.line + math.floor(App.screen.height/line_height) assert(cursor.line == screen_bottom.line)

I'm still juggling tons of state in my head, feeling incredibly stupid.

Created by Kartik K. Agaram on August 16, 2022

QBL4YDQ5QC4MZ7RFS4ZSEBPN5WATAJ7UQLUPTXDUMXAMGBGQDOOQC

Dependencies

In channels

main

Change contents

Replacement in text.lua at line 486 [5.1]

B:BD[4.5973] → [4.5973:6132]

--?   print('down', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

[4.5973]

[6.1281]

  print('down', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

Replacement in text.lua at line 489 [5.1]

B:BD[7.2960] → [7.2960:3017]

--?     print('cursor at final screen line of its line')

[7.2960]

[4.6133]

    print('cursor at final screen line of its line')

Replacement in text.lua at line 501 [5.1]

B:BD[4.6537] → [4.6537:6622]

∅:D[4.6622] → [7.3515:3562]

∅:D[8.70860] → [7.3515:3562]

B:BD[7.3515] → [7.3515:3562]

--?       print('screen top before:', State.screen_top1.line, State.screen_top1.pos)
--?       print('scroll up preserving cursor')

[4.6537]

[6.1451]

      print('screen top before:', State.screen_top1.line, State.screen_top1.pos)
      print('scroll up preserving cursor')

Replacement in text.lua at line 504 [5.1]

∅:D[9.1385] → [4.6623:6707]

∅:D[6.1501] → [4.6623:6707]

B:BD[10.321] → [4.6623:6707]

--?       print('screen top after:', State.screen_top1.line, State.screen_top1.pos)

[6.1501]

[7.3680]

      print('screen top after:', State.screen_top1.line, State.screen_top1.pos)

Replacement in text.lua at line 512 [5.1]

B:BD[7.3929] → [7.3929:3993]

--?     print('cursor is NOT at final screen line of its line')

[7.3929]

[6.1502]

    print('cursor is NOT at final screen line of its line')

Replacement in text.lua at line 515 [5.1]

∅:D[11.688] → [7.4192:4338]

∅:D[12.4875] → [7.4192:4338]

∅:D[4.6880] → [7.4192:4338]

∅:D[8.71160] → [7.4192:4338]

B:BD[7.4192] → [7.4192:4338]

--?     print('switching pos of screen line at cursor from '..tostring(screen_line_starting_pos)..' to '..tostring(new_screen_line_starting_pos))

[11.688]

[4.6881]

    print('switching pos of screen line at cursor from '..tostring(screen_line_starting_pos)..' to '..tostring(new_screen_line_starting_pos))

Replacement in text.lua at line 519 [5.1]

∅:D[6.1720] → [4.7219:7293]

B:BD[4.7219] → [4.7219:7293]

--?     print('cursor pos is now', State.cursor1.line, State.cursor1.pos)

[6.1720]

[13.130]

    print('cursor pos is now', State.cursor1.line, State.cursor1.pos)

Replacement in text.lua at line 521 [5.1]

B:BD[7.4631] → [7.4631:4678]

--?       print('scroll up preserving cursor')

[13.154]

[6.1721]

      print('scroll up preserving cursor')

Replacement in text.lua at line 523 [5.1]

∅:D[9.1449] → [4.7294:7378]

∅:D[6.1771] → [4.7294:7378]

B:BD[10.378] → [4.7294:7378]

--?       print('screen top after:', State.screen_top1.line, State.screen_top1.pos)

[6.1771]

[7.4796]

      print('screen top after:', State.screen_top1.line, State.screen_top1.pos)

Replacement in text.lua at line 526 [5.1]

B:BD[7.4810] → [4.7379:7536]

--?   print('=>', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

[7.4810]

[14.6091]

  print('=>', State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos, State.screen_bottom1.line, State.screen_bottom1.pos)

Replacement in text.lua at line 694 [5.1]

B:BD[15.580] → [9.3087:3208]

--?   print('cursor pos '..tostring(State.cursor1.pos)..' is on the #'..tostring(top2.screen_line)..' screen line down')

[15.580]

[9.3208]

  print('cursor pos '..tostring(State.cursor1.pos)..' is on the #'..tostring(top2.screen_line)..' screen line down')

Replacement in text.lua at line 698 [5.1]

B:BD[16.660] → [17.259:331]

--?     print(y, 'top2:', top2.line, top2.screen_line, top2.screen_pos)

[16.660]

[17.331]

    print(y, 'top2:', top2.line, top2.screen_line, top2.screen_pos)

Replacement in text.lua at line 715 [5.1]

B:BD[17.881] → [17.881:930]

--?       print('skipping drawing of height', h)

[17.881]

[17.930]

      print('skipping drawing of height', h)

Replacement in text.lua at line 720 [5.1]

B:BD[16.931] → [17.991:1066]

--?   print('top2 finally:', top2.line, top2.screen_line, top2.screen_pos)

[16.931]

[9.3661]

  print('top2 finally:', top2.line, top2.screen_line, top2.screen_pos)

Replacement in text.lua at line 722 [5.1]

B:BD[9.3705] → [9.3705:3781]

--?   print('top1 finally:', State.screen_top1.line, State.screen_top1.pos)

[9.3705]

[9.3781]

  print('top1 finally:', State.screen_top1.line, State.screen_top1.pos)

Insertion in main.lua at line 339 [20.2]

[18.345]

[19.1667]

        end
        if column_index == 5 then
          pane.foo = true

Replacement in main.lua at line 755 [20.2]
B:BD[21.408] → [22.246:283]
```
--?   print('keychord press', chord)
```
[21.408]
[23.8]
```
  print('keychord press', chord)
```

Replacement in main.lua at line 1103 [20.2]

B:BD[24.335] → [24.335:413]

  if pane.cursor_y < Header_height or pane.cursor_y >= App.screen.height then

[24.335]

[25.50]

--?   if pane.cursor_y + pane.line_height > App.screen.height then
--?     print('chord:', pane.cursor_y,'+',pane.line_height, '>', App.screen.height, 'stop')
--?     return
--?   end
  if pane.cursor_y < Header_height or pane.cursor_y > App.screen.height then

Replacement in main.lua at line 1114 [20.2]

B:BD[24.489] → [24.489:548]

--?     print(('%s pressed in editor pane'):format(chord))

[24.489]

[24.548]

    print(('%s pressed in editor pane'):format(chord))

Deletion in main.lua at line 1117 [20.2]

B:BD[24.667] → [24.667:747]

--?     print('screen top after:', pane.screen_top1.line, pane.screen_top1.pos)

Replacement in main.lua at line 1125 [20.2]

B:BD[26.269] → [26.269:324]

B:BD[26.324] → [3.256:381]

--?     print('updating viewport based on screen top')
--?     print('from', Display_settings.y, pane.screen_top1.line, pane.screen_top1.pos, y_of_schema1(pane, pane.screen_top1))

[26.269]

[26.324]

    print(('screen top changed from (%d,%d) to (%d,%d)'):format(old_top.line, old_top.pos, pane.screen_top1.line, pane.screen_top1.pos))
    print('updating viewport based on screen top')
    print('from', Display_settings.y, y_of_schema1(pane, pane.screen_top1))

Replacement in main.lua at line 1129 [20.2]
B:BD[26.433] → [3.382:422]
```
--?     print('to', Display_settings.y)
```
[26.433]
[26.508]
```
    print('to', Display_settings.y)
```

Replacement in edit.lua at line 139 [28.413]

∅:D[27.3030] → [28.4205:4249]

∅:D[8.98451] → [28.4205:4249]

B:BD[28.4205] → [28.4205:4249]

B:BD[28.4249] → [2.15:146]

∅:D[2.146] → [27.3031:3095]

B:BD[28.4249] → [27.3031:3095]

--?     print('draw:', y, line_index, line)
    -- I'd like to do the following, but that requires fixing up a bunch of tests.
--?     if y > App.screen.height then break end
    if y + State.line_height > App.screen.height then break end

[27.3030]

[27.3095]

--?     if State.foo then
--?     print('draw:', line_index, y, '+', State.line_height, 'vs', App.screen.height)
--?     end
    if y + State.line_height > App.screen.height then
--?       print('draw:', line.data, '--', y,'+',State.line_height, '>', App.screen.height, 'stop')
      break
    end

Insertion in edit.lua at line 180 [28.413]

[28.5853]

  end
  if State.foo then
    print('draw: screen top', State.screen_top1.line, State.screen_top1.pos, 'cursor', State.cursor1.line, State.cursor1.pos, 'screen bottom', State.screen_bottom1.line, State.screen_bottom1.pos)

Insertion in edit.lua at line 191 [28.413]
[29.2101]
[28.6084]
```
  end
  if State.foo then
    State.foo = nil
```