akkartik/pensieve.love - Change T2GN62QE2TB76IJYJ4HNR2Z4CP7KB7GOZ5THDZ5RGMJBSAD72MCQC

get rid of bring_cursor_column_on_screen entirely

It's just a footgun. Any time you call it you risk the cursor pane being out of viewport. bring_cursor_of_cursor_pane_in_view is always safe and always a safe replacement.

Looks like the timeline was

On 2022-08-02 I introduced bring_cursor_column_on_screen()
On 2022-08-11 I introduced bring_cursor_of_cursor_pane_in_view()

And I didn't notice that the latter obviates the former. Or perhaps I thought the former was more efficient in some situations, and didn't notice that it can put us in an invalid state.

Created by akkartik on November 2, 2024

T2GN62QE2TB76IJYJ4HNR2Z4CP7KB7GOZ5THDZ5RGMJBSAD72MCQC

Dependencies

In channels

main

Change contents

Deletion in commands.lua at line 628 [7.39]
B:BD[5.811] → [6.48:82]
```
  bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 656 [7.39]
B:BD[8.96] → [2.18:52]
```
  bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 742 [7.39]
B:BD[4.525] → [4.525:559]
```
  bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1059 [7.39]
B:BD[9.1054] → [9.1054:1090]
```
    bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1367 [7.39]
B:BD[10.260] → [11.137:171]
```
  bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1450 [7.39]
B:BD[3.480] → [3.480:516]
```
    bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1459 [7.39]
B:BD[3.1047] → [3.1047:1083]
```
    bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1490 [7.39]
B:BD[12.1244] → [12.1244:1278]
```
  bring_cursor_column_on_screen()
```
Deletion in commands.lua at line 1632 [7.39]
B:BD[11.335] → [11.335:369]
```
  bring_cursor_column_on_screen()
```

Deletion in commands.lua at line 1635 [7.39]

B:BD[13.993] → [11.370:458]

B:BD[11.458] → [4.625:745]

∅:D[4.745] → [11.547:706]

B:BD[11.547] → [11.547:706]

B:BD[11.706] → [14.132:143]

function bring_cursor_column_on_screen()
  local col_sx = left_edge_sx(Cursor_pane.col)
  if col_sx < Display_settings.x or col_sx > Display_settings.x + App.screen.width - Display_settings.column_width then
    Display_settings.x = math.max(0, col_sx + Display_settings.column_width + Margin_right + Padding_horizontal - App.screen.width)
    Display_settings.y = 0
  end
end

get rid of bring_cursor_column_on_screen entirely

Dependencies

In channels

Change contents

Deletion in commands.lua at line 628 [7.39]

Deletion in commands.lua at line 656 [7.39]

Deletion in commands.lua at line 742 [7.39]

Deletion in commands.lua at line 1059 [7.39]

Deletion in commands.lua at line 1367 [7.39]

Deletion in commands.lua at line 1450 [7.39]

Deletion in commands.lua at line 1459 [7.39]

Deletion in commands.lua at line 1490 [7.39]

Deletion in commands.lua at line 1632 [7.39]

Deletion in commands.lua at line 1635 [7.39]