akkartik/pensieve.love - Change V4ZZDSYWKYREINXLP6NZ4O2JK6J6FEWIKA7E22FUO7TTJAXGKPOAC

new assertion

If cursor was on screen for some editable pane, and we press a key, cursor should still be on screen after.

This compensates for the loss of the previous assertion. It isn't actually always true, however. Lots of crashes. But this is the world we want to get to.

Created by Kartik K. Agaram on July 23, 2022

V4ZZDSYWKYREINXLP6NZ4O2JK6J6FEWIKA7E22FUO7TTJAXGKPOAC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 247 [4.2]
[2.2031]
[3.5876]
```
          pane.cursor_y = false
```

Insertion in main.lua at line 251 [4.2]

[5.453]

            if pane.show_cursor and Surface.cursor_on_screen_check then
              print(('screen top is at %d,%d'):format(pane.screen_top1.line, pane.screen_top1.pos))
              print(('cursor is at %d,%d; y %d'):format(pane.cursor1.line, pane.cursor1.pos, pane.cursor_y))
              assert(pane.cursor_y)
              Surface.cursor_on_screen_check = false
            end

Insertion in main.lua at line 626 [4.2]

[6.2136]

[7.374]

    Surface.cursor_on_screen_check = true  -- cursor was on screen before keystroke, so it should remain on screen after