akkartik/pensieve.love - Change WNILGROUH2LQ7GFGGWCHIE4YUWBQNU6QQETTL7UHGK3P5P7SEWCQC

non-unique support in 'rename link'

I'm seeing some strange errors in creating errors, like Cache['errors'] is sometimes going to nil.

Created by Kartik K. Agaram on October 29, 2022

WNILGROUH2LQ7GFGGWCHIE4YUWBQNU6QQETTL7UHGK3P5P7SEWCQC

Dependencies

In channels

main

Change contents

Insertion in commands.lua at line 451 [4.39]

[3.109]

  print('about to run command; errors:', Cache['errors'])

Insertion in commands.lua at line 1137 [4.39]

[5.487]

function remove_edge(src, rel, target)
  if array.find(Non_unique_edges, rel) then
    local arr = Cache[src].links[rel]
    assert(arr)
    assert(type(arr) == 'table')
    local pos = array.find(arr, target)
    assert(pos)
    table.remove(array, pos)
  else
    assert(Cache[src].links[rel] == target)
    Cache[src].links[rel] = nil
  end
end

Insertion in commands.lua at line 1163 [4.39]

[6.2791]

[5.829]

    return
  end
  if array.find(Non_unique_edges, from) then
    add_error(('%s is non-unique; giving up'):format(from))

Replacement in commands.lua at line 1170 [4.39]
B:BD[5.899] → [2.2289:2311]
∅:D[2.2311] → [5.899:934]
B:BD[5.899] → [5.899:934]
```
  -- TODO: non-unique
  if Cache[pane.id].links[to] then
```
[5.899]
[6.2792]
```
  if Cache[pane.id].links[to] and not array.find(Non_unique_edges, to) then
```
Replacement in commands.lua at line 1174 [4.39]
B:BD[5.1011] → [2.2312:2334]
```
  -- TODO: non-unique
```
[5.1011]
[5.1011]
```
  -- forwards direction
```

Replacement in commands.lua at line 1176 [4.39]

B:BD[5.1055] → [5.1055:1185]

  local from_opposite = Opposite[from]
  Cache[pane.id].links[to] = Cache[pane.id].links[from]
  Cache[pane.id].links[from] = nil

[5.1055]

[5.1185]

  remove_edge(pane.id, from, target)
  add_edge(pane.id, to, target)

Replacement in commands.lua at line 1179 [4.39]

B:BD[5.1226] → [2.2335:2359]

∅:D[2.2359] → [5.1226:1275]

B:BD[5.1226] → [5.1226:1275]

B:BD[5.1275] → [6.2857:2942]

∅:D[6.2942] → [5.1356:1508]

B:BD[5.1356] → [5.1356:1508]

    -- TODO: non-unique
    if Cache[target.id].links[Opposite[to]] then
      add_error(('target %s already has a %s note'):format(target.id, Opposite[to]))
      return
    end
    Cache[target.id].links[Opposite[to]] = Cache[target.id].links[Opposite[from]]
    Cache[target.id].links[Opposite[from]] = nil

[5.1226]

[5.1508]

    remove_edge(target, Opposite[from], pane.id)
    add_edge(target, Opposite[to], pane.id)