akkartik/pensieve.love - Change WUJMPZPGPNVLBHEBVYTLSYWFOPEYVQJOPK45RFD576HTLG3NFCTAC

bugfix: load settings based on commandline args

This was a pretty serious, almost-catastrophic[1] incident. I lost 160+ columns the first time I ran with a commandline arg (after a long time).

The root cause: I've been conflating globals Directory and Settings_file in my mind, and as a result I forgot about the existence of Settings_file altogether. Settings_file is the root variable. Everything else is dependent on it getting initialized right.

Process improvements:

start backing up pensieve.love settings
go over initialization manual tests any time I reorganize global variables. This whole issue began when I extracted run.lua out of main.lua.

[1] Not actually catastrophic because I didn't lose any actual notes.

Created by Kartik K. Agaram on September 10, 2022

WUJMPZPGPNVLBHEBVYTLSYWFOPEYVQJOPK45RFD576HTLG3NFCTAC

Dependencies

In channels

main

Change contents

Deletion in run.lua at line 112 [6.178044]
B:BD[5.8023] → [5.8023:8050]
```
  Settings_file = 'config'
```
Deletion in run.lua at line 136 [6.178044]
B:BD[5.8362] → [5.8362:8400]
```
    Settings_file = 'config.'..arg[1]
```
Replacement in run.lua at line 142 [6.178044]
B:BD[5.8584] → [5.8584:8633]
```
  if love.filesystem.getInfo(Settings_file) then
```
[5.8584]
[5.8633]
```
  if Settings.width then
```

Deletion in run.lua at line 166 [6.178044]

B:BD[5.9169] → [5.9169:9237]

  local settings = json.decode(love.filesystem.read(Settings_file))

Replacement in run.lua at line 174 [6.178044]

B:BD[6.179859] → [5.9326:9398]

  App.screen.width, App.screen.height = settings.width, settings.height

[6.179859]

[6.179931]

  App.screen.width, App.screen.height = Settings.width, Settings.height

Replacement in run.lua at line 176 [6.178044]

B:BD[6.180008] → [5.9399:9509]

  love.window.setPosition(settings.x, settings.y, settings.displayindex)
  Font_height = settings.font_height

[6.180008]

[5.9509]

  love.window.setPosition(Settings.x, Settings.y, Settings.displayindex)
  Font_height = Settings.font_height

Replacement in run.lua at line 181 [6.178044]

B:BD[5.9662] → [5.9662:9769]

  Display_settings.column_width = settings.column_width
  for _,column_name in ipairs(settings.columns) do

[5.9662]

[5.9769]

  Display_settings.column_width = Settings.column_width
  for _,column_name in ipairs(Settings.columns) do

Replacement in run.lua at line 185 [6.178044]

B:BD[5.9806] → [5.9806:9970]

  Cursor_pane.col = settings.cursor_col
  Cursor_pane.row = settings.cursor_row
  Display_settings.x = settings.surface_x
  Display_settings.y = settings.surface_y

[5.9806]

[6.180297]

  Cursor_pane.col = Settings.cursor_col
  Cursor_pane.row = Settings.cursor_row
  Display_settings.x = Settings.surface_x
  Display_settings.y = Settings.surface_y

Replacement in run.lua at line 621 [6.178044]
∅:D[4.41] → [7.17:17]
B:BD[5.24421] → [7.17:17]
∅:D[7.17] → [8.15:65]
B:BD[6.182517] → [8.15:65]
```
  if Settings == nil then
    Settings = {}
  end
```
[4.41]
[9.89]
```
  assert(Settings)
```

Replacement in main.lua at line 35 [10.2]

B:BD[5.60613] → [5.60613:60775]

function App.load()
  if love.filesystem.getInfo('config') then
    Settings = json.decode(love.filesystem.read('config'))
    Current_app = Settings.current_app

[5.60613]

[5.60775]

function App.load(arg)
  -- the bootstrap for everything else
  Settings_file = 'config'
  assert(#arg <= 1)
  if #arg == 1 then
    Settings_file = 'config.'..arg[1]
  end
  if love.filesystem.getInfo(Settings_file) then
    Settings = json.decode(love.filesystem.read(Settings_file))
  else
    Settings = {current_app='run'}

Insertion in main.lua at line 48 [10.2]
[5.60781]
[11.2643]
```
  Current_app = Settings.current_app
```

Replacement in main.lua at line 188 [10.2]

B:BD[6.189395] → [6.189395:189454]

    love.filesystem.write('config', json.encode(Settings))

[6.189395]

[6.189454]

    love.filesystem.write(Settings_file, json.encode(Settings))

Replacement in main.lua at line 257 [10.2]
B:BD[6.191313] → [3.18:44]
∅:D[3.44] → [12.18:39]
B:BD[6.191313] → [12.18:39]
B:BD[12.39] → [3.45:85]
∅:D[3.85] → [12.85:93]
B:BD[12.85] → [12.85:93]
```
    local source_settings
    if Settings then
      source_settings = Settings.source
    end
```
[6.191313]
[4.76]
```
    local source_settings = Settings.source
```

Replacement in main.lua at line 264 [10.2]

B:BD[6.191510] → [6.191510:191567]

  love.filesystem.write('config', json.encode(Settings))

[6.191510]

[6.191567]

  love.filesystem.write(Settings_file, json.encode(Settings))

Replacement in app.lua at line 136 [13.2]

B:BD[6.210262] → [6.210262:210275]

  App.load()

[6.210262]

[6.210275]

  local parsed_arg = love.arg.parseGameArguments(arg)
  App.load(parsed_arg, arg)

Replacement in app.lua at line 141 [13.2]
B:BD[6.210342] → [6.210342:210398]
```
  App.initialize(love.arg.parseGameArguments(arg), arg)
```
[6.210342]
[6.210398]
```
  App.initialize(parsed_arg, arg)
```

bugfix: load settings based on commandline args

Dependencies

In channels

Change contents

Deletion in run.lua at line 112 [6.178044]

Deletion in run.lua at line 136 [6.178044]

Replacement in run.lua at line 142 [6.178044]

Deletion in run.lua at line 166 [6.178044]

Replacement in run.lua at line 174 [6.178044]

Replacement in run.lua at line 176 [6.178044]

Replacement in run.lua at line 181 [6.178044]

Replacement in run.lua at line 185 [6.178044]

Replacement in run.lua at line 621 [6.178044]

Replacement in main.lua at line 35 [10.2]

Insertion in main.lua at line 48 [10.2]

Replacement in main.lua at line 188 [10.2]

Replacement in main.lua at line 257 [10.2]

Replacement in main.lua at line 264 [10.2]

Replacement in app.lua at line 136 [13.2]

Replacement in app.lua at line 141 [13.2]