akkartik/etch.love - Change AVLAYODPMKCDBUFJSTGNUXIK74V3NDCBH55DBBFTNVBMFY6I7BCAC

much simpler

We just need to ensure textinput events never make use of selection state.

All tests are passing, but I'm aware of a couple of issues. But now we can keep all the special cases in one place.

Created by Kartik K. Agaram on June 20, 2022

AVLAYODPMKCDBUFJSTGNUXIK74V3NDCBH55DBBFTNVBMFY6I7BCAC

Dependencies

In channels

main

Change contents

Insertion in text.lua at line 140 [7.1]

[5.1568]

[6.1]

-- don't depend on state of Selection1; use keychord_pressed for that

Deletion in text.lua at line 146 [7.1]
∅:D[4.98] → [8.1174:1234]
B:BD[9.74] → [8.1174:1234]
```
  if Selection1.line then
    Text.delete_selection()
  end
```
Deletion in text.lua at line 178 [7.1]
B:BD[8.1504] → [2.748:768]
```
    Selection1 = {}
```
Deletion in text.lua at line 189 [7.1]
B:BD[8.1617] → [2.769:789]
```
    Selection1 = {}
```
Deletion in text.lua at line 193 [7.1]
B:BD[10.67] → [2.790:812]
```
      Selection1 = {}
```
Deletion in text.lua at line 231 [7.1]
B:BD[8.1843] → [2.813:833]
```
    Selection1 = {}
```
Deletion in text.lua at line 235 [7.1]
B:BD[10.111] → [2.834:856]
```
      Selection1 = {}
```
Deletion in text.lua at line 267 [7.1]
B:BD[8.2102] → [2.857:877]
```
    Selection1 = {}
```
Deletion in text.lua at line 270 [7.1]
B:BD[11.293] → [3.3:23]
```
    Selection1 = {}
```
Deletion in text.lua at line 272 [7.1]
∅:D[3.41] → [12.24:44]
B:BD[11.324] → [12.24:44]
```
    Selection1 = {}
```
Deletion in text.lua at line 285 [7.1]
B:BD[13.22] → [3.42:62]
```
    Selection1 = {}
```
Deletion in text.lua at line 287 [7.1]
∅:D[3.85] → [12.66:86]
B:BD[11.794] → [12.66:86]
```
    Selection1 = {}
```
Deletion in text.lua at line 299 [7.1]
B:BD[11.1152] → [12.108:128]
```
    Selection1 = {}
```
Deletion in text.lua at line 301 [7.1]
B:BD[11.1209] → [3.116:136]
```
    Selection1 = {}
```
Deletion in text.lua at line 313 [7.1]
∅:D[3.151] → [12.129:149]
B:BD[14.3984] → [12.129:149]
```
    Selection1 = {}
```
Deletion in text.lua at line 315 [7.1]
B:BD[15.9989] → [3.152:172]
```
    Selection1 = {}
```
Deletion in text.lua at line 327 [7.1]
∅:D[3.191] → [12.171:191]
B:BD[16.33] → [12.171:191]
```
    Selection1 = {}
```
Deletion in text.lua at line 329 [7.1]
B:BD[15.10401] → [3.192:212]
```
    Selection1 = {}
```

Insertion in text.lua at line 340 [7.1]

[17.188]

  if Selection1.line and not App.shift_down() then
    Text.delete_selection()
  end

Insertion in main.lua at line 394 [19.2]

[6.135]

[18.1486]

-- don't depend on state of Selection1; use keychord_pressed for that

Deletion in main.lua at line 411 [19.2]
B:BD[10.649] → [2.883:940]
```
  if not App.shift_down() then
    Selection1 = {}
  end
```
Deletion in main.lua at line 442 [19.2]
B:BD[20.3819] → [2.941:961]
```
    Selection1 = {}
```
Deletion in main.lua at line 445 [19.2]
B:BD[21.4470] → [2.962:982]
```
    Selection1 = {}
```
Deletion in main.lua at line 448 [19.2]
B:BD[21.4615] → [2.983:1003]
```
    Selection1 = {}
```
Deletion in main.lua at line 451 [19.2]
B:BD[21.4795] → [2.1004:1024]
```
    Selection1 = {}
```
Deletion in main.lua at line 463 [19.2]
B:BD[22.359] → [2.1025:1045]
```
    Selection1 = {}
```
Deletion in main.lua at line 475 [19.2]
B:BD[23.46] → [2.1046:1066]
```
    Selection1 = {}
```
Deletion in main.lua at line 482 [19.2]
B:BD[23.173] → [2.1067:1087]
```
    Selection1 = {}
```
Deletion in main.lua at line 489 [19.2]
B:BD[10.716] → [2.1088:1108]
```
    Selection1 = {}
```
Deletion in main.lua at line 510 [19.2]
B:BD[23.1959] → [2.1109:1129]
```
    Selection1 = {}
```

Insertion in main.lua at line 553 [19.2]

[14.5055]

[24.350]

  end
  if not App.shift_down() then
    Selection1 = {}

much simpler

Dependencies

In channels

Change contents

Insertion in text.lua at line 140 [7.1]

Deletion in text.lua at line 146 [7.1]

Deletion in text.lua at line 178 [7.1]

Deletion in text.lua at line 189 [7.1]

Deletion in text.lua at line 193 [7.1]

Deletion in text.lua at line 231 [7.1]

Deletion in text.lua at line 235 [7.1]

Deletion in text.lua at line 267 [7.1]

Deletion in text.lua at line 270 [7.1]

Deletion in text.lua at line 272 [7.1]

Deletion in text.lua at line 285 [7.1]

Deletion in text.lua at line 287 [7.1]

Deletion in text.lua at line 299 [7.1]

Deletion in text.lua at line 301 [7.1]

Deletion in text.lua at line 313 [7.1]

Deletion in text.lua at line 315 [7.1]

Deletion in text.lua at line 327 [7.1]

Deletion in text.lua at line 329 [7.1]

Insertion in text.lua at line 340 [7.1]

Insertion in main.lua at line 394 [19.2]

Deletion in main.lua at line 411 [19.2]

Deletion in main.lua at line 442 [19.2]

Deletion in main.lua at line 445 [19.2]

Deletion in main.lua at line 448 [19.2]

Deletion in main.lua at line 451 [19.2]

Deletion in main.lua at line 463 [19.2]

Deletion in main.lua at line 475 [19.2]

Deletion in main.lua at line 482 [19.2]

Deletion in main.lua at line 489 [19.2]

Deletion in main.lua at line 510 [19.2]

Insertion in main.lua at line 553 [19.2]