akkartik/pong.love - Change DZMHZBYSL73BWS7OX3BGOYCITVIGFKNLUXNQUAGKXMGXDE4ZRL6QC

change the focus model

Until now we had a strict sense of which side has the focus. Clicking on the other side switched focus, and only subsequent clicks actually made it to that side.

I think it's a little faster to transmit the first click to that side – as long as you provide visual feedback on what it's going to do, particularly on the Log-browser side.

One bugfix that came up in this context: clicks on the log browser side can scroll the source side, in which case we should clear line_cache.starty. Otherwise future clicks on the source side can go to the wrong line.

Created by Kartik K. Agaram on September 3, 2022

DZMHZBYSL73BWS7OX3BGOYCITVIGFKNLUXNQUAGKXMGXDE4ZRL6QC

Dependencies

In channels

main

Change contents

Replacement in source.lua at line 188 [4.5]
B:BD[4.7507] → [5.464:490]
```
  if Focus == 'edit' then
```
[4.7194]
[4.7538]
```
  if App.mouse_x() < Editor_state.right then
```
Replacement in source.lua at line 190 [4.5]
B:BD[4.7572] → [4.7572:7579]
```
  else
```
[4.7572]
[4.7579]
```
  elseif Show_log_browser_side then
```
Deletion in source.lua at line 237 [4.5]
∅:D[5.677] → [4.8804:8871]
B:BD[4.8804] → [4.8804:8871]
```
    else
      edit.mouse_pressed(Editor_state, x,y, mouse_button)
```

Insertion in source.lua at line 238 [4.5]

[4.8879]

[3.242]

    edit.mouse_pressed(Editor_state, x,y, mouse_button)

Deletion in source.lua at line 243 [4.5]

B:BD[4.9080] → [4.9080:9166]

    else
      return log_browser.mouse_pressed(Log_browser_state, x,y, mouse_button)

Insertion in source.lua at line 244 [4.5]

[4.9174]

    log_browser.mouse_pressed(Log_browser_state, x,y, mouse_button)
    for _,line_cache in ipairs(Editor_state.line_cache) do line_cache.starty = nil end  -- just in case we scroll

Insertion in main.lua at line 204 [6.2]
[4.15373]
[4.15373]
```
--?   print('mouse press', x,y)
```

Replacement in log_browser.lua at line 119 [8.5]

B:BD[7.3122] → [4.17036:17108]

      if Focus == 'log_browser' and line_index == mouse_line_index then

[7.3122]

[9.2181]

      if App.mouse_x() > Log_browser_state.left and line_index == mouse_line_index then

Insertion in edit.lua at line 140 [11.413]

[10.569]

[2.242]

--?       print(x,y, 'setting cursor:', line_index, pos, posB)

change the focus model

Dependencies

In channels

Change contents

Replacement in source.lua at line 188 [4.5]

Replacement in source.lua at line 190 [4.5]

Deletion in source.lua at line 237 [4.5]

Insertion in source.lua at line 238 [4.5]

Deletion in source.lua at line 243 [4.5]

Insertion in source.lua at line 244 [4.5]

Insertion in main.lua at line 204 [6.2]

Replacement in log_browser.lua at line 119 [8.5]

Insertion in edit.lua at line 140 [11.413]