akkartik/pong.love - Change Z2VZTIXYXUZXF4ZUVG54IOIRSMBGUZJZ2RTBPYOJC7NWBOUFU6YAC

redo version checks

This is still ugly, but hopefully easier to follow.

Created by akkartik on December 6, 2023

Z2VZTIXYXUZXF4ZUVG54IOIRSMBGUZJZ2RTBPYOJC7NWBOUFU6YAC

Dependencies

In channels

main

Change contents

Insertion in reference.md at line 14 [4.17]

[4.509]

* `Version` -- the running version of LÖVE as a string, e.g. '11.4'.
* `Major_version` -- just the part before the period as an int, e.g. 11.

Replacement in main.lua at line 75 [9.2]

B:BD[8.31] → [8.31:198]

B:BD[8.198] → [5.20:112]

∅:D[5.112] → [8.282:776]

B:BD[8.282] → [8.282:776]

∅:D[10.115] → [11.82:88]

∅:D[8.776] → [11.82:88]

∅:D[12.186724] → [11.82:88]

B:BD[11.82] → [11.82:88]

B:BD[11.88] → [12.186725:186729]

function App.version_check()
  -- available modes: run, error
  Error_message = nil
  Error_count = 0
  -- we'll reuse error mode on load for an initial version check
  local supported_versions = {'11.5', '11.4', '12.0'}  -- put the recommended version first
  local minor_version
  Major_version, minor_version = love.getVersion()
  Version = Major_version..'.'..minor_version
  if array.find(supported_versions, Version) == nil then
    Current_app = 'error'
    Error_message = ("This app doesn't support version %s; please use version %s. Press any key to try it with this version anyway."):format(Version, supported_versions[1])
    print(Error_message)
    -- continue initializing everything; hopefully we won't have errors during initialization
  end
end

[8.31]

[13.8]

function App.initialize_globals()
  Supported_versions = {'11.5', '11.4', '12.0'}  -- put the recommended version first
  check_love_version_for_tests()

Deletion in main.lua at line 79 [9.2]
B:BD[13.9] → [12.186730:186764]
```
function App.initialize_globals()
```

Insertion in main.lua at line 92 [9.2]

[2.414]

[14.1047]

end
function check_love_version_for_tests()
  if array.find(Supported_versions, Version) == nil then
    Unsupported_version = true
    -- warning to include in an error message if any tests failed
    Warning_before_tests = ("This app hasn't been tested with LÖVE version %s."):format(Version)
  end

Insertion in main.lua at line 102 [9.2]

[14.1052]

[12.187114]

function App.love_version_check()
  if Unsupported_version then
    Current_app = 'error'
    Error_message = ("This app hasn't been tested with LÖVE version %s; please switch to version %s if you run into issues. Press any key to continue."):format(Version, Supported_versions[1])
    print(Error_message)
    -- continue initializing everything; hopefully we won't have errors during initialization
  end
end

Replacement in app.lua at line 11 [15.2]
B:BD[15.54] → [7.0:22]
```
  App.version_check()
```
[15.54]
[12.209765]
```
  Version, Major_version = App.love_version()
```

Replacement in app.lua at line 15 [15.2]

B:BD[12.209821] → [6.0:22]

  App.version_check()

[12.209821]

[16.258]

  App.love_version_check()  -- hack: we want to run this just the first time and not every time we bounce between 'run' and 'source'

Insertion in app.lua at line 89 [15.2]

[17.5849]

[12.209822]

function App.love_version()
  local major_version, minor_version = love.getVersion()
  local version = major_version..'.'..minor_version
  return version, major_version
end

Replacement in app.lua at line 112 [15.2]

B:BD[18.60589] → [3.33:131]

    error(('There were %d test failures:\n\n%s'):format(#Test_errors, table.concat(Test_errors)))

[18.60589]

[18.60659]

    local error_message = ''
    if Warning_before_tests then
      error_message = Warning_before_tests..'\n\n'
    end
    error_message = error_message .. ('There were %d test failures:\n%s'):format(#Test_errors, table.concat(Test_errors))
    error(error_message)

Replacement in Manual_tests.md at line 20 [20.1]

B:BD[19.156] → [19.156:295]

  - run with an unsupported version. Error message pops up and waits for a key. The app attempts to continue, and doesn't receive the key.

[19.156]

[7.23]

  - run with an untested version. Error message pops up and waits for a key. The app attempts to continue, and doesn't receive the key.

Replacement in Manual_tests.md at line 33 [20.1]

B:BD[12.211526] → [6.23:238]

* run with an unsupported version. Error message pops up and waits for a key. The app attempts to continue, and doesn't receive the key. Press ctrl+e to edit source. Source editor opens up without checking version.

[12.211526]

* run with an untested version. Error message pops up. Press a key. Text editor comes up, and doesn't receive the key. Press ctrl+e. Source editor opens up. Press ctrl+e. Text editor returns.
* create a couple of spuriously failing tests. Run with an untested version. Error message includes message about untested version.