akkartik/pothi.love - Change 7JZFRO5FU57TYQOBZXVLISILKAYDQYTTGZXCPGOZNW3GAU7INQBQC

all manual tests seem to be passing now

scenario: position a tall node with its top within the viewport, and extending past bottom of viewport press page-down

Before this commit we were seeing strange patches of empty space above the old top.

Created by Kartik K. Agaram on October 26, 2023

7JZFRO5FU57TYQOBZXVLISILKAYDQYTTGZXCPGOZNW3GAU7INQBQC

Dependencies

In channels

main

Change contents

Insertion in 0030-update_editor_box at line 8 [5.26]

[2.213]

[4.32]

--? 	print('update', node.y, Viewport.y, 'spx', node.editor.screen_top1.line, node.editor.top, 'vpx')

Insertion in 0030-update_editor_box at line 11 [5.26]
[4.108]
[5.238]
```
--? 			print('modifying screen_top to 1')
```
Insertion in 0030-update_editor_box at line 17 [5.26]
[4.152]
[4.152]
```
--? 		print('<=', node, skip_updating_screen_top_for)
```

Insertion in 0030-update_editor_box at line 20 [5.26]

[6.312]

[5.309]

			print('modified screen_top to', node.editor.screen_top1.line, 'at', node.editor.top, 'vpx')
		else
			-- adjust editor to start rendering near top of viewport
--? 			print(Viewport.y)
			node.editor.top = Viewport.y%node.editor.line_height
			if node.editor.top > 0 then node.editor.top = node.editor.top - node.editor.line_height end
--? 			print('top', node.editor.top)

Insertion in 0023-on.keychord_press at line 22 [7.26]

[7.483]

--? 		print('edit', old_top.line, '=>', Cursor_node.editor.screen_top1.line)

Insertion in 0023-on.keychord_press at line 24 [7.26]

[7.541]

[3.295]

--? 			print('modifying Viewport', Viewport.y, 'based on', Cursor_node.y, Cursor_node.editor.screen_top1.line, Cursor_node.editor.line_height)

Insertion in 0023-on.keychord_press at line 26 [7.26]
[3.406]
[8.39]
```
--? 			print('modified Viewport', Viewport.y)
```