akkartik/pothi.love - Change 7KX3WBFEXMIHNKWNF4NUOBW5HO3PEL3ZEFFMTAXFOQG6V7BYXZ3AC

make moving a definition more polished+performant

This is a long-standing problem:

each definition requires an edit buffer and some decoration (the rectangle for the background color)
while the mouse is down during a move it's nice to see the decorations change
but to change decorations we have to go all the way back to A(), which is very slow if there's lots of definitions on the surface

My compromise until now was to just perform B(), not A(). This tore the background rect away from the editor buffer during a move, which was ugly. You also wouldn't get any feedback at all if you tried to move a buffer without any text.

New solution: create a variant of A called A1 that only does the work of A for a single key (index) in Definitions.

This requires tracking for every shape we render in Surface, which key in Definitions it is part of. That way we can selectively delete just shapes belonging to a single key.

Caveat: key is a scalar, so this approach can't handle any nesting, only a flat array of objects. But that's good enough for both driver.love and this app.

Created by Kartik K. Agaram on April 18, 2023

7KX3WBFEXMIHNKWNF4NUOBW5HO3PEL3ZEFFMTAXFOQG6V7BYXZ3AC

Dependencies

In channels

main

Change contents

File addition: 0106-A1 (----------)

[3.2]

A1 = function(key, preserve_screen_top_of_cursor_node)
	-- like A, but updating a single node
	-- this only works because Nodes is a flat array; we don't support row/col types here yet
	-- delete previously added shapes for this node:
	for i=#Surface,1,-1 do
		local x = Surface[i]
		if x.key == key then
			table.remove(Surface, i)
		end
	end	
	local node = Definitions[key]
	compute_layout(node, node.x,node.y, Surface, preserve_screen_top_of_cursor_node)
	-- continue the pipeline
	B(preserve_screen_top_of_cursor_node)
end

Replacement in 0102-A at line 6 [2.2646]

B:BD[2.2871] → [2.2871:2908]

	for _,node in pairs(Definitions) do

[2.2871]

[2.2908]

	for key,node in pairs(Definitions) do
		node.key = key

Replacement in 0087-on.update at line 22 [2.10030]
B:BD[2.10517] → [2.10517:10523]
```
		B()
```
[2.10517]
[2.10523]
```
		A1(Move.node.key)
```
Replacement in 0087-on.update at line 25 [2.10030]
B:BD[2.10537] → [2.10537:10541]
```
end
```
[2.10537]
```
end
```
Replacement in 0062-on.mouse_release at line 13 [4.1417]
B:BD[4.1615] → [4.1615:1618]
```
end
```
[4.1615]
```
end
```

Replacement in 0006-compute_layout at line 11 [5.4307]

B:BD[5.4701] → [5.4701:4799]

			node_to_render = {type='rectangle', r=node.bg.r, g=node.bg.g, b=node.bg.b, x=node.x, y=node.y}

[5.4701]

[5.4799]

			node_to_render = {type='rectangle', r=node.bg.r, g=node.bg.g, b=node.bg.b, x=node.x, y=node.y, key=node.key}