akkartik/pothi.love - Change A6HLSJEOJJGNTITANAOHC7PW7IKJHUNHWRYL7LJKRFUZRLVTHGLAC

eliminate Global_viewport global variable

Created by akkartik on April 17, 2025

A6HLSJEOJJGNTITANAOHC7PW7IKJHUNHWRYL7LJKRFUZRLVTHGLAC

Dependencies

In channels

main

Change contents

File deletion: 0108-Global_viewport
BF:BFD[4.2] → [5.752:796]
BF:BFD[5.796] → [5.729:729]
∅:D[6.458] → [5.730:751]
B:BD[5.729] → [5.730:751]
B:BD[5.729] → [6.347:458]
```
Global_viewport = nil
-- only used during zoom animations
-- contains x,y in surface coordinates and zoom as a fraction from 0 to 1.
```

Replacement in 0141-animate_to at line 1 [7.1]

B:BD[7.1] → [3.32:75]

animate_to = function(dest, global_bounds)

[7.1]

[7.30]

animate_to = function(dest, global_viewport, globalw, globalh)

Replacement in 0141-animate_to at line 33 [7.1]

B:BD[7.850] → [7.850:948]

			(Viewport.x-Global_viewport.x)*Viewport.zoom,
			(Viewport.y-Global_viewport.y)*Viewport.zoom,

[7.850]

[7.948]

			(Viewport.x-global_viewport.x)*Viewport.zoom,
			(Viewport.y-global_viewport.y)*Viewport.zoom,

Replacement in 0141-animate_to at line 37 [7.1]

B:BD[7.991] → [3.76:144]

			global_bounds.w*Viewport.zoom,
			global_bounds.h*Viewport.zoom)

[7.991]

[7.1059]

			globalw*Viewport.zoom,
			globalh*Viewport.zoom)

Replacement in 0109-initialize_global_viewport at line 9 [5.30]
B:BD[5.401] → [5.401:421]
```
	local zoom, cw, ch
```
[5.401]
[5.421]
```
	local zoom, globalw, globalh
```

Replacement in 0109-initialize_global_viewport at line 12 [5.30]

B:BD[5.459] → [5.459:521]

		cw = maxx-minx
		ch = cw*App.screen.height/App.screen.width

[5.459]

[5.521]

		globalw = maxx-minx
		globalh = globalw*App.screen.height/App.screen.width

Replacement in 0109-initialize_global_viewport at line 16 [5.30]

B:BD[5.542] → [5.542:604]

		ch = maxy-miny
		cw = ch*App.screen.width/App.screen.height

[5.542]

[5.604]

		globalh = maxy-miny
		globalw = globalh*App.screen.width/App.screen.height

Replacement in 0109-initialize_global_viewport at line 19 [5.30]

B:BD[5.609] → [6.268:315]

∅:D[6.345] → [8.0:15]

B:BD[5.668] → [8.0:15]

	Global_viewport = {x=minx, y=miny, zoom=zoom}
	return cw, ch

[5.609]

[5.668]

	local global_viewport = {x=minx, y=miny, zoom=zoom}
	return global_viewport, globalw, globalh

Replacement in 0103-survey_animation at line 4 [9.4016]

B:BD[9.4106] → [2.63:108]

∅:D[2.108] → [10.63:88]

B:BD[9.4703] → [10.63:88]

	local cw, ch = initialize_global_viewport()
	snapshot_canvas(cw, ch)

[9.4106]

[9.4826]

	local global_viewport, globalw, globalh = initialize_global_viewport()
	snapshot_canvas(global_viewport, globalw, globalh)

Replacement in 0103-survey_animation at line 10 [9.4016]

B:BD[11.233] → [11.233:327]

	print('start animating towards', Global_viewport.x, Global_viewport.y, Global_viewport.zoom)

[11.233]

[7.1286]

	print('start animating towards', global_viewport.x, global_viewport.y, global_viewport.zoom)

Replacement in 0103-survey_animation at line 12 [9.4016]

B:BD[7.1336] → [3.177:264]

	animate_to(Global_viewport, {w=cw, h=ch})
	animate_to(initial_viewport, {w=cw, h=ch})

[7.1336]

[7.1395]

	animate_to(global_viewport, global_viewport, globalw, globalh)
	animate_to(initial_viewport, global_viewport, globalw, globalh)

Deletion in 0103-survey_animation at line 16 [9.4016]
B:BD[7.1494] → [7.1494:1517]
```
	Global_viewport = nil
```

Replacement in 0090-undo_zoom_out at line 2 [9.12364]

B:BD[9.12392] → [8.16:106]

B:BD[8.106] → [3.278:329]

	local globalw, globalh = initialize_global_viewport()
	snapshot_canvas(globalw, globalh)
	animate_to(Save_viewport, {w=globalw, h=globalh})

[9.12392]

[7.1563]

	local global_viewport, globalw, globalh = initialize_global_viewport()
	snapshot_canvas(global_viewport, globalw, globalh)
	print('animating to', Save_viewport.x, Save_viewport.y, Save_viewport.zoom)
	animate_to(Save_viewport, global_viewport, globalw, globalh)

Deletion in 0090-undo_zoom_out at line 8 [9.12364]
B:BD[7.1669] → [7.1669:1692]
```
	Global_viewport = nil
```
Replacement in 0089-zoom_in at line 3 [9.12533]
B:BD[9.12587] → [9.12587:12633]
```
	-- precondition: Viewport == Global_viewport
```
[9.12587]
[9.12633]
```
	-- precondition: Viewport == global_viewport
```

Replacement in 0089-zoom_in at line 6 [9.12533]

B:BD[9.12733] → [8.107:197]

	local globalw, globalh = initialize_global_viewport()
	snapshot_canvas(globalw, globalh)

[9.12733]

[3.331]

	local global_viewport, globalw, globalh = initialize_global_viewport()
	snapshot_canvas(global_viewport, globalw, globalh)

Replacement in 0089-zoom_in at line 14 [9.12533]
B:BD[3.482] → [3.482:507]
```
		{w=globalw, h=globalh}
```
[3.482]
[3.507]
```
		global_viewport,
		globalw, globalh
```
Deletion in 0089-zoom_in at line 19 [9.12533]
B:BD[7.1961] → [7.1961:1984]
```
	Global_viewport = nil
```

Replacement in 0086-snapshot_canvas at line 1 [9.14387]

B:BD[9.14387] → [10.223:273]

snapshot_canvas = function(new_width, new_height)

[9.14387]

[9.14417]

snapshot_canvas = function(global_viewport, globalw, globalh)

Replacement in 0086-snapshot_canvas at line 4 [9.14387]

B:BD[12.503] → [10.274:335]

	App.screen.width, App.screen.height = new_width, new_height

[12.503]

[9.14598]

	App.screen.width, App.screen.height = globalw, globalh

Replacement in 0086-snapshot_canvas at line 6 [9.14387]
B:BD[9.14631] → [9.14631:14674]
```
	Viewport = copy_viewport(Global_viewport)
```
[9.14631]
[9.14674]
```
	Viewport = copy_viewport(global_viewport)
```

Replacement in 0085-zoom_out at line 3 [9.15067]

B:BD[9.15131] → [8.198:288]

	local globalw, globalh = initialize_global_viewport()
	snapshot_canvas(globalw, globalh)

[9.15131]

[9.15202]

print('save viewport', Save_viewport.x, Save_viewport.y, Save_viewport.zoom)
	local global_viewport, globalw, globalh = initialize_global_viewport()
	snapshot_canvas(global_viewport, globalw, globalh)

Replacement in 0085-zoom_out at line 7 [9.15067]

B:BD[9.15221] → [3.513:566]

	animate_to(Global_viewport, {w=globalw, h=globalh})

[9.15221]

[7.2021]

	animate_to(global_viewport, global_viewport, globalw, globalh)

Deletion in 0085-zoom_out at line 10 [9.15067]
B:BD[7.2122] → [7.2122:2145]
```
	Global_viewport = nil
```

eliminate Global_viewport global variable

Dependencies

In channels

Change contents

File deletion: 0108-Global_viewport

Replacement in 0141-animate_to at line 1 [7.1]

Replacement in 0141-animate_to at line 33 [7.1]

Replacement in 0141-animate_to at line 37 [7.1]

Replacement in 0109-initialize_global_viewport at line 9 [5.30]

Replacement in 0109-initialize_global_viewport at line 12 [5.30]

Replacement in 0109-initialize_global_viewport at line 16 [5.30]

Replacement in 0109-initialize_global_viewport at line 19 [5.30]

Replacement in 0103-survey_animation at line 4 [9.4016]

Replacement in 0103-survey_animation at line 10 [9.4016]

Replacement in 0103-survey_animation at line 12 [9.4016]

Deletion in 0103-survey_animation at line 16 [9.4016]

Replacement in 0090-undo_zoom_out at line 2 [9.12364]

Deletion in 0090-undo_zoom_out at line 8 [9.12364]

Replacement in 0089-zoom_in at line 3 [9.12533]

Replacement in 0089-zoom_in at line 6 [9.12533]

Replacement in 0089-zoom_in at line 14 [9.12533]

Deletion in 0089-zoom_in at line 19 [9.12533]

Replacement in 0086-snapshot_canvas at line 1 [9.14387]

Replacement in 0086-snapshot_canvas at line 4 [9.14387]

Replacement in 0086-snapshot_canvas at line 6 [9.14387]

Replacement in 0085-zoom_out at line 3 [9.15067]

Replacement in 0085-zoom_out at line 7 [9.15067]

Deletion in 0085-zoom_out at line 10 [9.15067]