akkartik/pothi.love - Change CCMG4VMKBKBL5ZCUBAVJWCBOGRHS34VB2OH2A24PHALBITX3TNBAC

click on file picker to open thread

There's one remaining issue: the DOM is changing between mouse press and mouse release, which is confusing the select handler.

Options:

some sort of hacky thing to ignore the first mouse release
put the file picker handlers on mouse release rather than mouse press

There's some precedent for the latter option even if it might get confusing in the presence of drag operations. But that seems confusing either way. Just be consistent.

Created by Kartik K. Agaram on June 22, 2023

CCMG4VMKBKBL5ZCUBAVJWCBOGRHS34VB2OH2A24PHALBITX3TNBAC

Dependencies

In channels

main

Change contents

File addition: 0132-in_rect (----------)

[3.2]

in_rect = function(rect, x,y)
	-- return true if x,y in viewport coordinates lie with rect on the surface
	if x < vx(rect.x) then return end
	if y < vy(rect.y) then return end
	if x > vx(rect.x+rect.w) then return end
	if y > vy(rect.y+rect.h) then return end
	return true
end

Replacement in 0028-A at line 6 [4.2646]
B:BD[4.2871] → [2.1429:1463]
```
	if Global_state.file_picker then
```
[4.2871]
[2.1463]
```
	if Global_state.thread == nil then
```
Replacement in 0028-A at line 8 [4.2646]
B:BD[2.1487] → [2.1487:1520]
```
	elseif Global_state.thread then
```
[2.1487]
[2.1520]
```
	else
```
Insertion in 0023-on.keychord_press at line 6 [5.26]
[2.2814]
[2.2814]
```
		A()
```

Insertion in 0006-on.mouse_press at line 6 [6.703]

[2.4528]

	-- buttons at the HUD level can use the buttons.lua abstraction

Insertion in 0006-on.mouse_press at line 10 [6.703]

[4.13289]

[2.4605]

	-- other buttons need manual handling
	if Global_state.thread == nil then
		-- we're rendering the file picker
		-- compute_layout reuses nodes and so it fills in x,y for us
		for _,button in ipairs(Global_state.file_picker) do
			if in_rect(button, x,y) then
				open_thread(button.data[1].data)
				A()
				break
			end
		end
	end