akkartik/pothi.love - Change ZHEJFKSLMORNRVOM7ZY7P4WAXIKGTQ5JVRJRWICXNXKF6HJWEFCQC

bounds when panning by keyboard

This makes the keyboard navigation feel more solid.

I'm not bothering to do the same for panning with the mouse. Mostly because I'm lazy, but also as an escape hatch in case I find myself wanting to move the top lower down the screen or something. But it'll still snap back the first time I pan using the keyboard. Let's see how much it matters.

Created by Kartik K. Agaram on June 24, 2023

ZHEJFKSLMORNRVOM7ZY7P4WAXIKGTQ5JVRJRWICXNXKF6HJWEFCQC

Dependencies

In channels

main

Change contents

File addition: 0148-compute_viewport_bounds (----------)

[3.2]

compute_viewport_bounds = function()
	local xmin, ymin, xmax, ymax
	for i,node in ipairs(Surface) do
		if node.type == 'text' or node.type == 'rows' or node.type == 'cols' then
			if xmin == nil or xmin > node.x then
				xmin = node.x
			end
			if xmax == nil or xmax < node.x+node.w then
				xmax = node.x+node.w
			end
			if ymin == nil or ymin > node.y then
				ymin = node.y
			end
			if ymax == nil or ymax < node.y + node.h then
				ymax = node.y+node.w
			end
		end
	end
	xmin, ymin = xmin-50, ymin-50
	Viewport_bounds.xmin, Viewport_bounds.xmax, Viewport_bounds.ymin, Viewport_bounds.ymax = xmin,xmax, ymin, ymax
end

File addition: 0147-Viewport_bounds (----------)
[3.2]
```
Viewport_bounds = {}
```

Insertion in 0117-open_thread at line 6 [5.1551]

[4.592]

[5.1951]

	Viewport.x, Viewport.y = Viewport_bounds.xmin, Viewport_bounds.ymin
	B()

Replacement in 0028-A at line 11 [6.2646]
∅:D[4.750] → [6.2996:3022]
∅:D[2.1613] → [6.2996:3022]
B:BD[6.2996] → [6.2996:3022]
```
	-- continue the pipeline
```
[2.1613]
[6.3022]
```
	compute_viewport_bounds()
```

Replacement in 0023-on.keychord_press at line 35 [7.26]

B:BD[2.3359] → [2.3359:3398]

			Viewport.y = Viewport.y - scale(20)

[2.3359]

[2.3398]

			Viewport.y = math.max(
				Viewport_bounds.ymin,
				Viewport.y - scale(20))

Replacement in 0023-on.keychord_press at line 40 [7.26]

B:BD[2.3435] → [2.3435:3474]

			Viewport.y = Viewport.y + scale(20)

[2.3435]

[2.3474]

			Viewport.y = math.min(
				math.max(
					Viewport_bounds.ymin,
					Viewport_bounds.ymax - App.screen.width/2/Viewport.zoom),  -- conservative; unclear why removing the '/2' makes the bottom inaccessible
				Viewport.y + scale(20))

Replacement in 0023-on.keychord_press at line 47 [7.26]

B:BD[2.3511] → [2.3511:3550]

			Viewport.x = Viewport.x - scale(50)

[2.3511]

[2.3550]

			Viewport.x = math.max(
				Viewport_bounds.xmin,
				Viewport.x - scale(50))

Replacement in 0023-on.keychord_press at line 52 [7.26]

B:BD[2.3588] → [2.3588:3825]

			Viewport.x = Viewport.x + scale(50)
			B()
		elseif chord == 'pageup' then
			Viewport.y = Viewport.y - App.screen.height/Viewport.zoom
			B()
		elseif chord == 'S-up' then
			Viewport.y = Viewport.y - App.screen.height/Viewport.zoom

[2.3588]

[2.3825]

			Viewport.x = math.min(
				math.max(Viewport_bounds.xmin, Viewport_bounds.xmax - App.screen.width/Viewport.zoom),
				Viewport.x + scale(50))

Replacement in 0023-on.keychord_press at line 56 [7.26]

B:BD[2.3832] → [2.3832:3927]

		elseif chord == 'pagedown' then
			Viewport.y = Viewport.y + App.screen.height/Viewport.zoom

[2.3832]

[2.3927]

		elseif chord == 'pageup' or chord == 'S-up' then
			Viewport.y = math.max(Viewport_bounds.ymin, Viewport.y - App.screen.height/Viewport.zoom)

Replacement in 0023-on.keychord_press at line 59 [7.26]

B:BD[2.3934] → [2.3934:4027]

		elseif chord == 'S-down' then
			Viewport.y = Viewport.y + App.screen.height/Viewport.zoom

[2.3934]

[2.4027]

		elseif chord == 'pagedown' or chord == 'S-down' then
			Viewport.y = math.min(
				math.max(
					Viewport_bounds.ymin,
					Viewport_bounds.ymax - App.screen.width/2/Viewport.zoom),  -- conservative; unclear why removing the '/2' makes the bottom inaccessible
				Viewport.y + App.screen.height/Viewport.zoom)

Replacement in 0023-on.keychord_press at line 67 [7.26]

B:BD[2.4066] → [2.4066:4126]

			Viewport.x = Viewport.x - App.screen.width/Viewport.zoom

[2.4066]

[2.4126]

			Viewport.x = math.max(Viewport_bounds.xmin, Viewport.x - App.screen.width/Viewport.zoom)

Replacement in 0023-on.keychord_press at line 70 [7.26]

B:BD[2.4166] → [2.4166:4226]

			Viewport.x = Viewport.x + App.screen.width/Viewport.zoom

[2.4166]

[2.4226]

			Viewport.x = math.min(
				math.max(
					Viewport_bounds.xmin,
					Viewport_bounds.xmax - App.screen.width/Viewport.zoom),
				Viewport.x + App.screen.width/Viewport.zoom)

Insertion in 0012-on.initialize at line 8 [9.2104]

[2.4423]

[8.253]

	Viewport.x, Viewport.y = Viewport_bounds.xmin, Viewport_bounds.ymin
	B()