akkartik/snap.love - Change A64NXJ55FHFWVZHMSIAO6STK44Y5G7GQQH2II7UZ2F5C5IPCL4GQC

redo font caching

This is a do-over of parts of commits: U56NDZUI3S5XU3BXXQS62PB3TLK7A7PXDGVVUYKWECXXZGU6HXAQC 2SXF7PISBPKPGAKUN7XY2Y3OG2VGCCRH2SBZK3NY2DLJ3G6A7Y4QC

The key ideas are: if edit.update_font_settings receives a font object, it's already of the requested font_height if update_editor_box receives a font, it's already of the requested height scale(20) if B receives a font, it's already of the requested height scale(20) whether B receives a font or not, all the editors on Surface will share a single font object when it's done, and the font object will have the right size A sets the font and passes it in to all the above functions.

Created by akkartik on July 26, 2024

A64NXJ55FHFWVZHMSIAO6STK44Y5G7GQQH2II7UZ2F5C5IPCL4GQC

Dependencies

In channels

main

Change contents

Replacement in 0028-A at line 2 [6.6019]

∅:D[4.160] → [5.1424:1534]

∅:D[7.358] → [5.1424:1534]

∅:D[8.1662] → [5.1424:1534]

∅:D[9.2075] → [5.1424:1534]

B:BD[10.115] → [5.1424:1534]

	love.graphics.setFont(love.graphics.newFont(scale(20)))  -- editor objects implicitly depend on current font

[8.1662]

[11.2808]

	local font = love.graphics.newFont(scale(20))
	love.graphics.setFont(font)  -- editor objects implicitly depend on current font

Replacement in 0028-A at line 13 [6.6019]

B:BD[11.3061] → [8.1663:1758]

	compute_layout(Page, Page.x,Page.y, Surface)
	compute_layout(Page2, Page2.x,Page2.y, Surface)

[11.3061]

[5.1929]

	compute_layout(Page, Page.x,Page.y, Surface, font)
	compute_layout(Page2, Page2.x,Page2.y, Surface, font)

Replacement in 0028-A at line 16 [6.6019]
B:BD[5.1955] → [8.1759:1764]
```
	B()
```
[5.1955]
[5.1960]
```
	B(font)
```
Replacement in 0028-A at line 18 [6.6019]
∅:D[9.2216] → [4.201:205]
B:BD[5.2020] → [4.201:205]
```
end
```
[5.2020]
```
end
```

Replacement in 0021-compute_layout at line 1 [12.4307]

B:BD[12.4307] → [8.1999:2053]

compute_layout = function(node, x,y, nodes_to_render)

[12.4307]

[12.4398]

compute_layout = function(node, x,y, nodes_to_render, font)

Replacement in 0021-compute_layout at line 34 [12.4307]
B:BD[12.5191] → [8.2054:2081]
```
			update_editor_box(node)
```
[12.5191]
[12.5254]
```
			update_editor_box(node, font)
```

Replacement in 0021-compute_layout at line 62 [12.4307]

B:BD[12.6029] → [8.2082:2144]

			subx,suby = compute_layout(child, x,suby, nodes_to_render)

[12.6029]

[12.6091]

			subx,suby = compute_layout(child, x,suby, nodes_to_render, font)

Replacement in 0021-compute_layout at line 90 [12.4307]

B:BD[12.6717] → [8.2145:2207]

			subx,suby = compute_layout(child, subx,y, nodes_to_render)

[12.6717]

[12.6779]

			subx,suby = compute_layout(child, subx,y, nodes_to_render, font)

Replacement in 0021-compute_layout at line 104 [12.4307]
B:BD[12.6986] → [2.46:50]
```
end
```
[12.6986]
```
end
```
Replacement in 0019-B at line 1 [13.6168]
B:BD[13.6168] → [8.2210:2225]
```
B = function()
```
[13.6168]
[5.4517]
```
B = function(font)
```

Deletion in 0019-B at line 3 [13.6168]

B:BD[5.4586] → [3.44:117]

	local font = nil  -- ensure a single font object over the whole surface

Replacement in 0019-B at line 19 [13.6168]

B:BD[5.5063] → [3.118:170]

∅:D[3.170] → [14.196:266]

B:BD[14.196] → [14.196:266]

				update_editor_box(obj, font or obj.editor.font)
				if obj.editor and obj.editor.font then font = obj.editor.font end

[5.5063]

[5.5090]

				update_editor_box(obj, font)
				if font == nil and obj.editor then font = obj.editor.font end

redo font caching

Dependencies

In channels

Change contents

Replacement in 0028-A at line 2 [6.6019]

Replacement in 0028-A at line 13 [6.6019]

Replacement in 0028-A at line 16 [6.6019]

Replacement in 0028-A at line 18 [6.6019]

Replacement in 0021-compute_layout at line 1 [12.4307]

Replacement in 0021-compute_layout at line 34 [12.4307]

Replacement in 0021-compute_layout at line 62 [12.4307]

Replacement in 0021-compute_layout at line 90 [12.4307]

Replacement in 0021-compute_layout at line 104 [12.4307]

Replacement in 0019-B at line 1 [13.6168]

Deletion in 0019-B at line 3 [13.6168]

Replacement in 0019-B at line 19 [13.6168]