akkartik/sokoban.love - Change 4Z4XY6TK3DU775XME2V2FVDN7O3D3W6DO6N4OGLGVIL6M6RPCKPQC

simplify some code now that lines contains no derived data

Created by akkartik on July 8, 2024

4Z4XY6TK3DU775XME2V2FVDN7O3D3W6DO6N4OGLGVIL6M6RPCKPQC

Dependencies

In channels

main

Change contents

Deletion in undo.lua at line 60 [4.1]
B:BD[4.1497] → [4.1497:1559]
```
  -- deep copy lines without cached stuff like text fragments
```

Replacement in undo.lua at line 61 [4.1]

B:BD[5.269] → [6.985:1017]

∅:D[5.295] → [4.1592:1624]

∅:D[6.1017] → [4.1592:1624]

∅:D[7.1102] → [4.1592:1624]

B:BD[4.1592] → [4.1592:1624]

B:BD[4.1624] → [2.1:115]

∅:D[2.115] → [4.1687:1726]

B:BD[4.1687] → [4.1687:1726]

B:BD[4.1726] → [2.116:248]

∅:D[8.239] → [4.2236:2245]

∅:D[2.248] → [4.2236:2245]

B:BD[4.2236] → [4.2236:2245]

B:BD[4.2268] → [3.139:203]

∅:D[3.203] → [4.2288:2296]

B:BD[4.2288] → [4.2288:2296]

    local line = State.lines[i]
    if line.mode == 'text' then
      table.insert(event.lines, {mode='text', data=line.data})  -- I've forgotten: should we deepcopy(line.data)?
    elseif line.mode == 'drawing' then
      table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})
    else
      assert(false, ('unknown line mode %s'):format(line.mode))
    end

[5.269]

[4.2296]

    table.insert(event.lines, deepcopy(State.lines[i]))

Deletion in source_undo.lua at line 60 [9.5]
B:BD[9.1905] → [9.1905:1967]
```
  -- deep copy lines without cached stuff like text fragments
```

Replacement in source_undo.lua at line 61 [9.5]

B:BD[9.1982] → [9.1982:2014]

B:BD[9.2014] → [10.1558:1590]

B:BD[10.1590] → [2.253:367]

∅:D[11.68] → [10.1671:1710]

∅:D[2.367] → [10.1671:1710]

B:BD[10.1671] → [10.1671:1710]

B:BD[10.1710] → [2.368:500]

∅:D[2.500] → [10.2200:2209]

B:BD[10.2200] → [10.2200:2209]

B:BD[10.2209] → [3.2457:2521]

∅:D[3.2521] → [10.2252:2260]

B:BD[10.2252] → [10.2252:2260]

    local line = State.lines[i]
    if line.mode == 'text' then
      table.insert(event.lines, {mode='text', data=line.data})  -- I've forgotten: should we deepcopy(line.data)?
    elseif line.mode == 'drawing' then
      table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})
    else
      assert(false, ('unknown line mode %s'):format(line.mode))
    end

[9.1982]

[9.2080]

    table.insert(event.lines, deepcopy(State.lines[i]))