akkartik/sokoban.love - Change CMZDG7CJKY4AO2RTV7C54WHUEHYQXDTN57R4Y5ZADZBSLNOOBDFQC

bugfix: tapping in scrollbar area

scenario 1: tap on scrollbar area off scrollbar. With the previous commit the app would crash.

scenario 2: drag down a bit, then let go, then drag the scrollbar again. With the previous commit the scrollbar would start again from 0.

Root cause: units mismatch (pixels vs normalized y between 0 and 1)

Created by akkartik on December 2, 2023

CMZDG7CJKY4AO2RTV7C54WHUEHYQXDTN57R4Y5ZADZBSLNOOBDFQC

Dependencies

In channels

main

Change contents

File addition: 0151-compute_scrollbar_topy (----------)

[3.2]

compute_scrollbar_topy = function(state)
	local f = compute_scrollbar(state)
	return state.top + f*(state.bottom - state.top)
end

Replacement in 0036-adjust_scrollbar at line 2 [5.739]

B:BD[4.525] → [2.0:75]

	local s = (y-state.scrollbar_offset-state.top) / (state.bottom-state.top)

[4.525]

[4.577]

	if state.scrollbar_offset then
		-- dragging
		y = y-state.scrollbar_offset
	end
	local s = (y-state.top) / (state.bottom-state.top)

Replacement in 0016-on.mouse_press at line 26 [7.2363]

B:BD[6.1462] → [2.189:309]

			local sbtop = compute_scrollbar(Current_pane.editor_state)
			Current_pane.editor_state.scrollbar_offset = y - sbtop

[6.1462]

			local sbtopy = compute_scrollbar_topy(Current_pane.editor_state)
			Current_pane.editor_state.scrollbar_offset = y - sbtopy
print(y, sbtopy, y-sbtopy)

Replacement in 0016-on.mouse_press at line 36 [7.2363]

B:BD[6.1893] → [2.310:379]

			local sbtop = compute_scrollbar(Current_pane.output_editor_state)

[6.1893]

[2.379]

			local sbtopy = compute_scrollbar_topy(Current_pane.output_editor_state)