akkartik/sokoban.love - Change K6DTOGOQG4YXWTFKHGZ3DIC23G5ZV3WQZQPRRDYIWEGLNQW6QDGQC

flip return value of button handlers

This is compatible with Javascript, and it also seems like a better default; when people forget to think about return values in click handlers, they should be consumed.

Created by Kartik K. Agaram on August 23, 2022

K6DTOGOQG4YXWTFKHGZ3DIC23G5ZV3WQZQPRRDYIWEGLNQW6QDGQC

Dependencies

In channels

main

Change contents

Deletion in edit.lua at line 166 [5.413]

B:BD[3.935] → [4.15:113]

                       return true  -- don't handle any other events with this mouse button press

Replacement in edit.lua at line 211 [5.413]

B:BD[6.4647] → [2.114:179]

  if propagate_to_button_handlers(State, x,y, mouse_button) then

[6.4647]

[4.172]

  if mouse_press_consumed_by_any_button_handler(State, x,y, mouse_button) then

Replacement in button.lua at line 3 [8.2058]

B:BD[7.117] → [7.117:203]

-- If the handler returns true, it'll prevent any further processing of the
-- event.

[7.117]

[8.2080]

-- If any applicable button handler returns true, it'll propagate the click to other handlers.

Replacement in button.lua at line 17 [8.2058]

B:BD[8.2443] → [2.344:409]

function propagate_to_button_handlers(State, x, y, mouse_button)

[8.2443]

[2.409]

function mouse_press_consumed_by_any_button_handler(State, x, y, mouse_button)

Replacement in button.lua at line 24 [8.2058]
B:BD[9.66] → [4.258:287]
```
        return ev.onpress1()
```
[9.66]
[9.88]
```
        return not ev.onpress1()
```