akkartik/sokoban.love - Change OJGIQLZWADBO2UN2BLF5RCNQHQW3TQYP6EEA6QCK2PLV4TJGCWAQC

bugfix: only check for settings menu when open

Scenario I was seeing:

on an Android phone
when font size is small
if I scrolled down a bit
and then tapped on the editor

Then before this commit, the scrollbar would move. Even though I was tapping nowhere near the scrollbar. Or even the settings area!

I carefully bisected this down to change NVZTMKERX3N and this code in on.mouse_release:

if on_area(Settings_menu_area, x,y) then return end

What was actually going on in the above scenario:

on a device with a small screen
after I open the settings menu once
the scrollbar overlaps the erstwhile setting menu, so that dragging the scrollbar doesn't trigger on.mouse_receive
as a result the scrollbar is still active when I tap the editor.

Holy smokes!

Created by akkartik on December 3, 2023

OJGIQLZWADBO2UN2BLF5RCNQHQW3TQYP6EEA6QCK2PLV4TJGCWAQC

Dependencies

In channels

main

Change contents

Replacement in 0017-on.mouse_release at line 9 [3.2211]

B:BD[2.166] → [2.166:217]

	if on_area(Settings_menu_area, x,y) then
		return

[2.166]

[2.217]

	if Show_settings then
		if on_area(Settings_menu_area, x,y) then
			return
		end

Replacement in 0012-on.draw at line 25 [3.2899]

∅:D[4.1960] → [3.3033:3036]

∅:D[5.2223] → [3.3033:3036]

B:BD[3.3033] → [3.3033:3036]

end

[5.2223]

  love.graphics.print('06', 20,150)
  if Settings_menu_area.x then
    App.color{r=1, g=0.8, b=0}
    love.graphics.rectangle('line', Settings_menu_area.x, Settings_menu_area.y, Settings_menu_area.w, Settings_menu_area.h)
  end
end