akkartik/sokoban.love - Change P5QNVXSNGPUYFDBHK6KJMFDVG6U6S5Q3KRQICGK7AZ7FKZE7OJJQC

drop final mention of state global beyond main.lua

This is all unfortunate in several ways

lots of functions have extra args
table lookups where we used to have a simple variable
program initialization is a lot more delicate

Let's see if it was worthwhile. Can we now actually build around the editor component in forks?

Created by Kartik K. Agaram on July 13, 2022

P5QNVXSNGPUYFDBHK6KJMFDVG6U6S5Q3KRQICGK7AZ7FKZE7OJJQC

Dependencies

In channels

main

Change contents

Replacement in drawing.lua at line 29 [3.98]

B:BD[3.817] → [4.36956:37029]

  local mx,my = Drawing.coord(pmx-State.left), Drawing.coord(pmy-line.y)

[3.817]

[3.894]

  local mx,my = Drawing.coord(pmx-State.left, State.width), Drawing.coord(pmy-line.y, State.width)

Replacement in drawing.lua at line 123 [3.98]

B:BD[5.1944] → [6.1644:1730]

    local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[5.1944]

[5.2082]

    local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)

Replacement in drawing.lua at line 130 [3.98]

B:BD[5.2327] → [6.1731:1817]

    local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[5.2327]

[5.2465]

    local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)

Replacement in drawing.lua at line 159 [3.98]

B:BD[7.2201] → [7.2201:2267]

    local mx,my = Drawing.coord(pmx-left), Drawing.coord(pmy-top)

[7.2201]

[7.2267]

    local mx,my = Drawing.coord(pmx-left, width), Drawing.coord(pmy-top, width)

Replacement in drawing.lua at line 173 [3.98]

B:BD[7.3281] → [7.3281:3347]

    local mx,my = Drawing.coord(pmx-left), Drawing.coord(pmy-top)

[7.3281]

[7.3347]

    local mx,my = Drawing.coord(pmx-left, width), Drawing.coord(pmy-top, width)

Replacement in drawing.lua at line 181 [3.98]

B:BD[5.3457] → [6.2027:2113]

    local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[5.3457]

[5.3555]

    local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)

Replacement in drawing.lua at line 189 [3.98]

B:BD[5.3892] → [6.2202:2288]

    local mx,my = Drawing.coord(App.mouse_x()-left), Drawing.coord(App.mouse_y()-top)

[5.3892]

[5.3990]

    local mx,my = Drawing.coord(App.mouse_x()-left, width), Drawing.coord(App.mouse_y()-top, width)

Deletion in drawing.lua at line 206 [3.98]
B:BD[8.646] → [5.4359:4360]

Replacement in drawing.lua at line 214 [3.98]

B:BD[9.191] → [4.37550:37678]

    drawing.pending = {mode=State.current_drawing_mode, points={{x=Drawing.coord(x-State.left), y=Drawing.coord(y-drawing.y)}}}

[9.191]

[9.326]

    drawing.pending = {mode=State.current_drawing_mode, points={{x=Drawing.coord(x-State.left, State.width), y=Drawing.coord(y-drawing.y, State.width)}}}

Replacement in drawing.lua at line 216 [3.98]

B:BD[9.422] → [2.5568:5697]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[9.422]

[9.537]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)

Replacement in drawing.lua at line 219 [3.98]

B:BD[9.740] → [2.5698:5827]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[9.740]

[9.855]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)

Replacement in drawing.lua at line 222 [3.98]

B:BD[9.978] → [2.5828:5957]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left), Drawing.coord(y-drawing.y), State.width)

[9.978]

[9.1093]

    local j = Drawing.find_or_insert_point(drawing.points, Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width), State.width)

Replacement in drawing.lua at line 243 [3.98]

B:BD[10.433] → [4.38006:38138]

        table.insert(drawing.pending.points, {x=Drawing.coord(App.mouse_x()-State.left), y=Drawing.coord(App.mouse_y()-drawing.y)})

[10.433]

[10.565]

        table.insert(drawing.pending.points, {x=Drawing.coord(App.mouse_x()-State.left, State.width), y=Drawing.coord(App.mouse_y()-drawing.y, State.width)})

Replacement in drawing.lua at line 245 [3.98]

B:BD[10.614] → [4.38139:38217]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[10.614]

[10.684]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 253 [3.98]

∅:D[2.6098] → [4.38218:38294]

B:BD[10.881] → [4.38218:38294]

      local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.6098]

[10.949]

      local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 299 [3.98]

B:BD[11.227] → [4.38295:38373]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.227]

[11.297]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 306 [3.98]

B:BD[11.627] → [4.38374:38452]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.627]

[11.697]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 318 [3.98]

B:BD[11.1231] → [4.38544:38622]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.1231]

[11.1301]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 326 [3.98]

B:BD[11.1668] → [4.38623:38703]

          local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.1668]

[11.1740]

          local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 341 [3.98]

B:BD[11.2366] → [4.38704:38784]

          local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.2366]

[11.2438]

          local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 352 [3.98]

B:BD[11.2970] → [4.38785:38863]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.2970]

[11.3040]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 359 [3.98]

B:BD[11.3348] → [4.38864:38942]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[11.3348]

[11.3418]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 465 [3.98]

B:BD[12.413] → [4.38943:39041]

    local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[12.413]

[2.7883]

    local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)

Replacement in drawing.lua at line 470 [3.98]

B:BD[12.467] → [4.39042:39140]

    local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[12.467]

[2.7963]

    local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)

Replacement in drawing.lua at line 481 [3.98]

B:BD[13.7258] → [4.39141:39239]

    local mx,my = Drawing.coord(App.mouse_x()-State.left), Drawing.coord(App.mouse_y()-drawing.y)

[13.7258]

[13.7414]

    local mx,my = Drawing.coord(App.mouse_x()-State.left, State.width), Drawing.coord(App.mouse_y()-drawing.y, State.width)

Replacement in drawing.lua at line 619 [3.98]

∅:D[2.8334] → [4.39240:39318]

B:BD[14.749] → [4.39240:39318]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.8334]

[15.19800]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 636 [3.98]

∅:D[2.8406] → [4.39319:39397]

B:BD[14.867] → [4.39319:39397]

        local mx,my = Drawing.coord(x-State.left), Drawing.coord(y-drawing.y)

[2.8406]

[15.20403]

        local mx,my = Drawing.coord(x-State.left, State.width), Drawing.coord(y-drawing.y, State.width)

Replacement in drawing.lua at line 717 [3.98]

B:BD[15.27533] → [15.27533:27579]

B:BD[15.27579] → [4.39509:39555]

function Drawing.coord(n)  -- pixels to parts
  return math.floor(n*256/Editor_state.width)

[15.27533]

[13.11944]

function Drawing.coord(n, width)  -- pixels to parts
  return math.floor(n*256/width)