akkartik/sokoban.love - Change POQ23S4HCIJJ22SXKQ5SWXE4F27UUHROKRJVONHV54IMRSBW2ZIQC

fix startup test failures from the driver

Still klunky in one place: when you open the driver the failing test isn't highlighted in red. I need to communicate the structured data of test failures in run-time errors when the tests weren't triggered by a driver command.

Created by akkartik on November 17, 2023

POQ23S4HCIJJ22SXKQ5SWXE4F27UUHROKRJVONHV54IMRSBW2ZIQC

Dependencies

In channels

main

Change contents

Replacement in app.lua at line 141 [5.2]

B:BD[3.61] → [4.18:94]

    error('There were test failures:\n\n'..table.concat(Test_errors, '\n'))

[3.61]

[3.131]

    Mode = 'error'
    Redo_initialization = true
    Error_message = 'There were test failures:\n\n'..table.concat(Test_errors, '\n')
    live.send_run_time_error_to_driver(Error_message)

Insertion in Manual_tests.md at line 124 [6.1]

[2.2001]

Driver can connect to app that contains test failures on startup.

Insertion in Manual_tests.md at line 126 [6.1]

[2.2076]

[7.1501]

  driver, define a new test with an invalid assertion:
    ```
    test_foo = function()
        check(nil, 'foo')
    end
    ```
  Hit F4. The test fails.
  Quit the client app and restart. App shows an error.
  Edit `test_foo` in the driver and remove the error:
    ```
    test_foo = function()
    end
    ```
  Hit F4. The error disappears from the app and driver.
* clone this repo to a new client app, clear its save dir, run it, run the
  driver, define a new test with an invalid assertion:
    ```
    test_foo = function()
        check(nil, 'foo')
    end
    ```
  Hit F4.
  Quit the client app and restart. App shows an error.
  Hit F4 again in the driver (without fixing the error).
  The client app continues to show the error.
* clone this repo to a new client app, clear its save dir, run it, run the