akkartik/snap.love - Change YTSPVDZHEN5LLNMGIBUBLPWFWSFM3SOHBRGWYSDEVFKRTH24ARRQC

first successful pagedown test, first bug found by test

I also really need to rethink how people debug my programs. My approach of inserting and deleting print() takes a lot of commitment. I need my old trace-based whitebox testing idea. However, in my past projects I never did figure out a good framework for tweaking how verbose a trace to emit.

Perhaps that's too many knobs. Perhaps we just need a way to run a single test with the most verbose trace possible. Then it's just a matter of having the trace tell a coherent story? But even if the trace stays out of program output in that situation, it's still in the programmer's face in the code. Ugh.

Current plan: ship program with maximum tests and zero commented-out prints. If you want to debug, insert prints. This is better than previous, text-mode, projects just by virtue of the stdout channel being dedicated to debug stuff.

Created by Kartik K. Agaram on May 23, 2022

YTSPVDZHEN5LLNMGIBUBLPWFWSFM3SOHBRGWYSDEVFKRTH24ARRQC

Dependencies

In channels

main

Change contents

Replacement in text.lua at line 31 [7.1]

B:BD[5.119] → [6.1:104]

        if New_foo then print('text: new screen line', y, Screen_height, screen_line_starting_pos) end

[5.119]

[8.255]

        if New_foo then print('text: new screen line', y, App.screen.height, screen_line_starting_pos) end

Replacement in text.lua at line 42 [7.1]

B:BD[6.184] → [6.184:241]

        if y + math.floor(15*Zoom) >= Screen_height then

[6.184]

[6.241]

        if y + math.floor(15*Zoom) >= App.screen.height then

Insertion in text.lua at line 82 [7.1]
[4.137]
[4.137]
```
  print('test_draw_text')
```

Insertion in text.lua at line 101 [7.1]

[4.681]

[9.1]

function test_pagedown()
  print('test_pagedown')
  App.screen.init{width=120, height=45}
  Lines = load_array{'abc', 'def', 'ghi'}
  Line_width = 120
  Cursor1 = {line=1, pos=1}
  Screen_top1 = {line=1, pos=1}
  Screen_bottom1 = {}
  Zoom = 1
  local screen_top_margin = 15  -- pixels
  local line_height = math.floor(15*Zoom)  -- pixels
  -- initially the first two lines are displayed
  App.draw()
  local y = screen_top_margin
  App.screen.check(y, 'abc', 'F - test_pagedown/baseline/screen:1')
  y = y + line_height
  App.screen.check(y, 'def', 'F - test_pagedown/baseline/screen:2')
  -- after pagedown the bottom line becomes the top
  App.run_after_keychord('pagedown')
  y = screen_top_margin
  App.screen.check(y, 'def', 'F - test_pagedown/screen:1')
  y = y + line_height
  App.screen.check(y, 'ghi', 'F - test_pagedown/screen:2')
end
function test_pagedown_skip_drawings()
  print('test_pagedown_skip_drawings')
  -- some lines of text with a drawing intermixed
  App.screen.init{width=50, height=45}
  Lines = load_array{'abc',
                     '```lines', '```',
                     'def',
                     'ghi'}
  check_eq(Lines[2].mode, 'drawing', 'F - test_pagedown_skip_drawings/baseline/lines')
  Line_width = App.screen.width
  Cursor1 = {line=1, pos=1}
  Screen_top1 = {line=1, pos=1}
  Screen_bottom1 = {}
  Zoom = 1
  local screen_top_margin = 15  -- pixels
  local drawing_height = App.screen.width / 2  -- default
  -- initially the screen displays the first line and part of the drawing
  App.draw()
  local y = screen_top_margin
  App.screen.check(y, 'abc', 'F - test_pagedown_skip_drawings/baseline/screen:1')
  -- after pagedown the screen draws the screen up top
  App.run_after_keychord('pagedown')
  y = screen_top_margin + drawing_height
  App.screen.check(y, 'def', 'F - test_pagedown_skip_drawings/screen:1')
  y = y + line_height
  App.screen.check(y, 'ghi', 'F - test_pagedown_skip_drawings/screen:2')
end

Insertion in text.lua at line 433 [7.1]
[10.6916]
[10.6916]
```
    print('scroll up')
```

Replacement in text.lua at line 442 [7.1]

B:BD[2.210] → [2.210:258]

  local y = Screen_height - math.floor(15*Zoom)

[2.210]

[11.455]

  local y = App.screen.height - math.floor(15*Zoom)

Replacement in main.lua at line 84 [12.2]
B:BD[6.1592] → [6.1592:1607]
```
New_foo = true
```
[6.1592]
[12.47]
```
Debug_main = false
```

Replacement in main.lua at line 123 [12.2]

B:BD[13.18] → [6.1978:2017]

  if New_foo then print('== draw') end

[13.18]

[14.2]

  if Debug_main then print('== draw') end

Replacement in main.lua at line 125 [12.2]

B:BD[14.44] → [6.2018:2072]

    if New_foo then print('draw:', line_index, y) end

[14.44]

[3.338]

    if Debug_main then print('draw:', line_index, y) end

Replacement in main.lua at line 149 [12.2]

B:BD[15.1510] → [6.2073:2115]

        if New_foo then print('text') end

[15.1510]

[13.194]

        if Debug_main then print('text') end

Replacement in main.lua at line 153 [12.2]

B:BD[16.108] → [6.2116:2159]

        if New_foo then print('aa', y) end

[16.108]

[15.1574]

        if Debug_main then print('aa', y) end

Replacement in main.lua at line 157 [12.2]
B:BD[12.416] → [6.2160:2178]
```
  New_foo = false
```
[12.416]
[8.408]
```
  Debug_main = false
```
Replacement in main.lua at line 198 [12.2]
∅:D[17.1550] → [6.2179:2196]
B:BD[18.123] → [6.2179:2196]
```
  New_foo = true
```
[17.1550]
[19.4920]
```
--?   Debug_main = true
```
Insertion in main.lua at line 229 [12.2]
[15.1627]
[10.9490]
```
    print('setting top to', Screen_bottom1.line)
```
Replacement in file.lua at line 110 [20.15083]
B:BD[4.1467] → [4.1467:1490]
```
  local i,line = 0, ''
```
[4.1467]
[4.1490]
```
  local i,line,drawing = 0, ''
```
Insertion in file.lua at line 114 [20.15083]
[4.1566]
[4.1566]
```
--?     print(line)
```

Replacement in file.lua at line 116 [20.15083]

B:BD[4.1671] → [4.1671:1740]

      table.insert(result, load_drawing_from_array(next_line, a, i))

[4.1671]

[4.1740]

--?       print('inserting drawing')
      i, drawing = load_drawing_from_array(next_line, a, i)
--?       print('i now', i)
      table.insert(result, drawing)

Insertion in file.lua at line 121 [20.15083]
[4.1749]
[4.1749]
```
--?       print('inserting text')
```
Insertion in file.lua at line 137 [20.15083]
[4.2106]
[4.2106]
```
--?     print(i)
```
Replacement in file.lua at line 165 [20.15083]
B:BD[4.3255] → [4.3255:3272]
```
  return drawing
```
[4.3255]
[20.18207]
```
  return i, drawing
```
Replacement in app.lua at line 96 [21.2]
B:BD[17.4434] → [17.4434:4475]
```
--     App.run_with_keypress('pagedown')
```
[17.4434]
[17.4475]
```
--     App.run_after_keypress('pagedown')
```
Insertion in app.lua at line 141 [21.2]
[17.6151]
[17.6151]
```
  print('drawing "'..msg..'" at y '..tostring(y))
```

Insertion in app.lua at line 175 [21.2]

[17.7039]

  App.screen.contents = {}
  App.draw()
end
function App.run_after_keychord(key)
  App.keychord_pressed(key)

Insertion in app.lua at line 192 [21.2]

[17.7257]

  if App.screen.contents[screen_row] == nil then
    error('no text at y '..tostring(y))
  end

first successful pagedown test, first bug found by test

Dependencies

In channels

Change contents

Replacement in text.lua at line 31 [7.1]

Replacement in text.lua at line 42 [7.1]

Insertion in text.lua at line 82 [7.1]

Insertion in text.lua at line 101 [7.1]

Insertion in text.lua at line 433 [7.1]

Replacement in text.lua at line 442 [7.1]

Replacement in main.lua at line 84 [12.2]

Replacement in main.lua at line 123 [12.2]

Replacement in main.lua at line 125 [12.2]

Replacement in main.lua at line 149 [12.2]

Replacement in main.lua at line 153 [12.2]

Replacement in main.lua at line 157 [12.2]

Replacement in main.lua at line 198 [12.2]

Insertion in main.lua at line 229 [12.2]

Replacement in file.lua at line 110 [20.15083]

Insertion in file.lua at line 114 [20.15083]

Replacement in file.lua at line 116 [20.15083]

Insertion in file.lua at line 121 [20.15083]

Insertion in file.lua at line 137 [20.15083]

Replacement in file.lua at line 165 [20.15083]

Replacement in app.lua at line 96 [21.2]

Insertion in app.lua at line 141 [21.2]

Insertion in app.lua at line 175 [21.2]

Insertion in app.lua at line 192 [21.2]