akkartik/sokoban.love - Change ZPQI5UL3V6QIZXWGXO2DZOCCTLIUOQSRP3LIQKEARIQQSNA6RO6AC

bugfix: never use utf8 pos in string.sub

This is a violation of an existing rule in Manual_tests.md. The following command weakly suggests there aren't any others: grep ':sub(' *.lua |grep pos

Created by Kartik K. Agaram on May 6, 2023

ZPQI5UL3V6QIZXWGXO2DZOCCTLIUOQSRP3LIQKEARIQQSNA6RO6AC

Dependencies

In channels

main

Change contents

Replacement in text.lua at line 36 [5.1]

B:BD[4.458] → [4.458:608]

            if State.lines[State.cursor1.line].data:sub(State.cursor1.pos, State.cursor1.pos+utf8.len(State.search_term)-1) == State.search_term then

[4.458]

[2.741]

            local data = State.lines[State.cursor1.line].data
            local cursor_offset = Text.offset(data, State.cursor1.pos)
            if data:sub(cursor_offset, cursor_offset+#State.search_term-1) == State.search_term then

Replacement in source_text.lua at line 58 [6.83723]

B:BD[6.88448] → [6.88448:88598]

            if State.lines[State.cursor1.line].data:sub(State.cursor1.pos, State.cursor1.pos+utf8.len(State.search_term)-1) == State.search_term then

[6.88448]

[3.1540]

            local data = State.lines[State.cursor1.line].data
            local cursor_offset = Text.offset(data, State.cursor1.pos)
            if data:sub(cursor_offset, cursor_offset+#State.search_term-1) == State.search_term then

Replacement in Manual_tests.md at line 31 [8.1]

B:BD[7.99] → [7.99:188]

  For example, `string.sub` should never use a `_pos` to substring, only an
  `_offset`.

[7.99]

[9.252]

  For example, `string.sub` should never use a `_pos`, only an `_offset`.