akkartik/techmeet.love - Change ONVQPNBJRWL3VLMV3UJGQOKR26GELHHOUZ7F3ISVVY6ET6OVITOQC

bugfix

Scenario:

get 2 copies of a note on screen at once (say by running 'extract' on a note at the top of recent changes)
click on one of them to focus cursor on it
press ctrl-e to edit then again to stop editing
press ctrl-e again to edit, then hit enter

Before this commit the app would crash on an assertion failure; a pane's line and line_cache were no longer in sync.

I'm fixing it by reloading all other copies of a pane from disk immediately after writing it to disk. Which may well be massively slower, but is a) likely cached by the OS, and b) not noticeable.

This bug has likely been present since 2022-11 (commit 813e06fd4d).

Created by Kartik K. Agaram on March 28, 2023

ONVQPNBJRWL3VLMV3UJGQOKR26GELHHOUZ7F3ISVVY6ET6OVITOQC

Dependencies

In channels

main

Change contents

Deletion in text.lua at line 196 [7.1]
∅:D[5.1180] → [6.48:121]
B:BD[6.48] → [6.48:121]
```
--?   print('chord', chord, State.selection1.line, State.selection1.pos)
```

Insertion in text.lua at line 198 [7.1]

[8.655]

[6.122]

--?     print_and_log(('text.keychord press %s %d %d'):format(chord, #State.lines, #State.line_cache))

Insertion in text.lua at line 208 [7.1]

[9.1313]

[10.134]

--?     print_and_log(('text.keychord press done %s %d %d'):format(chord, #State.lines, #State.line_cache))

Insertion in text.lua at line 389 [7.1]

[11.2057]

--?   print_and_log(('text.insert_return %d %d'):format(#State.lines, #State.line_cache))

Insertion in text.lua at line 396 [7.1]

[12.174]

[13.46]

--?   print_and_log(('text.insert_return done'):format(#State.lines, #State.line_cache))

Insertion in run.lua at line 420 [15.178044]

[14.17791]

--?     print_and_log(('draw_normal_mode %d,%d %s %s'):format(pane.column_index, pane.pane_index, pane, pane.lines))

Insertion in run.lua at line 430 [15.178044]

[14.18165]

--?     if Foo_pane then
--?       print_and_log(('run.draw_normal_mode %d,%d %s %s %d %d -- %d,%d %s %s %d %d'):format(pane.column_index, pane.pane_index, pane, pane.lines, #pane.lines, #pane.line_cache, Foo_pane.column_index, Foo_pane.pane_index, Foo_pane, Foo_pane.lines, #Foo_pane.lines, #Foo_pane.line_cache))
--?     end

Insertion in run.lua at line 864 [15.178044]

[16.2753]

--?             print_and_log(('run.keychord press %s %d %d'):format(chord, #pane.lines, #pane.line_cache))

Insertion in run.lua at line 867 [15.178044]

[17.1181]

[2.17]

--?             print_and_log(('run.keychord press2 %s %d %d'):format(chord, #pane.lines, #pane.line_cache))

Insertion in run.lua at line 877 [15.178044]

[18.577]

[16.3123]

--?             print_and_log(('run.keychord press9 %s %d %d'):format(chord, #pane.lines, #pane.line_cache))

Insertion in run.lua at line 1412 [15.178044]
[14.52140]
[14.52140]
```
--?   print_and_log('stop_editing_all')
```

Replacement in run.lua at line 1426 [15.178044]

B:BD[14.52408] → [3.17:53]

  log(2, 'stop_editing: '..pane.id)

[14.52408]

--?   print_and_log(('stop_editing: %s %s'):format(pane, pane.id))

Replacement in run.lua at line 1561 [15.178044]
B:BD[14.57958] → [14.57958:57984]
```
--?   print('refreshing')
```
[14.57958]
[14.58020]
```
--?   print_and_log(('refreshing %s %s'):format(pane, pane.id))
```

Replacement in run.lua at line 1565 [15.178044]

B:BD[14.58114] → [14.58114:58217]

--?         print(x,y)
        p.lines = pane.lines
        p._height = nil
        Text.redraw_all(p)

[14.58114]

[14.58217]

        if p ~= pane then
          Surface[x][y] = load_pane(pane.id)
        end

Insertion in main.lua at line 59 [20.2]
[14.60841]
[19.8]
```
--?   Foo_pane = nil
```

Insertion in main.lua at line 159 [20.2]

[14.63225]

--?     if Foo_pane then
--?       print_and_log(('App.draw %d %d'):format(#Foo_pane.lines, #Foo_pane.line_cache))
--?     end

Insertion in main.lua at line 212 [20.2]

[14.63582]

[17.2082]

--?     local pane = Surface[Cursor_pane.col][Cursor_pane.row]
--?     if pane and pane.editable then
--?       print_and_log(('App.keychord press %s %d %d'):format(chord, #pane.lines, #pane.line_cache))
--?     end

Insertion in main.lua at line 217 [20.2]

[17.2148]

[14.63652]

--?     if pane and pane.editable then
--?       print_and_log(('App.keychord press %s %d %d'):format(chord, #pane.lines, #pane.line_cache))
--?       Foo_pane = pane
--?     end

Insertion in edit.lua at line 157 [23.413]

[21.2727]

[22.15]

--?   print_and_log(('edit.draw %d %d'):format(#State.lines, #State.line_cache))

Replacement in edit.lua at line 161 [23.413]

B:BD[24.74] → [4.192:330]

    log(2, os.date('%Y/%m/%d/%H-%M-%S')..(' line_cache is out of date; %d when it should be %d'):format(#State.line_cache, #State.lines))

[24.74]

[24.200]

    print_and_log(os.date('%Y/%m/%d/%H-%M-%S')..(' line_cache is out of date; %d when it should be %d'):format(#State.line_cache, #State.lines))

Insertion in edit.lua at line 549 [23.413]

[25.1400]

[5.5720]

--?     print_and_log(('edit.keychord press done %s %d %d'):format(chord, #State.lines, #State.line_cache))

Insertion in edit.lua at line 551 [23.413]

[5.5758]

[23.15990]

--?     print_and_log(('edit.keychord press done %s %d %d'):format(chord, #State.lines, #State.line_cache))