akkartik/techmeet.love - Change S4TFD5YYEMH24RVOO5THEOW7WUP4FSICR4UYABSRE2UKXYCNN4DQC

bugfix: don't bother with panning support when maximized

scenario: maximize a pane click on a line

Before this commit the cursor was positioned way to the right, because mouse press had the right pane bounds but mouse release had the unmaximized pane bounds.

Perhaps we should also check that the mouse isn't on a pane. Unclear which way is more inefficient: repeatedly recomputing pane bounds or repeatedly querying for mouse coordinates.

Created by Kartik K. Agaram on August 4, 2022

S4TFD5YYEMH24RVOO5THEOW7WUP4FSICR4UYABSRE2UKXYCNN4DQC

Dependencies

In channels

main

Change contents

Insertion in text.lua at line 703 [4.1]

[3.59]

--?   print('Text.to_pos_on_line', State.left, State.right, App.screen.width, mx)

Insertion in main.lua at line 282 [6.2]
[5.238]
[5.238]
```
--?   print('update pane bounds')
```

Replacement in main.lua at line 442 [6.2]

B:BD[7.584] → [8.522:550]

  if App.mouse_down(1) then

[7.584]

[5.2032]

  if not Display_settings.show_palette and Display_settings.mode == 'normal' and App.mouse_down(1) then
    -- pan the surface by dragging

Insertion in Manual_tests.md at line 52 [9.1]

[2.168]

* maximize pane, click on a line of text -> nothing is selected