akkartik/techmeet.love - Change SPTL7VK47SAGTCGQDCQWMEFC43KWJNWCL76NSYHEVBENHIWKRWNAC

bugfix: bunch of crashes due to empty columns

Created by Kartik K. Agaram on August 9, 2022

SPTL7VK47SAGTCGQDCQWMEFC43KWJNWCL76NSYHEVBENHIWKRWNAC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 140 [7.2]

[6.127]

[5.487]

  Cursor_pane.col = math.min(Cursor_pane.col, #Surface)
  if Cursor_pane.col > 0 then
    Cursor_pane.row = math.min(Cursor_pane.row, #Surface[Cursor_pane.col])
  end

Replacement in main.lua at line 503 [7.2]
B:BD[2.96] → [2.96:122]
```
    if pane.editable then
```
[2.96]
[2.122]
```
    if pane and pane.editable then
```
Replacement in main.lua at line 568 [7.2]
B:BD[8.355] → [9.216:240]
```
  if pane.editable then
```
[8.355]
[8.382]
```
  if pane and pane.editable then
```
Replacement in main.lua at line 707 [7.2]
B:BD[10.67] → [10.67:93]
```
    if pane.editable then
```
[10.67]
[10.93]
```
    if pane and pane.editable then
```
Replacement in main.lua at line 1030 [7.2]
B:BD[11.179] → [9.397:421]
```
  if pane.editable then
```
[11.179]
[12.84]
```
  if pane and pane.editable then
```

Replacement in commands.lua at line 102 [14.39]

B:BD[13.1472] → [13.1472:1516]

  if Display_settings.mode == 'normal' then

[13.1472]

[13.1516]

  if Display_settings.mode == 'normal'
    and Cursor_pane.col > 0  -- not an empty pane
  then

Replacement in commands.lua at line 106 [14.39]

B:BD[13.1575] → [13.1575:1722]

B:BD[13.1722] → [15.629:705]

∅:D[15.705] → [13.1969:2319]

B:BD[13.1969] → [13.1969:2319]

    if not pane.editable then
      local left_sx = left_edge_sx(Cursor_pane.col)
      local up_sy = up_edge_sy(Cursor_pane.col, Cursor_pane.row)
      if should_show_column(left_sx) and should_show_pane(pane, up_sy) then
        add_hotkey_to_menu('ctrl+e: edit')
        add_panning_hotkeys_to_menu()
      end
      add_hotkey_to_menu('x/X: narrower/wider columns')
    else
      if pane.cursor_x >= 0 and pane.cursor_x < App.screen.width and pane.cursor_y >= Header_height and pane.cursor_y < App.screen.height then
        add_hotkey_to_menu('ctrl+e: stop editing')

[13.1575]

[13.2319]

    if pane then
      if not pane.editable then
        local left_sx = left_edge_sx(Cursor_pane.col)
        local up_sy = up_edge_sy(Cursor_pane.col, Cursor_pane.row)
        if should_show_column(left_sx) and should_show_pane(pane, up_sy) then
          add_hotkey_to_menu('ctrl+e: edit')
          add_panning_hotkeys_to_menu()
        end
        add_hotkey_to_menu('x/X: narrower/wider columns')

Replacement in commands.lua at line 116 [14.39]

B:BD[13.2330] → [13.2330:2368]

        add_panning_hotkeys_to_menu()

[13.2330]

[13.2368]

        if pane.cursor_x >= 0 and pane.cursor_x < App.screen.width and pane.cursor_y >= Header_height and pane.cursor_y < App.screen.height then
          add_hotkey_to_menu('ctrl+e: stop editing')
        else
          add_panning_hotkeys_to_menu()
        end

Insertion in commands.lua at line 258 [14.39]

[16.1686]

[17.125]

  if pane == nil then
    return Commands.normal
  end

Insertion in commands.lua at line 802 [14.39]

[4.720]

  end
  --
  while Cursor_pane.row > #Surface[Cursor_pane.col] do
    Cursor_pane.row = #Surface[Cursor_pane.col]
    if Cursor_pane.row == 0 then
      Cursor_pane.col = Cursor_pane.col - 1
      Cursor_pane.row = 1
    end

Insertion in Manual_tests.md at line 16 [19.1]

[3.86]

[18.3272]


* Starting up from a blank slate, with an empty directory of files.