akkartik/etch.love - Change UZQ2LGHQ4SKSSPID5HSPHAO56XNMYZTDMSJLIPEA5ZQ7G7DBVMCQC

bugfix: preserve window position

I just noticed we hadn't got this bugfix for Linux on the main app. How had we not noticed this issue before? Answer: lines.love windows tend to be tall and skinny, and resize must keep the window entirely within the screen. So the window was staying in place just because it happened to be running up against the bottom.

Created by Kartik K. Agaram on July 10, 2023

UZQ2LGHQ4SKSSPID5HSPHAO56XNMYZTDMSJLIPEA5ZQ7G7DBVMCQC

Dependencies

In channels

main

Change contents

Replacement in run.lua at line 66 [3.178044]

B:BD[2.321] → [2.321:386]

  App.screen.move(Settings.x, Settings.y, Settings.displayindex)

[2.321]

[3.180008]

  run.set_window_position_from_settings(Settings)

Insertion in run.lua at line 71 [3.178044]

[3.180297]

end
function run.set_window_position_from_settings(settings)
  local os = love.system.getOS()
  if os == 'Linux' then
    -- love.window.setPosition doesn't quite seem to do what is asked of it on Linux.
    App.screen.move(settings.x, settings.y-37, settings.displayindex)
  else
    App.screen.move(settings.x, settings.y, settings.displayindex)
  end