akkartik/techmeet.love - Change WSFK3NJI3XMC6GGNVTWYFKEPJWT2RWVXSFI3V7L5C36Q43BJGFAQC

disable C-return in palette mode

Nothing was broken, but we need to start thinking about mode interactions more carefully.

Created by Kartik K. Agaram on August 11, 2022

WSFK3NJI3XMC6GGNVTWYFKEPJWT2RWVXSFI3V7L5C36Q43BJGFAQC

Dependencies

In channels

main

Change contents

Deletion in main.lua at line 736 [5.2]

B:BD[4.728] → [2.8:83]

  elseif chord == 'C-return' then
    Display_settings.show_palette = true

Replacement in main.lua at line 740 [5.2]

B:BD[6.215] → [3.1932:1965]

    if Cursor_pane.col >= 1 then

[6.215]

[3.1965]

    if chord == 'C-return' then
      Display_settings.show_palette = true
    elseif Cursor_pane.col >= 1 then

Replacement in main.lua at line 753 [5.2]

B:BD[7.980] → [8.8:58]

    keychord_pressed_in_maximize_mode(chord, key)

[7.980]

[9.1090]

    if chord == 'C-return' then
      Display_settings.show_palette = true
    else
      keychord_pressed_in_maximize_mode(chord, key)
    end

Insertion in Manual_tests.md at line 87 [11.1]

[10.169]

Mode interactions:
* Can show palette in maximized mode
* Can show palette when editing a pane
* Can show palette when editing a maximized pane (capture/focus mode)